Commit a94741e9 authored by Daniel Tian's avatar Daniel Tian

Address MR comments 2

parent d028a9c4
...@@ -156,10 +156,10 @@ export default { ...@@ -156,10 +156,10 @@ export default {
return this.dismissalFeedback || this.modal.isCommentingOnDismissal; return this.dismissalFeedback || this.modal.isCommentingOnDismissal;
}, },
showDismissalCommentActions() { showDismissalCommentActions() {
return !this.dismissalFeedbackComment || !this.isEditingExistingFeedback; return !this.dismissalFeedback?.comment_details || !this.isEditingExistingFeedback;
}, },
showDismissalCommentTextbox() { showDismissalCommentTextbox() {
return !this.dismissalFeedbackComment || this.isEditingExistingFeedback; return !this.dismissalFeedback?.comment_details || this.isEditingExistingFeedback;
}, },
}, },
methods: { methods: {
......
...@@ -69,7 +69,7 @@ describe('Vulnerability Header', () => { ...@@ -69,7 +69,7 @@ describe('Vulnerability Header', () => {
const findStatusDescription = () => wrapper.find(StatusDescription); const findStatusDescription = () => wrapper.find(StatusDescription);
const createWrapper = (vulnerability = {}, finding = findingWithoutIssue) => { const createWrapper = (vulnerability = {}, finding = findingWithoutIssue) => {
wrapper = shallowMount(App, { wrapper = shallowMount(Header, {
propsData: { propsData: {
...dataset, ...dataset,
initialVulnerability: { ...defaultVulnerability, ...vulnerability }, initialVulnerability: { ...defaultVulnerability, ...vulnerability },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment