Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a9bee91d
Commit
a9bee91d
authored
Aug 21, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
2aee9c88
77ffe60c
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
24 additions
and
0 deletions
+24
-0
app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_rebase.vue
...rge_request_widget/components/states/mr_widget_rebase.vue
+1
-0
changelogs/unreleased/32032-html-code-shown-in-merge-request.yml
...ogs/unreleased/32032-html-code-shown-in-merge-request.yml
+5
-0
spec/javascripts/vue_mr_widget/components/mr_widget_rebase_spec.js
...scripts/vue_mr_widget/components/mr_widget_rebase_spec.js
+18
-0
No files found.
app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_rebase.vue
View file @
a9bee91d
...
...
@@ -50,6 +50,7 @@ export default {
startTag
:
'
<span class="label-branch">
'
,
endTag
:
'
</span>
'
,
},
false
,
);
},
},
...
...
changelogs/unreleased/32032-html-code-shown-in-merge-request.yml
0 → 100644
View file @
a9bee91d
---
title
:
Fix HTML rendering for fast-forward rebases in merge request widget
merge_request
:
32032
author
:
type
:
fixed
spec/javascripts/vue_mr_widget/components/mr_widget_rebase_spec.js
View file @
a9bee91d
...
...
@@ -83,6 +83,24 @@ describe('Merge request widget rebase component', () => {
expect
(
text
).
toContain
(
'
foo
'
);
expect
(
text
.
replace
(
/
\s\s
+/g
,
'
'
)).
toContain
(
'
to allow this merge request to be merged.
'
);
});
it
(
'
should render the correct target branch name
'
,
()
=>
{
const
targetBranch
=
'
fake-branch-to-test-with
'
;
vm
=
mountComponent
(
Component
,
{
mr
:
{
rebaseInProgress
:
false
,
canPushToSourceBranch
:
false
,
targetBranch
,
},
service
:
{},
});
const
elem
=
vm
.
$el
.
querySelector
(
'
.rebase-state-find-class-convention span
'
);
expect
(
elem
.
innerHTML
).
toContain
(
`Fast-forward merge is not possible. Rebase the source branch onto <span class="label-branch">
${
targetBranch
}
</span> to allow this merge request to be merged.`
,
);
});
});
describe
(
'
methods
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment