Improve specs for group/project notification controller

parent ef22b76b
...@@ -2,16 +2,31 @@ require 'spec_helper' ...@@ -2,16 +2,31 @@ require 'spec_helper'
describe Groups::NotificationSettingsController do describe Groups::NotificationSettingsController do
let(:group) { create(:group) } let(:group) { create(:group) }
let(:user) { create(:user) }
describe '#update' do describe '#update' do
context 'when not authorized' do context 'when not authorized' do
it 'redirects to sign in page' do it 'redirects to sign in page' do
put :update, put :update,
group_id: group.to_param, group_id: group.to_param,
notification_setting: { level: NotificationSetting.levels[:participating] } notification_setting: { level: :participating }
expect(response).to redirect_to(new_user_session_path) expect(response).to redirect_to(new_user_session_path)
end end
end end
context 'when authorized' do
before do
sign_in(user)
end
it 'returns success' do
put :update,
group_id: group.to_param,
notification_setting: { level: :participating }
expect(response.status).to eq 200
end
end
end end
end end
...@@ -2,6 +2,11 @@ require 'spec_helper' ...@@ -2,6 +2,11 @@ require 'spec_helper'
describe Projects::NotificationSettingsController do describe Projects::NotificationSettingsController do
let(:project) { create(:empty_project) } let(:project) { create(:empty_project) }
let(:user) { create(:user) }
before do
project.team << [user, :developer]
end
describe '#create' do describe '#create' do
context 'when not authorized' do context 'when not authorized' do
...@@ -9,11 +14,26 @@ describe Projects::NotificationSettingsController do ...@@ -9,11 +14,26 @@ describe Projects::NotificationSettingsController do
post :create, post :create,
namespace_id: project.namespace.to_param, namespace_id: project.namespace.to_param,
project_id: project.to_param, project_id: project.to_param,
notification_setting: { level: NotificationSetting.levels[:participating] } notification_setting: { level: :participating }
expect(response).to redirect_to(new_user_session_path) expect(response).to redirect_to(new_user_session_path)
end end
end end
context 'when authorized' do
before do
sign_in(user)
end
it 'returns success' do
post :create,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
notification_setting: { level: :participating }
expect(response.status).to eq 200
end
end
end end
describe '#update' do describe '#update' do
...@@ -22,10 +42,25 @@ describe Projects::NotificationSettingsController do ...@@ -22,10 +42,25 @@ describe Projects::NotificationSettingsController do
put :update, put :update,
namespace_id: project.namespace.to_param, namespace_id: project.namespace.to_param,
project_id: project.to_param, project_id: project.to_param,
notification_setting: { level: NotificationSetting.levels[:participating] } notification_setting: { level: :participating }
expect(response).to redirect_to(new_user_session_path) expect(response).to redirect_to(new_user_session_path)
end end
end end
context 'when authorized' do
before do
sign_in(user)
end
it 'returns success' do
put :update,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
notification_setting: { level: :participating }
expect(response.status).to eq 200
end
end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment