Merge branch '233401-link-from-library-to-edit-form' into 'master'

Enable "edit" links in DAST profiles library

See merge request gitlab-org/gitlab!39137

ee/app/assets/javascripts/dast_profiles/components/dast_profiles_list.vue

@@ -161,20 +161,7 @@ export default {
               :aria-label="__('Delete')"
               @click="prepareProfileDeletion(item.id)"
             />
-            <!--
-            NOTE: The tooltip and `disable` on the button is temporary until the edit feature has been implemented
-            further details: https://gitlab.com/gitlab-org/gitlab/-/issues/222479#proposal
-           -->
-            <span
-              v-gl-tooltip.hover
-              :title="
-                s__(
-                  'DastProfiles|Edit feature will come soon. Please create a new profile if changes needed',
-                )
-              "
-            >
-              <gl-button disabled>{{ __('Edit') }}</gl-button>
-            </span>
+            <gl-button :href="item.editPath">{{ __('Edit') }}</gl-button>
           </div>
         </template>
 

ee/app/assets/javascripts/dast_profiles/graphql/dast_site_profiles.query.graphql

@@ -12,6 +12,7 @@ query DastSiteProfiles($fullPath: ID!, $after: String, $before: String, $first:
           id
           profileName
           targetUrl
+          editPath
           validationStatus
         }
       }

ee/spec/frontend/dast_profiles/components/dast_profiles_list_spec.js

@@ -106,12 +106,14 @@ describe('EE - DastProfilesList', () => {
         id: 1,
         profileName: 'Profile 1',
         targetUrl: 'http://example-1.com',
+        editPath: '/1/edit',
         validationStatus: 'Pending',
       },
       {
         id: 2,
         profileName: 'Profile 2',
         targetUrl: 'http://example-2.com',
+        editPath: '/2/edit',
         validationStatus: 'Pending',
       },
     ];
@@ -143,8 +145,11 @@ describe('EE - DastProfilesList', () => {
         expect(profileCell.innerText).toContain(profile.profileName);
         expect(targetUrlCell.innerText).toContain(profile.targetUrl);
         expect(validationStatusCell.innerText).toContain(profile.validationStatus);
-        expect(within(actionsCell).getByRole('button', { name: /edit/i })).not.toBe(null);
         expect(within(actionsCell).getByRole('button', { name: /delete/i })).not.toBe(null);
+
+        const editLink = within(actionsCell).getByRole('link', { name: /edit/i });
+        expect(editLink).not.toBe(null);
+        expect(editLink.getAttribute('href')).toBe(profile.editPath);
       });
     });
 

locale/gitlab.pot

@@ -7611,9 +7611,6 @@ msgstr ""
 msgid "DastProfiles|Do you want to discard your changes?"
 msgstr ""
 
-msgid "DastProfiles|Edit feature will come soon. Please create a new profile if changes needed"
-msgstr ""
-
 msgid "DastProfiles|Edit site profile"
 msgstr ""