Merge branch 'cat-enable-pages-replication-default' into 'master'

Enable Pages replication with Geo by default

See merge request gitlab-org/gitlab!70434

doc/administration/geo/replication/datatypes.md

@@ -55,6 +55,8 @@ verification methods:
 | Blobs    | External Merge Request Diffs _(object storage)_ | Geo with API/Managed (*2*)            | _Not implemented_      |
 | Blobs    | Pipeline artifacts _(file system)_              | Geo with API                          | SHA256 checksum        |
 | Blobs    | Pipeline artifacts _(object storage)_           | Geo with API/Managed (*2*)            | SHA256 checksum        |
+| Blobs    | Pages _(file system)_                           | Geo with API                          | _Not implemented_      |
+| Blobs    | Pages _(object storage)_                        | Geo with API/Managed (*2*)            | _Not implemented_      |
 
 - (*1*): Redis replication can be used as part of HA with Redis sentinel. It's not used between Geo sites.
 - (*2*): Object storage replication can be performed by Geo or by your object storage provider/appliance
@@ -199,7 +201,7 @@ successfully, you must replicate their data using some other means.
 |[Versioned snippets](../../../user/snippets.md#versioned-snippets)                                             | [**Yes** (13.7)](https://gitlab.com/groups/gitlab-org/-/epics/2809)     | [**Yes** (14.2)](https://gitlab.com/groups/gitlab-org/-/epics/2810)            | No                                                                            | Verification was implemented behind the feature flag `geo_snippet_repository_verification` in 13.11, and the feature flag was removed in 14.2. |
 |[Server-side Git hooks](../../server_hooks.md)                                                                 | [No](https://gitlab.com/groups/gitlab-org/-/epics/1867)                 | No                                                                      | No                                                                            |       |
 |[Elasticsearch integration](../../../integration/elasticsearch.md)                                             | [No](https://gitlab.com/gitlab-org/gitlab/-/issues/1186)                | No                                                                      | No                                                                            |       |
-|[GitLab Pages](../../pages/index.md)                                                                           | [No](https://gitlab.com/groups/gitlab-org/-/epics/589)                  | No                                                                      | Via Object Storage provider if supported. **No** native Geo support (Beta).                                                                            |       |
+|[GitLab Pages](../../pages/index.md)                                                                           | [**Yes** (14.3)](https://gitlab.com/groups/gitlab-org/-/epics/589)      | No                                                                      | Via Object Storage provider if supported. Native Geo support (Beta).                                                                           | Behind feature flag `geo_pages_deployment_replication`, enabled by default. |
 |[Dependency proxy images](../../../user/packages/dependency_proxy/index.md)                                    | [No](https://gitlab.com/gitlab-org/gitlab/-/issues/259694)              | No                                                                      | No                                                                            | Blocked on [Geo: Secondary Mimicry](https://gitlab.com/groups/gitlab-org/-/epics/1528). Replication of this cache is not needed for Disaster Recovery purposes because it can be recreated from external sources. |
 |[Vulnerability Export](../../../user/application_security/vulnerability_report/#export-vulnerability-details)  | [Not planned](https://gitlab.com/groups/gitlab-org/-/epics/3111)        | No                                                                      |  | Not planned because they are ephemeral and sensitive. They can be regenerated on demand. |
 

doc/api/graphql/reference/index.md

@@ -9851,7 +9851,7 @@ four standard [pagination arguments](#connection-pagination-arguments):
 
 ##### `GeoNode.pagesDeploymentRegistries`
 
-Find Pages Deployment registries on this Geo node Available only when feature flag `geo_pages_deployment_replication` is enabled. This flag is disabled by default, because the feature is experimental and is subject to change without notice.
+Find Pages Deployment registries on this Geo node.
 
 Returns [`PagesDeploymentRegistryConnection`](#pagesdeploymentregistryconnection).
 

ee/app/graphql/types/geo/geo_node_type.rb

@@ -53,8 +53,7 @@ module Types
       field :pages_deployment_registries, ::Types::Geo::PagesDeploymentRegistryType.connection_type,
             null: true,
             resolver: ::Resolvers::Geo::PagesDeploymentRegistriesResolver,
-            description: 'Find Pages Deployment registries on this Geo node',
-            feature_flag: :geo_pages_deployment_replication
+            description: 'Find Pages Deployment registries on this Geo node'
     end
   end
 end

ee/app/replicators/geo/pages_deployment_replicator.rb

@@ -13,12 +13,6 @@ module Geo
       model_record.file
     end
 
-    # The feature flag follows the format `geo_#{replicable_name}_replication`,
-    # so here it would be `geo_pages_deployment_replication`
-    def self.replication_enabled_by_default?
-      false
-    end
-
     override :verification_feature_flag_enabled?
     def self.verification_feature_flag_enabled?
       false

ee/config/feature_flags/development/geo_pages_deployment_replication.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/337676
 milestone: '14.3'
 type: development
 group: group::geo
-default_enabled: false
+default_enabled: true