Commit ac158424 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Merge branch 'improve-merge-widget' into 'master'

Improve merge widget

* remove title `You can merge it` since button below says same
* fixed layout for custom commit message
* make button a bit bigger

See merge request !1365
parents c9572857 88435229
...@@ -11,10 +11,27 @@ ...@@ -11,10 +11,27 @@
} }
} }
.accept-group { .accept-merge-holder {
label { margin-top: 5px;
margin: 5px;
.accept-action {
display: inline-block;
.accept_merge_request {
padding: 10px 20px;
}
}
.accept-control {
display: inline-block;
margin-left: 20px; margin-left: 20px;
padding: 10px 0;
line-height: 20px;
font-weight: bold;
.checkbox {
margin: 0;
}
} }
} }
} }
......
...@@ -13,25 +13,22 @@ ...@@ -13,25 +13,22 @@
.automerge_widget.can_be_merged.hide .automerge_widget.can_be_merged.hide
.clearfix .clearfix
= form_for [:automerge, @project, @merge_request], remote: true, method: :post do |f| = form_for [:automerge, @project, @merge_request], remote: true, method: :post do |f|
%h4 .accept-merge-holder.clearfix.js-toggle-container
You can accept this request automatically. .accept-action
.accept-merge-holder.clearfix = f.submit "Accept Merge Request", class: "btn btn-create accept_merge_request"
.accept-group - if can_remove_branch?(@merge_request.source_project, @merge_request.source_branch) && !@merge_request.for_fork?
.pull-left .accept-control
= f.submit "Accept Merge Request", class: "btn btn-create accept_merge_request" = label_tag :should_remove_source_branch, class: "checkbox" do
- if can_remove_branch?(@merge_request.source_project, @merge_request.source_branch) && !@merge_request.for_fork? = check_box_tag :should_remove_source_branch
.remove_branch_holder.pull-left Remove source-branch
= label_tag :should_remove_source_branch, class: "checkbox" do .accept-control
= check_box_tag :should_remove_source_branch = link_to "#", class: "modify-merge-commit-link js-toggle-button", title: "Modify merge commit message" do
Remove source-branch %i.fa.fa-edit
.js-toggle-container Modify commit message
%label .js-toggle-content.hide.prepend-top-20
%i.fa.fa-edit = render 'shared/commit_message_container', params: params,
= link_to "modify merge commit message", "#", class: "modify-merge-commit-link js-toggle-button", title: "Modify merge commit message" text: @merge_request.merge_commit_message,
.js-toggle-content.hide rows: 14, hint: true
= render 'shared/commit_message_container', params: params,
text: @merge_request.merge_commit_message,
rows: 14, hint: true
%hr %hr
.light .light
......
...@@ -156,7 +156,7 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps ...@@ -156,7 +156,7 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
end end
step 'merge request is mergeable' do step 'merge request is mergeable' do
page.should have_content 'You can accept this request automatically' page.should have_button 'Accept Merge Request'
end end
step 'I modify merge commit message' do step 'I modify merge commit message' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment