Enable delete button on package view

- components
- tests update
parent f2c46d34
...@@ -54,9 +54,6 @@ export default { ...@@ -54,9 +54,6 @@ export default {
hasProjectLink() { hasProjectLink() {
return Boolean(this.packageEntity.project_path); return Boolean(this.packageEntity.project_path);
}, },
deleteAvailable() {
return !this.disableDelete && !this.isGroup;
},
}, },
}; };
</script> </script>
...@@ -111,7 +108,7 @@ export default { ...@@ -111,7 +108,7 @@ export default {
<div <div
class="table-section d-flex flex-md-column justify-content-between align-items-md-end" class="table-section d-flex flex-md-column justify-content-between align-items-md-end"
:class="!deleteAvailable ? 'section-50' : 'section-40'" :class="disableDelete ? 'section-50' : 'section-40'"
> >
<publish-method :package-entity="packageEntity" :is-group="isGroup" /> <publish-method :package-entity="packageEntity" :is-group="isGroup" />
...@@ -126,7 +123,7 @@ export default { ...@@ -126,7 +123,7 @@ export default {
</div> </div>
</div> </div>
<div v-if="deleteAvailable" class="table-section section-10 d-flex justify-content-end"> <div v-if="!disableDelete" class="table-section section-10 d-flex justify-content-end">
<gl-button <gl-button
data-testid="action-delete" data-testid="action-delete"
icon="remove" icon="remove"
......
---
title: Enable delete button on Package group level view list
merge_request: 39430
author:
type: changed
...@@ -67,10 +67,6 @@ describe('packages_list_row', () => { ...@@ -67,10 +67,6 @@ describe('packages_list_row', () => {
it('has project field', () => { it('has project field', () => {
expect(findProjectLink().exists()).toBe(true); expect(findProjectLink().exists()).toBe(true);
}); });
it('does not show the delete button', () => {
expect(findDeleteButton().exists()).toBe(false);
});
}); });
describe('showPackageType', () => { describe('showPackageType', () => {
...@@ -96,9 +92,7 @@ describe('packages_list_row', () => { ...@@ -96,9 +92,7 @@ describe('packages_list_row', () => {
}); });
describe('delete event', () => { describe('delete event', () => {
beforeEach(() => beforeEach(() => mountComponent({ packageEntity: packageWithoutTags, shallow: false }));
mountComponent({ isGroup: false, packageEntity: packageWithoutTags, shallow: false }),
);
it('emits the packageToDelete event when the delete button is clicked', () => { it('emits the packageToDelete event when the delete button is clicked', () => {
findDeleteButton().trigger('click'); findDeleteButton().trigger('click');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment