Merge branch 'drop-larger-unlocked-artifact-index' into 'master'

Drop trace-inclusive artifact removal index from ci_job_artifacts

See merge request gitlab-org/gitlab!84308

db/post_migrate/20220404184814_drop_broader_expired_artifact_index.rb

+# frozen_string_literal: true
+
+class DropBroaderExpiredArtifactIndex < Gitlab::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  TABLE_NAME = 'ci_job_artifacts'
+  INDEX_NAME = 'ci_job_artifacts_expire_at_unlocked_idx'
+
+  def up
+    remove_concurrent_index_by_name TABLE_NAME, INDEX_NAME
+  end
+
+  def down
+    add_concurrent_index TABLE_NAME, [:expire_at], where: 'locked = 0', name: INDEX_NAME
+  end
+end

db/schema_migrations/20220404184814

+f8013613d3ef44ea94db805d1900e7796204eefe373d42151cfe8acd4948a608
\ No newline at end of file

db/structure.sql

@@ -26445,8 +26445,6 @@ CREATE INDEX cadence_create_iterations_automation ON iterations_cadences USING b
 
 CREATE INDEX ci_builds_gitlab_monitor_metrics ON ci_builds USING btree (status, created_at, project_id) WHERE ((type)::text = 'Ci::Build'::text);
 
-CREATE INDEX ci_job_artifacts_expire_at_unlocked_idx ON ci_job_artifacts USING btree (expire_at) WHERE (locked = 0);
-
 CREATE INDEX code_owner_approval_required ON protected_branches USING btree (project_id, code_owner_approval_required) WHERE (code_owner_approval_required = true);
 
 CREATE UNIQUE INDEX commit_user_mentions_on_commit_id_and_note_id_unique_index ON commit_user_mentions USING btree (commit_id, note_id);