Merge branch '280840-add-a-cop-that-enforces-no-capitalization-on-expectations' into 'master'

Add a cop that enforces no capitalization on expectations

See merge request gitlab-org/gitlab!49513

Gemfile

@@ -372,7 +372,7 @@ group :development, :test do
   gem 'spring', '~> 2.1.0'
   gem 'spring-commands-rspec', '~> 1.0.4'
 
-  gem 'gitlab-styles', '~> 5.1.0', require: false
+  gem 'gitlab-styles', '~> 5.2.0', require: false
 
   gem 'scss_lint', '~> 0.59.0', require: false
   gem 'haml_lint', '~> 0.36.0', require: false

Gemfile.lock

@@ -454,7 +454,7 @@ GEM
       gitlab-puma (>= 2.7, < 5)
     gitlab-sidekiq-fetcher (0.5.2)
       sidekiq (~> 5)
-    gitlab-styles (5.1.0)
+    gitlab-styles (5.2.0)
       rubocop (~> 0.89.1)
       rubocop-gitlab-security (~> 0.1.0)
       rubocop-performance (~> 1.8.1)
@@ -1363,7 +1363,7 @@ DEPENDENCIES
   gitlab-puma (~> 4.3.3.gitlab.2)
   gitlab-puma_worker_killer (~> 0.1.1.gitlab.1)
   gitlab-sidekiq-fetcher (= 0.5.2)
-  gitlab-styles (~> 5.1.0)
+  gitlab-styles (~> 5.2.0)
   gitlab_chronic_duration (~> 0.10.6.2)
   gitlab_omniauth-ldap (~> 2.1.1)
   gon (~> 6.2)

ee/spec/features/admin/admin_settings_spec.rb

@@ -41,7 +41,7 @@ RSpec.describe 'Admin updates EE-only settings' do
     end
   end
 
-  it 'Enables external authentication' do
+  it 'enables external authentication' do
     visit general_admin_application_settings_path
     page.within('.as-external-auth') do
       check 'Enable classification control using an external service'
@@ -89,7 +89,7 @@ RSpec.describe 'Admin updates EE-only settings' do
       end
     end
 
-    it 'Allows limiting projects and namespaces to index', :aggregate_failures, :js do
+    it 'allows limiting projects and namespaces to index', :aggregate_failures, :js do
       project = create(:project)
       namespace = create(:namespace)
 
@@ -132,7 +132,7 @@ RSpec.describe 'Admin updates EE-only settings' do
       expect(ElasticsearchIndexedProject.exists?(project_id: project.id)).to be_truthy
     end
 
-    it 'Allows removing all namespaces and projects', :aggregate_failures, :js do
+    it 'allows removing all namespaces and projects', :aggregate_failures, :js do
       stub_ee_application_setting(elasticsearch_limit_indexing: true)
 
       namespace = create(:elasticsearch_indexed_namespace).namespace
@@ -177,7 +177,7 @@ RSpec.describe 'Admin updates EE-only settings' do
     end
   end
 
-  it 'Enable Slack application' do
+  it 'enable Slack application' do
     allow(Gitlab).to receive(:com?).and_return(true)
     visit general_admin_application_settings_path
 
@@ -194,13 +194,13 @@ RSpec.describe 'Admin updates EE-only settings' do
       visit templates_admin_application_settings_path
     end
 
-    it 'Render "Templates" section' do
+    it 'render "Templates" section' do
       page.within('.as-visibility-access') do
         expect(page).to have_content 'Templates'
       end
     end
 
-    it 'Render "Custom project templates" section' do
+    it 'render "Custom project templates" section' do
       page.within('.as-custom-project-templates') do
         expect(page).to have_content 'Custom project templates'
       end
@@ -217,7 +217,7 @@ RSpec.describe 'Admin updates EE-only settings' do
     context 'with LDAP enabled' do
       let(:ldap_setting) { true }
 
-      it 'Changes to allow group owners to manage ldap' do
+      it 'changes to allow group owners to manage ldap' do
         page.within('.as-visibility-access') do
           find('#application_setting_allow_group_owners_to_manage_ldap').set(false)
           click_button 'Save'
@@ -231,7 +231,7 @@ RSpec.describe 'Admin updates EE-only settings' do
     context 'with LDAP disabled' do
       let(:ldap_setting) { false }
 
-      it 'Does not show option to allow group owners to manage ldap' do
+      it 'does not show option to allow group owners to manage ldap' do
         expect(page).not_to have_css('#application_setting_allow_group_owners_to_manage_ldap')
       end
     end

ee/spec/features/groups/saml_providers_spec.rb

@@ -244,7 +244,7 @@ RSpec.describe 'SAML provider settings' do
             mock_group_saml(uid: identity.extern_uid)
           end
 
-          it 'Sign in button redirects to auth flow' do
+          it 'sign in button redirects to auth flow' do
             visit sso_group_saml_providers_path(group)
 
             click_link 'Sign in with Single Sign-On'

ee/spec/features/projects/path_locks_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe 'Path Locks', :js do
     wait_for_requests
   end
 
-  it 'Locking folders' do
+  it 'locking folders' do
     within '.tree-content-holder' do
       click_link "encoding"
     end
@@ -28,7 +28,7 @@ RSpec.describe 'Path Locks', :js do
     expect(page).to have_link('Unlock')
   end
 
-  it 'Locking files' do
+  it 'locking files' do
     page_tree = find('.tree-content-holder')
 
     within page_tree do
@@ -42,7 +42,7 @@ RSpec.describe 'Path Locks', :js do
     end
   end
 
-  it 'Unlocking files' do
+  it 'unlocking files' do
     within find('.tree-content-holder') do
       click_link "VERSION"
     end
@@ -60,7 +60,7 @@ RSpec.describe 'Path Locks', :js do
     end
   end
 
-  it 'Managing of lock list' do
+  it 'managing of lock list' do
     create :path_lock, path: 'encoding', user: user, project: project
 
     click_link "Locked Files"

ee/spec/features/search/elastic/global_search_spec.rb

@@ -132,7 +132,7 @@ RSpec.describe 'Global elastic search', :elastic, :sidekiq_inline do
       expect(page).to have_selector("span.line[lang='javascript']")
     end
 
-    it 'Ignores nonexistent projects from stale index' do
+    it 'ignores nonexistent projects from stale index' do
       stub_ee_application_setting(elasticsearch_search: true, elasticsearch_indexing: true)
 
       project_2.repository.create_file(

ee/spec/features/survey_responses_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe 'Responses' do
-  it 'Shows a friendly message' do
+  it 'shows a friendly message' do
     visit survey_responses_path
 
     expect(page).to have_text _('Thank you for your feedback!')

ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb

@@ -114,7 +114,7 @@ RSpec.describe Projects::Integrations::Jira::IssuesFinder do
         context 'when pagination params used' do
           let(:params) { { page: '10', per_page: '20' } }
 
-          it 'passes them to JqlBuilderService ' do
+          it 'passes them to JqlBuilderService' do
             expect(::Jira::JqlBuilderService).to receive(:new)
               .with(jira_service.project_key, include({ page: '10', per_page: '20' }))
               .and_call_original

ee/spec/support/shared_examples/services/geo_event_store_shared_examples.rb

@@ -6,7 +6,7 @@ RSpec.shared_examples 'a Geo event store' do |event_class|
       stub_secondary_node
     end
 
-    it 'does not create an event ' do
+    it 'does not create an event' do
       expect { subject.create! }.not_to change(event_class, :count)
     end
   end

ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb

@@ -64,7 +64,7 @@ RSpec.describe 'layouts/nav/sidebar/_project' do
       let(:can_read_environment) { true }
       let(:can_read_pod_logs) { true }
 
-      it 'link is visible ' do
+      it 'link is visible' do
         expect(rendered).to have_link('Logs', href: project_logs_path(project))
       end
     end
@@ -73,7 +73,7 @@ RSpec.describe 'layouts/nav/sidebar/_project' do
       let(:can_read_environment) { false }
       let(:can_read_pod_logs) { false }
 
-      it 'link is not visible ' do
+      it 'link is not visible' do
         expect(rendered).not_to have_link 'Logs'
       end
     end
@@ -82,7 +82,7 @@ RSpec.describe 'layouts/nav/sidebar/_project' do
       let(:can_read_environment) { true }
       let(:can_read_pod_logs) { false }
 
-      it 'link is not visible ' do
+      it 'link is not visible' do
         expect(rendered).not_to have_link 'Logs'
       end
     end

ee/spec/workers/adjourned_projects_deletion_cron_worker_spec.rb

@@ -35,7 +35,7 @@ RSpec.describe AdjournedProjectsDeletionCronWorker do
     context 'marked for deletion exectly before number of days from settings' do
       let(:marked_for_deletion_at) { 7.days.ago }
 
-      it 'schedules to delete project ' do
+      it 'schedules to delete project' do
         expect(AdjournedProjectDeletionWorker).to receive(:perform_in).with(0, project_marked_for_deletion.id)
 
         worker.perform

qa/qa/specs/features/browser_ui/1_manage/login/login_via_instance_wide_saml_sso_spec.rb

@@ -3,7 +3,7 @@
 module QA
   RSpec.describe 'Manage', :orchestrated, :instance_saml do
     describe 'Instance wide SAML SSO' do
-      it 'User logs in to gitlab with SAML SSO', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/671' do
+      it 'user logs in to gitlab with SAML SSO', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/671' do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
 
         Page::Main::Login.perform(&:sign_in_with_saml)

qa/qa/specs/features/browser_ui/3_create/snippet/create_personal_snippet_spec.rb

@@ -3,7 +3,7 @@
 module QA
   RSpec.describe 'Create', :smoke do
     describe 'Personal snippet creation' do
-      it 'User creates a personal snippet', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/840' do
+      it 'user creates a personal snippet', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/840' do
         Flow::Login.sign_in
 
         Page::Main::Menu.perform do |menu|

qa/qa/specs/features/browser_ui/3_create/snippet/create_project_snippet_spec.rb

@@ -3,7 +3,7 @@
 module QA
   RSpec.describe 'Create' do # to be converted to a smoke test once proved to be stable
     describe 'Project snippet creation' do
-      it 'User creates a project snippet', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/839' do
+      it 'user creates a project snippet', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/839' do
         Flow::Login.sign_in
 
         Resource::ProjectSnippet.fabricate_via_browser_ui! do |snippet|

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb

@@ -47,7 +47,7 @@ module QA
         end
       end
 
-      it 'User logs in to group with SAML SSO', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/673' do
+      it 'user logs in to group with SAML SSO', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/673' do
         managed_group_url = Flow::Saml.enable_saml_sso(@group, @saml_idp_service)
 
         Flow::Login.while_signed_in(as: user) do
@@ -67,7 +67,7 @@ module QA
         end
       end
 
-      it 'Lets group admin test settings', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/674' do
+      it 'lets group admin test settings', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/674' do
         incorrect_fingerprint = Digest::SHA1.hexdigest(rand.to_s)
 
         Flow::Saml.visit_saml_sso_settings(@group)

spec/controllers/projects/notes_controller_spec.rb

@@ -426,7 +426,7 @@ RSpec.describe Projects::NotesController do
           let(:note_text) { "/award :thumbsup:\n/estimate 1d\n/spend 3h" }
           let(:extra_request_params) { { format: :json } }
 
-          it 'includes changes in commands_changes ' do
+          it 'includes changes in commands_changes' do
             create!
 
             expect(response).to have_gitlab_http_status(:ok)

spec/db/production/settings_spec.rb

@@ -31,7 +31,7 @@ RSpec.describe 'seed production settings' do
         stub_env('GITLAB_PROMETHEUS_METRICS_ENABLED', 'true')
       end
 
-      it 'prometheus_metrics_enabled is set to true ' do
+      it 'prometheus_metrics_enabled is set to true' do
         load(settings_file)
 
         expect(settings.prometheus_metrics_enabled).to eq(true)

spec/features/abuse_report_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe 'Abuse reports' do
     sign_in(create(:user))
   end
 
-  it 'Report abuse' do
+  it 'report abuse' do
     visit user_path(another_user)
 
     click_link 'Report abuse'

spec/features/admin/admin_appearance_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe 'Admin Appearance' do
   let!(:appearance) { create(:appearance) }
   let(:admin) { create(:admin) }
 
-  it 'Create new appearance' do
+  it 'create new appearance' do
     sign_in(admin)
     gitlab_enable_admin_mode_sign_in(admin)
     visit admin_appearances_path
@@ -27,7 +27,7 @@ RSpec.describe 'Admin Appearance' do
     expect(page).to have_content 'Last edit'
   end
 
-  it 'Preview sign-in page appearance' do
+  it 'preview sign-in page appearance' do
     sign_in(admin)
     gitlab_enable_admin_mode_sign_in(admin)
 
@@ -37,7 +37,7 @@ RSpec.describe 'Admin Appearance' do
     expect_custom_sign_in_appearance(appearance)
   end
 
-  it 'Preview new project page appearance' do
+  it 'preview new project page appearance' do
     sign_in(admin)
     gitlab_enable_admin_mode_sign_in(admin)
 
@@ -80,13 +80,13 @@ RSpec.describe 'Admin Appearance' do
     end
   end
 
-  it 'Custom sign-in page' do
+  it 'custom sign-in page' do
     visit new_user_session_path
 
     expect_custom_sign_in_appearance(appearance)
   end
 
-  it 'Custom new project page' do
+  it 'custom new project page' do
     sign_in(admin)
     gitlab_enable_admin_mode_sign_in(admin)
     visit new_project_path
@@ -111,7 +111,7 @@ RSpec.describe 'Admin Appearance' do
     end
   end
 
-  it 'Appearance logo' do
+  it 'appearance logo' do
     sign_in(admin)
     gitlab_enable_admin_mode_sign_in(admin)
     visit admin_appearances_path
@@ -124,7 +124,7 @@ RSpec.describe 'Admin Appearance' do
     expect(page).not_to have_css(logo_selector)
   end
 
-  it 'Header logos' do
+  it 'header logos' do
     sign_in(admin)
     gitlab_enable_admin_mode_sign_in(admin)
     visit admin_appearances_path

spec/features/admin/admin_broadcast_messages_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe 'Admin Broadcast Messages' do
     visit admin_broadcast_messages_path
   end
 
-  it 'See broadcast messages list' do
+  it 'see broadcast messages list' do
     expect(page).to have_content 'Migration to new server'
   end
 
@@ -44,7 +44,7 @@ RSpec.describe 'Admin Broadcast Messages' do
     expect(page).to have_selector 'strong', text: '4:00 CST to 5:00 CST'
   end
 
-  it 'Edit an existing broadcast message' do
+  it 'edit an existing broadcast message' do
     click_link 'Edit'
     fill_in 'broadcast_message_message', with: 'Application update RIGHT NOW'
     click_button 'Update broadcast message'
@@ -53,7 +53,7 @@ RSpec.describe 'Admin Broadcast Messages' do
     expect(page).to have_content 'Application update RIGHT NOW'
   end
 
-  it 'Remove an existing broadcast message' do
+  it 'remove an existing broadcast message' do
     click_link 'Remove'
 
     expect(current_path).to eq admin_broadcast_messages_path

spec/features/admin/admin_browse_spam_logs_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe 'Admin browse spam logs' do
     gitlab_enable_admin_mode_sign_in(admin)
   end
 
-  it 'Browse spam logs' do
+  it 'browse spam logs' do
     visit admin_spam_logs_path
 
     expect(page).to have_content('Spam Logs')

spec/features/admin/admin_serverless_domains_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe 'Admin Serverless Domains', :js do
     gitlab_enable_admin_mode_sign_in(admin)
   end
 
-  it 'Add domain with certificate' do
+  it 'add domain with certificate' do
     visit admin_serverless_domains_path
 
     fill_in 'pages_domain[domain]', with: 'foo.com'
@@ -32,7 +32,7 @@ RSpec.describe 'Admin Serverless Domains', :js do
     expect(page).to have_content '/CN=test-certificate'
   end
 
-  it 'Update domain certificate' do
+  it 'update domain certificate' do
     visit admin_serverless_domains_path
 
     fill_in 'pages_domain[domain]', with: 'foo.com'
@@ -62,7 +62,7 @@ RSpec.describe 'Admin Serverless Domains', :js do
   context 'when domain exists' do
     let!(:domain) { create(:pages_domain, :instance_serverless) }
 
-    it 'Displays a modal when attempting to delete a domain' do
+    it 'displays a modal when attempting to delete a domain' do
       visit admin_serverless_domains_path
 
       click_button 'Delete domain'
@@ -73,7 +73,7 @@ RSpec.describe 'Admin Serverless Domains', :js do
       end
     end
 
-    it 'Displays a modal with disabled button if unable to delete a domain' do
+    it 'displays a modal with disabled button if unable to delete a domain' do
       create(:serverless_domain_cluster, pages_domain: domain)
 
       visit admin_serverless_domains_path

spec/features/admin/admin_settings_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe 'Admin updates settings' do
         visit general_admin_application_settings_path
       end
 
-      it 'Change visibility settings' do
+      it 'change visibility settings' do
         page.within('.as-visibility-access') do
           choose "application_setting_default_project_visibility_20"
           click_button 'Save changes'
@@ -33,7 +33,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content "Application settings saved successfully"
       end
 
-      it 'Uncheck all restricted visibility levels' do
+      it 'uncheck all restricted visibility levels' do
         page.within('.as-visibility-access') do
           find('#application_setting_visibility_level_0').set(false)
           find('#application_setting_visibility_level_10').set(false)
@@ -47,7 +47,7 @@ RSpec.describe 'Admin updates settings' do
         expect(find('#application_setting_visibility_level_20')).not_to be_checked
       end
 
-      it 'Modify import sources' do
+      it 'modify import sources' do
         expect(current_settings.import_sources).not_to be_empty
 
         page.within('.as-visibility-access') do
@@ -70,7 +70,7 @@ RSpec.describe 'Admin updates settings' do
         expect(current_settings.import_sources).to eq(['git'])
       end
 
-      it 'Change Visibility and Access Controls' do
+      it 'change Visibility and Access Controls' do
         page.within('.as-visibility-access') do
           uncheck 'Project export enabled'
           click_button 'Save changes'
@@ -80,7 +80,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content "Application settings saved successfully"
       end
 
-      it 'Change Keys settings' do
+      it 'change Keys settings' do
         page.within('.as-visibility-access') do
           select 'Are forbidden', from: 'RSA SSH keys'
           select 'Are allowed', from: 'DSA SSH keys'
@@ -98,7 +98,7 @@ RSpec.describe 'Admin updates settings' do
         expect(find_field('ED25519 SSH keys').value).to eq(forbidden)
       end
 
-      it 'Change Account and Limit Settings' do
+      it 'change Account and Limit Settings' do
         page.within('.as-account-limit') do
           uncheck 'Gravatar enabled'
           click_button 'Save changes'
@@ -108,7 +108,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content "Application settings saved successfully"
       end
 
-      it 'Change Maximum import size' do
+      it 'change Maximum import size' do
         page.within('.as-account-limit') do
           fill_in 'Maximum import size (MB)', with: 15
           click_button 'Save changes'
@@ -118,7 +118,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content "Application settings saved successfully"
       end
 
-      it 'Change New users set to external', :js do
+      it 'change New users set to external', :js do
         user_internal_regex = find('#application_setting_user_default_internal_regex', visible: :all)
 
         expect(user_internal_regex).to be_readonly
@@ -144,7 +144,7 @@ RSpec.describe 'Admin updates settings' do
         end
       end
 
-      it 'Change Sign-in restrictions' do
+      it 'change Sign-in restrictions' do
         page.within('.as-signin') do
           fill_in 'Home page URL', with: 'https://about.gitlab.com/'
           click_button 'Save changes'
@@ -154,7 +154,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content "Application settings saved successfully"
       end
 
-      it 'Terms of Service' do
+      it 'terms of Service' do
         # Already have the admin accept terms, so they don't need to accept in this spec.
         _existing_terms = create(:term)
         accept_terms(admin)
@@ -170,7 +170,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content 'Application settings saved successfully'
       end
 
-      it 'Modify oauth providers' do
+      it 'modify oauth providers' do
         expect(current_settings.disabled_oauth_sign_in_sources).to be_empty
 
         page.within('.as-signin') do
@@ -190,7 +190,7 @@ RSpec.describe 'Admin updates settings' do
         expect(current_settings.disabled_oauth_sign_in_sources).not_to include('google_oauth2')
       end
 
-      it 'Oauth providers do not raise validation errors when saving unrelated changes' do
+      it 'oauth providers do not raise validation errors when saving unrelated changes' do
         expect(current_settings.disabled_oauth_sign_in_sources).to be_empty
 
         page.within('.as-signin') do
@@ -213,7 +213,7 @@ RSpec.describe 'Admin updates settings' do
         expect(current_settings.disabled_oauth_sign_in_sources).to include('google_oauth2')
       end
 
-      it 'Configure web terminal' do
+      it 'configure web terminal' do
         page.within('.as-terminal') do
           fill_in 'Max session time', with: 15
           click_button 'Save changes'
@@ -255,7 +255,7 @@ RSpec.describe 'Admin updates settings' do
         visit general_admin_application_settings_path
       end
 
-      it 'Enable hiding third party offers' do
+      it 'enable hiding third party offers' do
         page.within('.as-third-party-offers') do
           check 'Do not display offers from third parties within GitLab'
           click_button 'Save changes'
@@ -265,7 +265,7 @@ RSpec.describe 'Admin updates settings' do
         expect(current_settings.hide_third_party_offers).to be true
       end
 
-      it 'Change Slack Notifications Service template settings', :js do
+      it 'change Slack Notifications Service template settings', :js do
         first(:link, 'Service Templates').click
         click_link 'Slack notifications'
         fill_in 'Webhook', with: 'http://localhost'
@@ -315,7 +315,7 @@ RSpec.describe 'Admin updates settings' do
     end
 
     context 'CI/CD page' do
-      it 'Change CI/CD settings' do
+      it 'change CI/CD settings' do
         visit ci_cd_admin_application_settings_path
 
         page.within('.as-ci-cd') do
@@ -380,7 +380,7 @@ RSpec.describe 'Admin updates settings' do
     end
 
     context 'Repository page' do
-      it 'Change Repository storage settings' do
+      it 'change Repository storage settings' do
         visit repository_admin_application_settings_path
 
         page.within('.as-repository-storage') do
@@ -393,7 +393,7 @@ RSpec.describe 'Admin updates settings' do
     end
 
     context 'Reporting page' do
-      it 'Change Spam settings' do
+      it 'change Spam settings' do
         visit reporting_admin_application_settings_path
 
         page.within('.as-spam') do
@@ -421,7 +421,7 @@ RSpec.describe 'Admin updates settings' do
         visit metrics_and_profiling_admin_application_settings_path
       end
 
-      it 'Change Prometheus settings' do
+      it 'change Prometheus settings' do
         page.within('.as-prometheus') do
           check 'Enable Prometheus Metrics'
           click_button 'Save changes'
@@ -431,7 +431,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content "Application settings saved successfully"
       end
 
-      it 'Change Performance bar settings' do
+      it 'change Performance bar settings' do
         group = create(:group)
 
         page.within('.as-performance-bar') do
@@ -474,7 +474,7 @@ RSpec.describe 'Admin updates settings' do
     end
 
     context 'Network page' do
-      it 'Changes Outbound requests settings' do
+      it 'changes Outbound requests settings' do
         visit network_admin_application_settings_path
 
         page.within('.as-outbound') do
@@ -492,7 +492,7 @@ RSpec.describe 'Admin updates settings' do
         expect(current_settings.dns_rebinding_protection_enabled).to be false
       end
 
-      it 'Changes Issues rate limits settings' do
+      it 'changes Issues rate limits settings' do
         visit network_admin_application_settings_path
 
         page.within('.as-issue-limits') do
@@ -510,7 +510,7 @@ RSpec.describe 'Admin updates settings' do
         visit preferences_admin_application_settings_path
       end
 
-      it 'Change Help page' do
+      it 'change Help page' do
         stub_feature_flags(help_page_documentation_redirect: true)
 
         new_support_url = 'http://example.com/help'
@@ -531,7 +531,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content "Application settings saved successfully"
       end
 
-      it 'Change Pages settings' do
+      it 'change Pages settings' do
         page.within('.as-pages') do
           fill_in 'Maximum size of pages (MB)', with: 15
           check 'Require users to prove ownership of custom domains'
@@ -543,7 +543,7 @@ RSpec.describe 'Admin updates settings' do
         expect(page).to have_content "Application settings saved successfully"
       end
 
-      it 'Change Real-time features settings' do
+      it 'change Real-time features settings' do
         page.within('.as-realtime') do
           fill_in 'Polling interval multiplier', with: 5.0
           click_button 'Save changes'
@@ -564,7 +564,7 @@ RSpec.describe 'Admin updates settings' do
           .to have_content "The form contains the following error: Polling interval multiplier must be greater than or equal to 0"
       end
 
-      it "Change Pages Let's Encrypt settings" do
+      it "change Pages Let's Encrypt settings" do
         visit preferences_admin_application_settings_path
         page.within('.as-pages') do
           fill_in 'Email', with: 'my@test.example.com'
@@ -578,7 +578,7 @@ RSpec.describe 'Admin updates settings' do
     end
 
     context 'Nav bar' do
-      it 'Shows default help links in nav' do
+      it 'shows default help links in nav' do
         default_support_url = 'https://about.gitlab.com/getting-help/'
 
         visit root_dashboard_path
@@ -591,7 +591,7 @@ RSpec.describe 'Admin updates settings' do
         end
       end
 
-      it 'Shows custom support url in nav when set' do
+      it 'shows custom support url in nav when set' do
         new_support_url = 'http://example.com/help'
         stub_application_setting(help_page_support_url: new_support_url)
 

spec/features/boards/sidebar_spec.rb

@@ -72,7 +72,7 @@ RSpec.describe 'Issue Boards', :js do
     end
   end
 
-  it 'removes card from board when clicking ' do
+  it 'removes card from board when clicking' do
     click_card(card)
 
     page.within('.issue-boards-sidebar') do

spec/features/commits_spec.rb

@@ -125,7 +125,7 @@ RSpec.describe 'Commits' do
           visit pipeline_path(pipeline)
         end
 
-        it 'Renders header', :js do
+        it 'renders header', :js do
           expect(page).to have_content pipeline.sha[0..7]
           expect(page).to have_content pipeline.git_commit_message.gsub!(/\s+/, ' ')
           expect(page).to have_content pipeline.user.name

spec/features/dashboard/shortcuts_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe 'Dashboard shortcuts', :js do
       visit root_dashboard_path
     end
 
-    it 'Navigate to tabs' do
+    it 'navigate to tabs' do
       find('body').send_keys([:shift, 'I'])
 
       check_page_title('Issues')
@@ -45,7 +45,7 @@ RSpec.describe 'Dashboard shortcuts', :js do
       visit explore_root_path
     end
 
-    it 'Navigate to tabs' do
+    it 'navigate to tabs' do
       find('body').send_keys([:shift, 'G'])
 
       find('.nothing-here-block')

spec/features/groups/board_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe 'Group Boards' do
       visit group_boards_path(group)
     end
 
-    it 'Adds an issue to the backlog' do
+    it 'adds an issue to the backlog' do
       page.within(find('.board', match: :first)) do
         issue_title = 'New Issue'
         find(:css, '.issue-count-badge-add-button').click

spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb

@@ -105,7 +105,7 @@ RSpec.describe 'Resolving all open threads in a merge request from an issue', :j
       visit new_project_issue_path(project, merge_request_to_resolve_discussions_of: merge_request.iid)
     end
 
-    it 'Shows a notice to ask someone else to resolve the threads' do
+    it 'shows a notice to ask someone else to resolve the threads' do
       expect(page).to have_content("The threads at #{merge_request.to_reference} will stay unresolved. Ask someone with permission to resolve them.")
     end
   end

spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb

@@ -82,7 +82,7 @@ RSpec.describe 'Resolve an open thread in a merge request by creating an issue',
                                             discussion_to_resolve: discussion.id)
     end
 
-    it 'Shows a notice to ask someone else to resolve the threads' do
+    it 'shows a notice to ask someone else to resolve the threads' do
       expect(page).to have_content("The thread at #{merge_request.to_reference}"\
                                    " (discussion #{discussion.first_note.id}) will stay unresolved."\
                                    " Ask someone with permission to resolve it.")

spec/features/issues/issue_header_spec.rb

@@ -92,7 +92,7 @@ RSpec.describe 'issue header', :js do
         click_button 'Issue actions'
       end
 
-      it 'has "Submit as spam" item ' do
+      it 'has "Submit as spam" item' do
         expect(page).to have_link 'Submit as spam'
       end
     end

spec/features/markdown/mermaid_spec.rb

@@ -48,7 +48,7 @@ RSpec.describe 'Mermaid rendering', :js do
     expect(page.html.scan(expected).count).to be(4)
   end
 
-  it 'renders only 2 Mermaid blocks and ', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/234081' do
+  it 'renders only 2 Mermaid blocks and', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/234081' do
     description = <<~MERMAID
     ```mermaid
     graph LR

spec/features/milestone_spec.rb

@@ -101,7 +101,7 @@ RSpec.describe 'Milestone' do
   end
 
   describe 'Deleting a milestone' do
-    it "The delete milestone button does not show for unauthorized users" do
+    it "the delete milestone button does not show for unauthorized users" do
       create(:milestone, project: project, title: 8.7)
       sign_out(user)
 

spec/features/profiles/active_sessions_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe 'Profile > Active Sessions', :clean_gitlab_redis_shared_state do
 
   let(:admin) { create(:admin) }
 
-  it 'User sees their active sessions' do
+  it 'user sees their active sessions' do
     travel_to(Time.zone.parse('2018-03-12 09:06')) do
       Capybara::Session.new(:session1)
       Capybara::Session.new(:session2)
@@ -82,7 +82,7 @@ RSpec.describe 'Profile > Active Sessions', :clean_gitlab_redis_shared_state do
     end
   end
 
-  it 'User can revoke a session', :js do
+  it 'user can revoke a session', :js do
     Capybara::Session.new(:session1)
     Capybara::Session.new(:session2)
 

spec/features/profiles/emails_spec.rb

@@ -42,7 +42,7 @@ RSpec.describe 'Profile > Emails' do
     end
   end
 
-  it 'User removes email' do
+  it 'user removes email' do
     user.emails.create(email: 'my@email.com')
     visit profile_emails_path
     expect(page).to have_content("my@email.com")
@@ -51,7 +51,7 @@ RSpec.describe 'Profile > Emails' do
     expect(page).not_to have_content("my@email.com")
   end
 
-  it 'User confirms email' do
+  it 'user confirms email' do
     email = user.emails.create(email: 'my@email.com')
     visit profile_emails_path
     expect(page).to have_content("#{email.email} Unverified")
@@ -63,7 +63,7 @@ RSpec.describe 'Profile > Emails' do
     expect(page).to have_content("#{email.email} Verified")
   end
 
-  it 'User re-sends confirmation email' do
+  it 'user re-sends confirmation email' do
     email = user.emails.create(email: 'my@email.com')
     visit profile_emails_path
 

spec/features/profiles/gpg_keys_spec.rb

@@ -36,7 +36,7 @@ RSpec.describe 'Profile > GPG Keys' do
     end
   end
 
-  it 'User sees their key' do
+  it 'user sees their key' do
     create(:gpg_key, user: user, key: GpgHelpers::User2.public_key)
     visit profile_gpg_keys_path
 
@@ -45,7 +45,7 @@ RSpec.describe 'Profile > GPG Keys' do
     expect(page).to have_content(GpgHelpers::User2.fingerprint)
   end
 
-  it 'User removes a key via the key index' do
+  it 'user removes a key via the key index' do
     create(:gpg_key, user: user, key: GpgHelpers::User2.public_key)
     visit profile_gpg_keys_path
 
@@ -54,7 +54,7 @@ RSpec.describe 'Profile > GPG Keys' do
     expect(page).to have_content('Your GPG keys (0)')
   end
 
-  it 'User revokes a key via the key index' do
+  it 'user revokes a key via the key index' do
     gpg_key = create :gpg_key, user: user, key: GpgHelpers::User2.public_key
     gpg_signature = create :gpg_signature, gpg_key: gpg_key, verification_status: :verified
 

spec/features/profiles/keys_spec.rb

@@ -64,7 +64,7 @@ RSpec.describe 'Profile > SSH Keys' do
     end
   end
 
-  it 'User sees their keys' do
+  it 'user sees their keys' do
     key = create(:key, user: user)
     visit profile_keys_path
 

spec/features/profiles/user_changes_notified_of_own_activity_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe 'Profile > Notifications > User changes notified_of_own_activity
     sign_in(user)
   end
 
-  it 'User opts into receiving notifications about their own activity' do
+  it 'user opts into receiving notifications about their own activity' do
     visit profile_notifications_path
 
     expect(page).not_to have_checked_field('user[notified_of_own_activity]')
@@ -20,7 +20,7 @@ RSpec.describe 'Profile > Notifications > User changes notified_of_own_activity
     expect(page).to have_checked_field('user[notified_of_own_activity]')
   end
 
-  it 'User opts out of receiving notifications about their own activity' do
+  it 'user opts out of receiving notifications about their own activity' do
     user.update!(notified_of_own_activity: true)
     visit profile_notifications_path
 

spec/features/projects/clusters_spec.rb

@@ -110,7 +110,7 @@ RSpec.describe 'Clusters', :js do
         visit project_clusters_path(project)
       end
 
-      it 'user sees a add cluster button ' do
+      it 'user sees a add cluster button' do
         expect(page).to have_selector('.js-add-cluster:not(.readonly)')
       end
 

spec/features/projects/labels/issues_sorted_by_priority_spec.rb

@@ -15,7 +15,7 @@ RSpec.describe 'Issue prioritization' do
 
   # According to https://gitlab.com/gitlab-org/gitlab-foss/issues/14189#note_4360653
   context 'when issues have one label', :js do
-    it 'Are sorted properly' do
+    it 'are sorted properly' do
       # Issues
       issue_1 = create(:issue, title: 'issue_1', project: project)
       issue_2 = create(:issue, title: 'issue_2', project: project)
@@ -45,7 +45,7 @@ RSpec.describe 'Issue prioritization' do
   end
 
   context 'when issues have multiple labels', :js do
-    it 'Are sorted properly' do
+    it 'are sorted properly' do
       # Issues
       issue_1 = create(:issue, title: 'issue_1', project: project)
       issue_2 = create(:issue, title: 'issue_2', project: project)

spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb

@@ -22,7 +22,7 @@ RSpec.describe 'Projects > Show > User sees setup shortcut buttons' do
         visit project_path(project)
       end
 
-      it 'Project buttons are not visible' do
+      it 'project buttons are not visible' do
         visit project_path(project)
 
         page.within('.project-buttons') do

spec/features/snippets/private_snippets_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe 'Private Snippets', :js do
     sign_in(user)
   end
 
-  it 'Private Snippet renders for creator' do
+  it 'private Snippet renders for creator' do
     visit snippet_path(private_snippet)
     wait_for_requests
 

spec/features/snippets/public_snippets_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe 'Public Snippets', :js do
   let(:public_snippet) { create(:personal_snippet, :public, :repository) }
   let(:content) { public_snippet.blobs.first.data.strip! }
 
-  it 'Unauthenticated user should see public snippets' do
+  it 'unauthenticated user should see public snippets' do
     url = Gitlab::UrlBuilder.build(public_snippet)
 
     visit snippet_path(public_snippet)
@@ -18,7 +18,7 @@ RSpec.describe 'Public Snippets', :js do
     expect(page).to have_field('Share', readonly: true, with: url)
   end
 
-  it 'Unauthenticated user should see raw public snippets' do
+  it 'unauthenticated user should see raw public snippets' do
     visit raw_snippet_path(public_snippet)
 
     expect(page).to have_content(content)

spec/features/snippets/search_snippets_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe 'Search Snippets' do
-  it 'User searches for snippets by title' do
+  it 'user searches for snippets by title' do
     public_snippet = create(:personal_snippet, :public, title: 'Beginning and Middle')
     private_snippet = create(:personal_snippet, :private, title: 'Middle and End')
 

spec/features/snippets/user_creates_snippet_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe 'User creates snippet', :js do
     snippet_fill_in_form(title: title, content: file_content, description: md_description)
   end
 
-  it 'Authenticated user creates a snippet' do
+  it 'authenticated user creates a snippet' do
     fill_form
 
     click_button('Create snippet')

spec/features/snippets/user_snippets_spec.rb

@@ -13,13 +13,13 @@ RSpec.describe 'User Snippets' do
     visit dashboard_snippets_path
   end
 
-  it 'View all of my snippets' do
+  it 'view all of my snippets' do
     expect(page).to have_link(public_snippet.title, href: snippet_path(public_snippet))
     expect(page).to have_link(internal_snippet.title, href: snippet_path(internal_snippet))
     expect(page).to have_link(private_snippet.title, href: snippet_path(private_snippet))
   end
 
-  it 'View my public snippets' do
+  it 'view my public snippets' do
     page.within('.snippet-scope-menu') do
       click_link "Public"
     end
@@ -29,7 +29,7 @@ RSpec.describe 'User Snippets' do
     expect(page).not_to have_content(private_snippet.title)
   end
 
-  it 'View my internal snippets' do
+  it 'view my internal snippets' do
     page.within('.snippet-scope-menu') do
       click_link "Internal"
     end
@@ -39,7 +39,7 @@ RSpec.describe 'User Snippets' do
     expect(page).not_to have_content(private_snippet.title)
   end
 
-  it 'View my private snippets' do
+  it 'view my private snippets' do
     page.within('.snippet-scope-menu') do
       click_link "Private"
     end

spec/features/users/active_sessions_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe 'Active user sessions', :clean_gitlab_redis_shared_state do
-  it 'Successful login adds a new active user login' do
+  it 'successful login adds a new active user login' do
     now = Time.zone.parse('2018-03-12 09:06')
     Timecop.freeze(now) do
       user = create(:user)
@@ -26,7 +26,7 @@ RSpec.describe 'Active user sessions', :clean_gitlab_redis_shared_state do
     end
   end
 
-  it 'Successful login cleans up obsolete entries' do
+  it 'successful login cleans up obsolete entries' do
     user = create(:user)
 
     Gitlab::Redis::SharedState.with do |redis|
@@ -40,7 +40,7 @@ RSpec.describe 'Active user sessions', :clean_gitlab_redis_shared_state do
     end
   end
 
-  it 'Sessionless login does not clean up obsolete entries' do
+  it 'sessionless login does not clean up obsolete entries' do
     user = create(:user)
     personal_access_token = create(:personal_access_token, user: user)
 
@@ -56,7 +56,7 @@ RSpec.describe 'Active user sessions', :clean_gitlab_redis_shared_state do
     end
   end
 
-  it 'Logout deletes the active user login' do
+  it 'logout deletes the active user login' do
     user = create(:user)
     gitlab_sign_in(user)
     expect(current_path).to eq root_path

spec/helpers/clusters_helper_spec.rb

@@ -131,7 +131,7 @@ RSpec.describe ClustersHelper do
     context 'other values' do
       let(:cluster_type) { 'not_supported' }
 
-      it 'Diplays generic cluster and reports error' do
+      it 'diplays generic cluster and reports error' do
         expect(Gitlab::ErrorTracking).to receive(:track_and_raise_for_dev_exception).with(
           an_instance_of(ArgumentError),
           cluster_error: { error: 'Cluster Type Missing', cluster_type: 'not_supported' }

spec/helpers/emails_helper_spec.rb

@@ -296,7 +296,7 @@ RSpec.describe EmailsHelper do
     end
 
     with_them do
-      it 'Produces the right List-Id' do
+      it 'produces the right List-Id' do
         project = double("project")
         allow(project).to receive(:full_path).and_return(full_path)
         allow(project).to receive(:id).and_return(12345)

spec/helpers/issuables_helper_spec.rb

@@ -218,7 +218,7 @@ RSpec.describe IssuablesHelper do
         assign(:project, issue.project)
       end
 
-      it 'sets sentryIssueIdentifier to nil with no sentry issue ' do
+      it 'sets sentryIssueIdentifier to nil with no sentry issue' do
         expect(helper.issuable_initial_data(issue)[:sentryIssueIdentifier])
           .to be_nil
       end

spec/lib/banzai/pipeline/jira_import/adf_commonmark_pipeline_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 RSpec.describe Banzai::Pipeline::JiraImport::AdfCommonmarkPipeline do
   let_it_be(:fixtures_path) { 'lib/kramdown/atlassian_document_format' }
 
-  it 'converts text in Atlassian Document Format ' do
+  it 'converts text in Atlassian Document Format' do
     source = fixture_file(File.join(fixtures_path, 'paragraph.json'))
     target = fixture_file(File.join(fixtures_path, 'paragraph.md'))
     output = described_class.call(source, {})[:output]

spec/lib/gitlab/database/postgres_index_spec.rb

@@ -27,7 +27,7 @@ RSpec.describe Gitlab::Database::PostgresIndex do
       expect(described_class.regular).to all(have_attributes(unique: false))
     end
 
-    it 'only non partitioned indexes ' do
+    it 'only non partitioned indexes' do
       expect(described_class.regular).to all(have_attributes(partitioned: false))
     end
 

spec/lib/gitlab/git/repository_spec.rb

@@ -929,7 +929,7 @@ RSpec.describe Gitlab::Git::Repository, :seed_helper do
       end
 
       context 'with max_count' do
-        it 'returns the number of commits with path ' do
+        it 'returns the number of commits with path' do
           options = { ref: 'master', max_count: 5 }
 
           expect(repository.count_commits(options)).to eq(5)
@@ -937,7 +937,7 @@ RSpec.describe Gitlab::Git::Repository, :seed_helper do
       end
 
       context 'with path' do
-        it 'returns the number of commits with path ' do
+        it 'returns the number of commits with path' do
           options = { ref: 'master', path: 'encoding' }
 
           expect(repository.count_commits(options)).to eq(2)
@@ -965,7 +965,7 @@ RSpec.describe Gitlab::Git::Repository, :seed_helper do
           end
 
           context 'with max_count' do
-            it 'returns the number of commits with path ' do
+            it 'returns the number of commits with path' do
               options = { from: 'fix-mode', to: 'fix-blob-path', left_right: true, max_count: 1 }
 
               expect(repository.count_commits(options)).to eq([1, 1])

spec/lib/gitlab/graphql/timeout_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe Gitlab::Graphql::Timeout do
-  it 'inherits from ' do
+  it 'inherits from' do
     expect(described_class.superclass).to eq GraphQL::Schema::Timeout
   end
 

spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe Gitlab::ImportExport::JSON::NdjsonWriter do
 
   describe "#write_relation" do
     context "when single relation is serialized" do
-      it "appends json in correct file " do
+      it "appends json in correct file" do
         relation = "relation"
         value =  { "key" => "value_1", "key_1" => "value_1" }
         subject.write_relation(exportable_path, relation, value)

spec/lib/gitlab/usage_data_counters/editor_unique_counter_spec.rb

@@ -86,7 +86,7 @@ RSpec.describe Gitlab::UsageDataCounters::EditorUniqueCounter, :clean_gitlab_red
     end
   end
 
-  it 'can return the count of actions per user deduplicated ' do
+  it 'can return the count of actions per user deduplicated' do
     described_class.track_web_ide_edit_action(author: user1)
     described_class.track_snippet_editor_edit_action(author: user1)
     described_class.track_sfe_edit_action(author: user1)

spec/migrations/ensure_namespace_settings_creation_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe EnsureNamespaceSettingsCreation do
       end
     end
 
-    it 'schedules migrations in batches ' do
+    it 'schedules migrations in batches' do
       stub_const("#{described_class.name}::BATCH_SIZE", 2)
 
       namespace_3 = namespaces.create!(name: 'gitlab', path: 'gitlab-org3')

spec/models/ci/build_trace_chunk_spec.rb

@@ -91,7 +91,7 @@ RSpec.describe Ci::BuildTraceChunk, :clean_gitlab_redis_shared_state do
   end
 
   describe 'CHUNK_SIZE' do
-    it 'Chunk size can not be changed without special care' do
+    it 'chunk size can not be changed without special care' do
       expect(described_class::CHUNK_SIZE).to eq(128.kilobytes)
     end
   end

spec/models/ci/pipeline_spec.rb

@@ -2954,7 +2954,7 @@ RSpec.describe Ci::Pipeline, :mailer, factory_default: :keep do
         stub_feature_flags(ci_store_pipeline_messages: false)
       end
 
-      it ' does not add pipeline error message' do
+      it 'does not add pipeline error message' do
         pipeline.add_error_message('The error message')
 
         expect(pipeline.messages).to be_empty

spec/models/note_spec.rb

@@ -357,7 +357,7 @@ RSpec.describe Note do
   describe '#confidential?' do
     context 'when note is not confidential' do
       context 'when include_noteable is set to true' do
-        it 'is true when a noteable is confidential ' do
+        it 'is true when a noteable is confidential' do
           issue = create(:issue, :confidential)
           note = build(:note, noteable: issue, project: issue.project)
 
@@ -366,7 +366,7 @@ RSpec.describe Note do
       end
 
       context 'when include_noteable is not set to true' do
-        it 'is false when a noteable is confidential ' do
+        it 'is false when a noteable is confidential' do
           issue = create(:issue, :confidential)
           note = build(:note, noteable: issue, project: issue.project)
 

spec/models/user_spec.rb

@@ -1087,7 +1087,7 @@ RSpec.describe User do
         @user.update!(email: 'new_primary@example.com')
       end
 
-      it 'adds old primary to secondary emails when secondary is a new email ' do
+      it 'adds old primary to secondary emails when secondary is a new email' do
         @user.update!(email: 'new_primary@example.com')
         @user.reload
 

spec/presenters/snippet_presenter_spec.rb

@@ -72,7 +72,7 @@ RSpec.describe SnippetPresenter do
     context 'with ProjectSnippet' do
       let(:snippet) { project_snippet }
 
-      it 'checks read_snippet ' do
+      it 'checks read_snippet' do
         expect(presenter).to receive(:can?).with(user, :read_snippet, snippet)
 
         subject
@@ -96,7 +96,7 @@ RSpec.describe SnippetPresenter do
     context 'with ProjectSnippet' do
       let(:snippet) { project_snippet }
 
-      it 'checks update_snippet ' do
+      it 'checks update_snippet' do
         expect(presenter).to receive(:can?).with(user, :update_snippet, snippet)
 
         subject
@@ -120,7 +120,7 @@ RSpec.describe SnippetPresenter do
     context 'with ProjectSnippet' do
       let(:snippet) { project_snippet }
 
-      it 'checks admin_snippet ' do
+      it 'checks admin_snippet' do
         expect(presenter).to receive(:can?).with(user, :admin_snippet, snippet)
 
         subject

spec/requests/api/broadcast_messages_spec.rb

@@ -112,7 +112,7 @@ RSpec.describe API::BroadcastMessages do
         expect(response).to have_gitlab_http_status(:bad_request)
       end
 
-      it 'accepts an active dismissable value ' do
+      it 'accepts an active dismissable value' do
         attrs = { message: 'new message', dismissable: true }
 
         post api('/broadcast_messages', admin), params: attrs
@@ -197,7 +197,7 @@ RSpec.describe API::BroadcastMessages do
         expect(response).to have_gitlab_http_status(:bad_request)
       end
 
-      it 'accepts a new dismissable value ' do
+      it 'accepts a new dismissable value' do
         attrs = { message: 'new message', dismissable: true }
 
         put api("/broadcast_messages/#{message.id}", admin), params: attrs

spec/requests/api/ci/runner/jobs_trace_spec.rb

@@ -135,7 +135,7 @@ RSpec.describe API::Ci::Runner, :clean_gitlab_redis_shared_state do
                 patch_the_trace
               end
 
-              it 'returns Forbidden ' do
+              it 'returns Forbidden' do
                 expect(response).to have_gitlab_http_status(:forbidden)
               end
             end

spec/requests/api/graphql/issue/issue_spec.rb

@@ -125,7 +125,7 @@ RSpec.describe 'Query.issue(id)' do
     let(:issue_params) { { 'id' => confidential_issue.to_global_id.to_s } }
 
     context 'when the user cannot see confidential issues' do
-      it 'returns nil ' do
+      it 'returns nil' do
         post_graphql(query, current_user: current_user)
 
         expect(issue_data).to be nil

spec/requests/api/graphql_spec.rb

@@ -105,7 +105,7 @@ RSpec.describe 'GraphQL' do
         stub_authentication_activity_metrics(debug: false)
       end
 
-      it 'Authenticates users with a PAT' do
+      it 'authenticates users with a PAT' do
         expect(authentication_metrics)
           .to increment(:user_authenticated_counter)
           .and increment(:user_session_override_counter)

spec/rubocop/cop/include_sidekiq_worker_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe RuboCop::Cop::IncludeSidekiqWorker, type: :rubocop do
     let(:source) { 'include Sidekiq::Worker' }
     let(:correct_source) { 'include ApplicationWorker' }
 
-    it 'registers an offense ' do
+    it 'registers an offense' do
       inspect_source(source)
 
       aggregate_failures do

spec/rubocop/cop/migration/add_column_with_default_spec.rb

@@ -26,7 +26,7 @@ RSpec.describe RuboCop::Cop::Migration::AddColumnWithDefault, type: :rubocop do
 
     let(:offense) { '`add_column_with_default` is deprecated, use `add_column` instead' }
 
-    it 'registers an offense ' do
+    it 'registers an offense' do
       expect_offense(<<~RUBY)
         def up
           add_column_with_default(:merge_request_diff_files, :artifacts, :boolean, default: true, allow_null: false)

spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb

@@ -88,7 +88,7 @@ RSpec.describe RuboCop::Cop::Migration::CreateTableWithForeignKeys, type: :ruboc
 
         shared_examples 'target to high traffic table' do |dsl_method, table_name|
           context 'when the target is defined as option' do
-            it 'registers an offense ' do
+            it 'registers an offense' do
               expect_offense(<<~RUBY)
                 def up
                   create_table(:foo) do |t|
@@ -102,7 +102,7 @@ RSpec.describe RuboCop::Cop::Migration::CreateTableWithForeignKeys, type: :ruboc
           end
 
           context 'when the target has implicit definition' do
-            it 'registers an offense ' do
+            it 'registers an offense' do
               expect_offense(<<~RUBY)
                 def up
                   create_table(:foo) do |t|

spec/services/application_settings/update_service_spec.rb

@@ -49,7 +49,7 @@ RSpec.describe ApplicationSettings::UpdateService do
         expect(application_settings.terms).to eq('Be nice!')
       end
 
-      it 'Only queries once when the terms are changed' do
+      it 'only queries once when the terms are changed' do
         create(:term, terms: 'Other terms')
         expect(application_settings.terms).to eq('Other terms')
 
@@ -257,7 +257,7 @@ RSpec.describe ApplicationSettings::UpdateService do
       described_class.new(application_settings, admin, { external_authorization_service_enabled: false }).execute
     end
 
-    it 'does validate labels if external authorization gets enabled ' do
+    it 'does validate labels if external authorization gets enabled' do
       expect_any_instance_of(described_class).to receive(:validate_classification_label)
 
       described_class.new(application_settings, admin, { external_authorization_service_enabled: true }).execute

spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb

@@ -191,7 +191,7 @@ RSpec.describe AutoMerge::MergeWhenPipelineSucceedsService do
       expect(mr_merge_if_green_enabled.merge_user).to be nil
     end
 
-    it 'Posts a system note' do
+    it 'posts a system note' do
       note = mr_merge_if_green_enabled.notes.last
       expect(note.note).to include 'canceled the automatic merge'
     end

spec/services/files/delete_service_spec.rb

@@ -55,7 +55,7 @@ RSpec.describe Files::DeleteService do
     context "when the file's last commit sha does not match the supplied last_commit_sha" do
       let(:last_commit_sha) { "foo" }
 
-      it "returns a hash with the correct error message and a :error status " do
+      it "returns a hash with the correct error message and a :error status" do
         expect { subject.execute }
           .to raise_error(Files::UpdateService::FileChangedError,
                          "You are attempting to delete a file that has been previously updated.")

spec/services/files/update_service_spec.rb

@@ -34,7 +34,7 @@ RSpec.describe Files::UpdateService do
     context "when the file's last commit sha does not match the supplied last_commit_sha" do
       let(:last_commit_sha) { "foo" }
 
-      it "returns a hash with the correct error message and a :error status " do
+      it "returns a hash with the correct error message and a :error status" do
         expect { subject.execute }
           .to raise_error(Files::UpdateService::FileChangedError,
                          "You are attempting to update a file that has changed since you started editing it.")
@@ -44,7 +44,7 @@ RSpec.describe Files::UpdateService do
     context "when the file's last commit sha does match the supplied last_commit_sha" do
       let(:last_commit_sha) { Gitlab::Git::Commit.last_for_path(project.repository, project.default_branch, file_path).sha }
 
-      it "returns a hash with the :success status " do
+      it "returns a hash with the :success status" do
         results = subject.execute
 
         expect(results[:status]).to match(:success)
@@ -68,7 +68,7 @@ RSpec.describe Files::UpdateService do
     end
 
     context "when the last_commit_sha is not supplied" do
-      it "returns a hash with the :success status " do
+      it "returns a hash with the :success status" do
         results = subject.execute
 
         expect(results[:status]).to match(:success)

spec/services/git/tag_hooks_service_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe Git::TagHooksService, :service do
   end
 
   describe 'System hooks' do
-    it 'Executes system hooks' do
+    it 'executes system hooks' do
       push_data = service.send(:push_data)
       expect(project).to receive(:has_active_hooks?).and_return(true)
 

spec/services/quick_actions/interpret_service_spec.rb

@@ -1584,7 +1584,7 @@ RSpec.describe QuickActions::InterpretService do
       end
     end
 
-    it 'limits to commands passed ' do
+    it 'limits to commands passed' do
       content = "/shrug test\n/close"
 
       text, commands = service.execute(content, issue, only: [:shrug])
@@ -1593,7 +1593,7 @@ RSpec.describe QuickActions::InterpretService do
       expect(text).to eq("test #{described_class::SHRUG}\n/close")
     end
 
-    it 'preserves leading whitespace ' do
+    it 'preserves leading whitespace' do
       content = " - list\n\n/close\n\ntest\n\n"
 
       text, _ = service.execute(content, issue)

spec/services/users/create_service_spec.rb

@@ -59,7 +59,7 @@ RSpec.describe Users::CreateService do
           service.execute
         end
 
-        it 'executes system hooks ' do
+        it 'executes system hooks' do
           system_hook_service = spy(:system_hook_service)
 
           expect(service).to receive(:system_hook_service).and_return(system_hook_service)

spec/support/shared_examples/features/reportable_note_shared_examples.rb

@@ -29,7 +29,7 @@ RSpec.shared_examples 'reportable note' do |type|
     end
   end
 
-  it 'Report button links to a report page' do
+  it 'report button links to a report page' do
     dropdown = comment.find(more_actions_selector)
     open_dropdown(dropdown)
 

spec/support/shared_examples/features/wiki/user_uses_wiki_shortcuts_shared_examples.rb

@@ -12,7 +12,7 @@ RSpec.shared_examples 'User uses wiki shortcuts' do
     visit wiki_page_path(wiki, wiki_page)
   end
 
-  it 'Visit edit wiki page using "e" keyboard shortcut', :js do
+  it 'visit edit wiki page using "e" keyboard shortcut', :js do
     find('body').native.send_key('e')
 
     expect(find('.wiki-page-title')).to have_content('Edit Page')

tooling/overcommit/Gemfile

@@ -4,6 +4,6 @@
 source 'https://rubygems.org'
 
 gem 'overcommit'
-gem 'gitlab-styles', '~> 5.1.0', require: false
+gem 'gitlab-styles', '~> 5.2.0', require: false
 gem 'scss_lint', '~> 0.56.0', require: false
 gem 'haml_lint', '~> 0.34.0', require: false

tooling/overcommit/Gemfile.lock

@@ -11,7 +11,7 @@ GEM
     childprocess (3.0.0)
     concurrent-ruby (1.1.7)
     ffi (1.12.2)
-    gitlab-styles (5.1.0)
+    gitlab-styles (5.2.0)
       rubocop (~> 0.89.1)
       rubocop-gitlab-security (~> 0.1.0)
       rubocop-performance (~> 1.8.1)
@@ -88,7 +88,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  gitlab-styles (~> 5.1.0)
+  gitlab-styles (~> 5.2.0)
   haml_lint (~> 0.34.0)
   overcommit
   scss_lint (~> 0.56.0)