Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
af65c04d
Commit
af65c04d
authored
Aug 06, 2018
by
Mark Chao
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add frozen string literal header
parent
74bdc9a3
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
30 additions
and
16 deletions
+30
-16
ee/app/finders/epics/date_sourcing_milestones_finder.rb
ee/app/finders/epics/date_sourcing_milestones_finder.rb
+2
-0
ee/spec/finders/epics/date_sourcing_milestones_finder_spec.rb
...pec/finders/epics/date_sourcing_milestones_finder_spec.rb
+26
-16
ee/spec/migrations/update_epic_dates_from_milestones_spec.rb
ee/spec/migrations/update_epic_dates_from_milestones_spec.rb
+2
-0
No files found.
ee/app/finders/epics/date_sourcing_milestones_finder.rb
View file @
af65c04d
# frozen_string_literal: true
module
Epics
class
DateSourcingMilestonesFinder
def
self
.
execute
(
epic_id
)
...
...
ee/spec/finders/epics/date_sourcing_milestones_finder_spec.rb
View file @
af65c04d
# frozen_string_literal: true
require
'spec_helper'
describe
Epics
::
DateSourcingMilestonesFinder
do
...
...
@@ -13,10 +15,12 @@ describe Epics::DateSourcingMilestonesFinder do
results
=
described_class
.
execute
(
epic
.
id
)
expect
(
results
.
start_date
).
to
eq
(
milestone1
.
start_date
)
expect
(
results
.
start_date_sourcing_milestone_id
).
to
eq
(
milestone1
.
id
)
expect
(
results
.
due_date
).
to
eq
(
milestone2
.
due_date
)
expect
(
results
.
due_date_sourcing_milestone_id
).
to
eq
(
milestone2
.
id
)
expect
(
results
).
to
have_attributes
(
start_date:
milestone1
.
start_date
,
start_date_sourcing_milestone_id:
milestone1
.
id
,
due_date:
milestone2
.
due_date
,
due_date_sourcing_milestone_id:
milestone2
.
id
)
end
it
'returns date and id from single milestone'
do
...
...
@@ -26,10 +30,12 @@ describe Epics::DateSourcingMilestonesFinder do
results
=
described_class
.
execute
(
epic
.
id
)
expect
(
results
.
start_date
).
to
eq
(
milestone1
.
start_date
)
expect
(
results
.
start_date_sourcing_milestone_id
).
to
eq
(
milestone1
.
id
)
expect
(
results
.
due_date
).
to
eq
(
milestone1
.
due_date
)
expect
(
results
.
due_date_sourcing_milestone_id
).
to
eq
(
milestone1
.
id
)
expect
(
results
).
to
have_attributes
(
start_date:
milestone1
.
start_date
,
start_date_sourcing_milestone_id:
milestone1
.
id
,
due_date:
milestone1
.
due_date
,
due_date_sourcing_milestone_id:
milestone1
.
id
)
end
it
'returns date and id from milestone without date'
do
...
...
@@ -39,10 +45,12 @@ describe Epics::DateSourcingMilestonesFinder do
results
=
described_class
.
execute
(
epic
.
id
)
expect
(
results
.
start_date
).
to
eq
(
milestone1
.
start_date
)
expect
(
results
.
start_date_sourcing_milestone_id
).
to
eq
(
milestone1
.
id
)
expect
(
results
.
due_date
).
to
eq
(
nil
)
expect
(
results
.
due_date_sourcing_milestone_id
).
to
eq
(
nil
)
expect
(
results
).
to
have_attributes
(
start_date:
milestone1
.
start_date
,
start_date_sourcing_milestone_id:
milestone1
.
id
,
due_date:
nil
,
due_date_sourcing_milestone_id:
nil
)
end
it
'handles epics without milestone'
do
...
...
@@ -50,10 +58,12 @@ describe Epics::DateSourcingMilestonesFinder do
results
=
described_class
.
execute
(
epic
.
id
)
expect
(
results
.
start_date
).
to
eq
(
nil
)
expect
(
results
.
start_date_sourcing_milestone_id
).
to
eq
(
nil
)
expect
(
results
.
due_date
).
to
eq
(
nil
)
expect
(
results
.
due_date_sourcing_milestone_id
).
to
eq
(
nil
)
expect
(
results
).
to
have_attributes
(
start_date:
nil
,
start_date_sourcing_milestone_id:
nil
,
due_date:
nil
,
due_date_sourcing_milestone_id:
nil
)
end
end
end
ee/spec/migrations/update_epic_dates_from_milestones_spec.rb
View file @
af65c04d
# frozen_string_literal: true
require
'spec_helper'
require
Rails
.
root
.
join
(
'ee'
,
'db'
,
'post_migrate'
,
'20180713171825_update_epic_dates_from_milestones.rb'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment