Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
af6bf959
Commit
af6bf959
authored
Feb 03, 2022
by
Simon Knox
Committed by
Paul Slaughter
Feb 24, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove fix_comment_scroll feature flag
Changelog: fixed
parent
cbeae351
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
12 deletions
+1
-12
app/assets/javascripts/issues/show/index.js
app/assets/javascripts/issues/show/index.js
+1
-3
app/controllers/projects/issues_controller.rb
app/controllers/projects/issues_controller.rb
+0
-1
config/feature_flags/development/fix_comment_scroll.yml
config/feature_flags/development/fix_comment_scroll.yml
+0
-8
No files found.
app/assets/javascripts/issues/show/index.js
View file @
af6bf959
...
...
@@ -77,9 +77,7 @@ export function initIssueApp(issueData, store) {
const
{
fullPath
}
=
el
.
dataset
;
if
(
gon
?.
features
?.
fixCommentScroll
)
{
scrollToTargetOnResize
();
}
scrollToTargetOnResize
();
bootstrapApollo
({
...
issueState
,
issueType
:
el
.
dataset
.
issueType
});
...
...
app/controllers/projects/issues_controller.rb
View file @
af6bf959
...
...
@@ -49,7 +49,6 @@ class Projects::IssuesController < Projects::ApplicationController
push_frontend_feature_flag
(
:confidential_notes
,
project
&
.
group
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:issue_assignees_widget
,
project
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:paginated_issue_discussions
,
project
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:fix_comment_scroll
,
project
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:work_items
,
project
&
.
group
,
default_enabled: :yaml
)
end
...
...
config/feature_flags/development/fix_comment_scroll.yml
deleted
100644 → 0
View file @
cbeae351
---
name
:
fix_comment_scroll
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/76340
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/349638
milestone
:
'
14.7'
type
:
development
group
:
group::project management
default_enabled
:
false
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment