Merge branch 'fix/gb/qa/fix-test-scenario-for-adding-a-project' into 'master'

Fix QA test scenario for creating a new project

Closes gitlab-qa#56

See merge request !12747

qa/qa.rb

@@ -49,7 +49,6 @@ module QA
       autoload :Entry, 'qa/page/main/entry'
       autoload :Menu, 'qa/page/main/menu'
       autoload :Groups, 'qa/page/main/groups'
-      autoload :Projects, 'qa/page/main/projects'
     end
 
     module Project

qa/qa/page/main/menu.rb

@@ -14,6 +14,13 @@ module QA
           within_user_menu { click_link 'Admin area' }
         end
 
+        def go_to_new_project
+          within_user_menu do
+            find('.header-new-dropdown-toggle').click
+            click_link('New project')
+          end
+        end
+
         def sign_out
           within_user_menu do
             find('.header-user-dropdown-toggle').click

qa/qa/page/main/projects.rb

-module QA
-  module Page
-    module Main
-      class Projects < Page::Base
-        def go_to_new_project
-          ##
-          # There are 'New Project' and 'New project' buttons on the projects
-          # page, so we can't use `click_on`.
-          #
-          button = find('a', text: /^new project$/i)
-          button.click
-        end
-      end
-    end
-  end
-end

qa/qa/scenario/gitlab/project/create.rb

@@ -14,8 +14,7 @@ module QA
           def perform
             Page::Main::Menu.act { go_to_groups }
             Page::Main::Groups.act { prepare_test_namespace }
-            Page::Main::Menu.act { go_to_projects }
-            Page::Main::Projects.act { go_to_new_project }
+            Page::Main::Menu.act { go_to_new_project }
 
             Page::Project::New.perform do |page|
               page.choose_test_namespace