Commit b179aac0 authored by Peter Leitzen's avatar Peter Leitzen

Merge branch '344279-metadata-extraction-openstruct-fix' into 'master'

Fix OpenStruct use in metadata_extraction_service

See merge request gitlab-org/gitlab!74271
parents bcd75360 a8057eb8
...@@ -32,7 +32,6 @@ Style/OpenStructUse: ...@@ -32,7 +32,6 @@ Style/OpenStructUse:
- spec/lib/gitlab/quick_actions/command_definition_spec.rb - spec/lib/gitlab/quick_actions/command_definition_spec.rb
- spec/models/design_management/design_action_spec.rb - spec/models/design_management/design_action_spec.rb
- spec/models/design_management/design_at_version_spec.rb - spec/models/design_management/design_at_version_spec.rb
- spec/services/packages/nuget/metadata_extraction_service_spec.rb
- spec/services/projects/import_service_spec.rb - spec/services/projects/import_service_spec.rb
- spec/services/system_note_service_spec.rb - spec/services/system_note_service_spec.rb
- spec/support/helpers/import_spec_helper.rb - spec/support/helpers/import_spec_helper.rb
......
...@@ -78,7 +78,7 @@ RSpec.describe Packages::Nuget::MetadataExtractionService do ...@@ -78,7 +78,7 @@ RSpec.describe Packages::Nuget::MetadataExtractionService do
end end
context 'with invalid package file id' do context 'with invalid package file id' do
let(:package_file) { OpenStruct.new(id: 555) } let(:package_file) { double('file', id: 555) }
it { expect { subject }.to raise_error(::Packages::Nuget::MetadataExtractionService::ExtractionError, 'invalid package file') } it { expect { subject }.to raise_error(::Packages::Nuget::MetadataExtractionService::ExtractionError, 'invalid package file') }
end end
...@@ -109,7 +109,7 @@ RSpec.describe Packages::Nuget::MetadataExtractionService do ...@@ -109,7 +109,7 @@ RSpec.describe Packages::Nuget::MetadataExtractionService do
context 'with a too big nuspec file' do context 'with a too big nuspec file' do
before do before do
allow_any_instance_of(Zip::File).to receive(:glob).and_return([OpenStruct.new(size: 6.megabytes)]) allow_any_instance_of(Zip::File).to receive(:glob).and_return([double('file', size: 6.megabytes)])
end end
it { expect { subject }.to raise_error(::Packages::Nuget::MetadataExtractionService::ExtractionError, 'nuspec file too big') } it { expect { subject }.to raise_error(::Packages::Nuget::MetadataExtractionService::ExtractionError, 'nuspec file too big') }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment