Prefer lodash pickBy

Removes the omitEmptyProperties method in favour
of lodash pickBy

app/assets/javascripts/init_confirm_danger.js

 import Vue from 'vue';
-import { parseBoolean, omitEmptyProperties } from './lib/utils/common_utils';
+import { pickBy } from 'lodash';
+import { parseBoolean } from './lib/utils/common_utils';
 import ConfirmDanger from './vue_shared/components/confirm_danger/confirm_danger.vue';
 
 export default () => {
@@ -22,12 +23,15 @@ export default () => {
 
   return new Vue({
     el,
-    provide: omitEmptyProperties({
-      htmlConfirmationMessage,
-      confirmDangerMessage,
-      additionalInformation,
-      confirmButtonText,
-    }),
+    provide: pickBy(
+      {
+        htmlConfirmationMessage,
+        confirmDangerMessage,
+        additionalInformation,
+        confirmButtonText,
+      },
+      (v) => Boolean(v),
+    ),
     render: (createElement) =>
       createElement(ConfirmDanger, {
         props: {

app/assets/javascripts/lib/utils/common_utils.js

@@ -746,25 +746,3 @@ export const isLoggedIn = () => Boolean(window.gon?.current_user_id);
  */
 export const convertArrayOfObjectsToCamelCase = (array) =>
   array.map((o) => convertObjectPropsToCamelCase(o));
-
-/**
- * This method takes an object and omits any properties
- * that are null, undefined, false or empty. The returned
- * object only includes properties that have a `truthy` value.
- *
- * @param {Object} obj - Target object to be checked
- * @returns {Object} Resulting object with only truthy properties
- */
-export const omitEmptyProperties = (obj = {}) => {
-  const entries = Object.entries(obj);
-  if (!entries.length) {
-    return obj;
-  }
-
-  return entries.reduce((acc, [key, value]) => {
-    if (!value) {
-      return acc;
-    }
-    return { ...acc, [key]: value };
-  }, {});
-};

spec/frontend/lib/utils/common_utils_spec.js

@@ -1051,30 +1051,4 @@ describe('common_utils', () => {
       expect(result).toEqual([{ hello: '' }, { helloWorld: '' }]);
     });
   });
-
-  describe('omitEmptyProperties', () => {
-    let res;
-    const empty = { foo: null, bar: undefined, baz: '', qux: false };
-    const values = { a: 'a', b: 1, c: { d: 'd' }, e: ['f'] };
-
-    beforeEach(() => {
-      res = Object.keys(
-        commonUtils.omitEmptyProperties({
-          ...empty,
-          ...values,
-        }),
-      );
-    });
-
-    it('returns an object with properties that have a value', () => {
-      const valueKeys = Object.keys(values);
-      expect(res).toEqual(valueKeys);
-    });
-
-    it('ignores properties that are empty, nullable or falsy', () => {
-      Object.keys(empty).forEach((key) => {
-        expect(res).not.toContain(key);
-      });
-    });
-  });
 });