Merge branch 'frozen-string-ee-app-controllers' into 'master'

Enable some frozen string in ee/app

See merge request gitlab-org/gitlab-ee!8580

ee/app/controllers/admin/audit_logs_controller.rb

+# frozen_string_literal: true
+
 class Admin::AuditLogsController < Admin::ApplicationController
   before_action :check_license_admin_audit_log_available!
 

ee/app/controllers/admin/emails_controller.rb

+# frozen_string_literal: true
+
 class Admin::EmailsController < Admin::ApplicationController
   def show
   end

ee/app/controllers/admin/licenses_controller.rb

+# frozen_string_literal: true
+
 class Admin::LicensesController < Admin::ApplicationController
   before_action :license, only: [:show, :download, :destroy]
   before_action :require_license, only: [:download, :destroy]

ee/app/controllers/admin/push_rules_controller.rb

+# frozen_string_literal: true
+
 class Admin::PushRulesController < Admin::ApplicationController
   before_action :check_push_rules_available!
   before_action :push_rule

ee/app/controllers/boards/milestones_controller.rb

+# frozen_string_literal: true
+
 module Boards
   class MilestonesController < Boards::ApplicationController
     def index

ee/app/controllers/boards/users_controller.rb

+# frozen_string_literal: true
+
 module Boards
   class UsersController < Boards::ApplicationController
     # Enumerates all users that are members of the board parent

ee/app/controllers/concerns/ee/internal_redirect.rb

+# frozen_string_literal: true
+
 module EE
   module InternalRedirect
     extend ::Gitlab::Utils::Override

ee/app/controllers/concerns/ee/issuable_actions.rb

+# frozen_string_literal: true
+
 module EE
   module IssuableActions
     extend ActiveSupport::Concern

ee/app/controllers/concerns/ee/issuable_collections.rb

+# frozen_string_literal: true
+
 module EE
   module IssuableCollections
     extend ActiveSupport::Concern

ee/app/controllers/concerns/ee/lfs_request.rb

+# frozen_string_literal: true
+
 module EE
   module LfsRequest
     extend ActiveSupport::Concern

ee/app/controllers/concerns/ee/service_params.rb

+# frozen_string_literal: true
+
 module EE
   module ServiceParams
     ALLOWED_PARAMS_EE = [

ee/app/controllers/concerns/issuable_links.rb

+# frozen_string_literal: true
+
 module IssuableLinks
   def index
     render json: issues

ee/app/controllers/concerns/safe_mirror_params.rb

+# frozen_string_literal: true
+
 module SafeMirrorParams
   extend ActiveSupport::Concern
 

ee/app/controllers/ee/admin/appearances_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Admin
     module AppearancesController

ee/app/controllers/ee/admin/application_settings_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Admin
     module ApplicationSettingsController

ee/app/controllers/ee/admin/applications_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Admin
     module ApplicationsController

ee/app/controllers/ee/admin/dashboard_controller.rb

+# frozen_string_literal: true
+
 # rubocop:disable Gitlab/ModuleWithInstanceVariables
 module EE
   module Admin

ee/app/controllers/ee/admin/groups_controller.rb

+# frozen_string_literal: true
+
 # rubocop:disable Gitlab/ModuleWithInstanceVariables
 module EE
   module Admin

ee/app/controllers/ee/admin/logs_controller.rb

+# frozen_string_literal: true
+
 module EE::Admin::LogsController
   include ::Gitlab::Utils::StrongMemoize
   extend ::Gitlab::Utils::Override

ee/app/controllers/ee/admin/users_controller.rb

+# frozen_string_literal: true
+
 # rubocop:disable Gitlab/ModuleWithInstanceVariables
 module EE
   module Admin

ee/app/controllers/ee/boards/boards_controller.rb

+# frozen_string_literal: true
+
 # Shared actions between Groups::BoardsController and Projects::BoardsController
 module EE
   module Boards

ee/app/controllers/ee/boards/lists_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Boards
     module ListsController

ee/app/controllers/ee/confirmations_controller.rb

+# frozen_string_literal: true
+
 module EE
   module ConfirmationsController
     include EE::Audit::Changes

ee/app/controllers/ee/groups/application_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Groups
     module ApplicationController

ee/app/controllers/ee/groups/group_members_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Groups
     module GroupMembersController

ee/app/controllers/ee/groups/milestones_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Groups
     module MilestonesController

ee/app/controllers/ee/groups_controller.rb

+# frozen_string_literal: true
+
 module EE
   module GroupsController
     extend ActiveSupport::Concern

ee/app/controllers/ee/import/github_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Import
     module GithubController

ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Ldap
     module OmniauthCallbacksController

ee/app/controllers/ee/omniauth_callbacks_controller.rb

+# frozen_string_literal: true
+
 module EE
   module OmniauthCallbacksController
     extend ::Gitlab::Utils::Override

ee/app/controllers/ee/passwords_controller.rb

+# frozen_string_literal: true
+
 module EE
   module PasswordsController
     extend ActiveSupport::Concern

ee/app/controllers/ee/projects/clusters_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module ClustersController

ee/app/controllers/ee/projects/environments_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module EnvironmentsController

ee/app/controllers/ee/projects/git_http_client_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module GitHttpClientController

ee/app/controllers/ee/projects/git_http_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module GitHttpController

ee/app/controllers/ee/projects/lfs_api_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module LfsApiController

ee/app/controllers/ee/projects/merge_requests/application_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module MergeRequests

ee/app/controllers/ee/projects/merge_requests_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module MergeRequestsController

ee/app/controllers/ee/projects/mirrors_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module MirrorsController

ee/app/controllers/ee/projects/pipelines_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module PipelinesController

ee/app/controllers/ee/projects/prometheus/metrics_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module Prometheus

ee/app/controllers/ee/projects/settings/integrations_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module Settings

ee/app/controllers/ee/projects/settings/repository_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module Settings

ee/app/controllers/ee/projects/variables_controller.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module VariablesController

ee/app/controllers/ee/projects_controller.rb

+# frozen_string_literal: true
+
 module EE
   module ProjectsController
     extend ::Gitlab::Utils::Override

ee/app/controllers/ee/registrations_controller.rb

+# frozen_string_literal: true
+
 module EE
   module RegistrationsController
     extend ActiveSupport::Concern

ee/app/controllers/ee/sent_notifications_controller.rb

+# frozen_string_literal: true
+
 module EE
   module SentNotificationsController
     extend ::Gitlab::Utils::Override

ee/app/controllers/ee/sessions_controller.rb

+# frozen_string_literal: true
+
 module EE
   module SessionsController
     extend ActiveSupport::Concern

ee/app/controllers/ee/users_controller.rb

+# frozen_string_literal: true
+
 module EE
   module UsersController
     def available_templates

ee/app/controllers/groups/analytics_controller.rb

+# frozen_string_literal: true
+
 class Groups::AnalyticsController < Groups::ApplicationController
   before_action :group
   before_action :check_contribution_analytics_available!

ee/app/controllers/groups/audit_events_controller.rb

+# frozen_string_literal: true
+
 class Groups::AuditEventsController < Groups::ApplicationController
   before_action :authorize_admin_group!
   before_action :check_audit_events_available!

ee/app/controllers/groups/autocomplete_sources_controller.rb

+# frozen_string_literal: true
+
 class Groups::AutocompleteSourcesController < Groups::ApplicationController
   before_action :load_autocomplete_service, except: [:members]
 

ee/app/controllers/groups/billings_controller.rb

+# frozen_string_literal: true
+
 class Groups::BillingsController < Groups::ApplicationController
   before_action :authorize_admin_group!
   before_action :verify_namespace_plan_check_enabled

ee/app/controllers/groups/epic_issues_controller.rb

+# frozen_string_literal: true
+
 class Groups::EpicIssuesController < Groups::EpicsController
   include IssuableLinks
 

ee/app/controllers/groups/epics/notes_controller.rb

+# frozen_string_literal: true
+
 class Groups::Epics::NotesController < Groups::ApplicationController
   include NotesActions
   include NotesHelper

ee/app/controllers/groups/epics_controller.rb

+# frozen_string_literal: true
+
 class Groups::EpicsController < Groups::ApplicationController
   include IssuableActions
   include IssuableCollections

ee/app/controllers/groups/hooks_controller.rb

+# frozen_string_literal: true
+
 class Groups::HooksController < Groups::ApplicationController
   include HooksExecution
 

ee/app/controllers/groups/ldap_group_links_controller.rb

+# frozen_string_literal: true
+
 class Groups::LdapGroupLinksController < Groups::ApplicationController
   before_action :group
   before_action :require_ldap_enabled

ee/app/controllers/groups/ldaps_controller.rb

+# frozen_string_literal: true
+
 class Groups::LdapsController < Groups::ApplicationController
   before_action :group
   before_action :authorize_admin_group!

ee/app/controllers/groups/omniauth_callbacks_controller.rb

+# frozen_string_literal: true
+
 class Groups::OmniauthCallbacksController < OmniauthCallbacksController
   extend ::Gitlab::Utils::Override
 

ee/app/controllers/groups/pipeline_quota_controller.rb

+# frozen_string_literal: true
+
 class Groups::PipelineQuotaController < Groups::ApplicationController
   before_action :authorize_admin_group!
   before_action :validate_shared_runner_minutes_support!

ee/app/controllers/groups/roadmap_controller.rb

+# frozen_string_literal: true
+
 module Groups
   class RoadmapController < Groups::ApplicationController
     include IssuableCollections

ee/app/controllers/groups/saml_providers_controller.rb

+# frozen_string_literal: true
+
 class Groups::SamlProvidersController < Groups::ApplicationController
   before_action :require_top_level_group
   before_action :authorize_manage_saml!

ee/app/controllers/groups/sso_controller.rb

+# frozen_string_literal: true
+
 class Groups::SsoController < Groups::ApplicationController
   skip_before_action :group
   before_action :unauthenticated_group

ee/app/controllers/groups/todos_controller.rb

+# frozen_string_literal: true
+
 class Groups::TodosController < Groups::ApplicationController
   include Gitlab::Utils::StrongMemoize
   include TodosActions

ee/app/controllers/oauth/geo_auth_controller.rb

+# frozen_string_literal: true
+
 class Oauth::GeoAuthController < ActionController::Base
   rescue_from Gitlab::Geo::OauthApplicationUndefinedError, with: :undefined_oauth_application
   rescue_from OAuth2::Error, with: :auth

ee/app/controllers/oauth/jira/authorizations_controller.rb

+# frozen_string_literal: true
+
 # This controller's role is to mimic and rewire the GitLab OAuth
 # flow routes for Jira DVCS integration.
 # See https://gitlab.com/gitlab-org/gitlab-ee/issues/2381

ee/app/controllers/omniauth_kerberos_spnego_controller.rb

+# frozen_string_literal: true
+
 class OmniauthKerberosSpnegoController < ApplicationController
   include KerberosSpnegoHelper
 

ee/app/controllers/profiles/billings_controller.rb

+# frozen_string_literal: true
+
 class Profiles::BillingsController < Profiles::ApplicationController
   before_action :verify_namespace_plan_check_enabled
 

ee/app/controllers/profiles/pipeline_quota_controller.rb

+# frozen_string_literal: true
+
 class Profiles::PipelineQuotaController < Profiles::ApplicationController
   def index
     @namespace = current_user.namespace

ee/app/controllers/profiles/slacks_controller.rb

+# frozen_string_literal: true
+
 class Profiles::SlacksController < Profiles::ApplicationController
   include ServicesHelper
 

ee/app/controllers/projects/approver_groups_controller.rb

+# frozen_string_literal: true
+
 class Projects::ApproverGroupsController < Projects::ApplicationController
   before_action :authorize_for_subject!
 

ee/app/controllers/projects/approvers_controller.rb

+# frozen_string_literal: true
+
 class Projects::ApproversController < Projects::ApplicationController
   before_action :authorize_for_subject!
 

ee/app/controllers/projects/audit_events_controller.rb

+# frozen_string_literal: true
+
 class Projects::AuditEventsController < Projects::ApplicationController
   include LicenseHelper
 

ee/app/controllers/projects/feature_flags_controller.rb

+# frozen_string_literal: true
+
 class Projects::FeatureFlagsController < Projects::ApplicationController
   respond_to :html
 

ee/app/controllers/projects/issue_links_controller.rb

+# frozen_string_literal: true
+
 module Projects
   class IssueLinksController < Projects::ApplicationController
     include IssuableLinks

ee/app/controllers/projects/packages/packages_controller.rb

+# frozen_string_literal: true
+
 module Projects
   module Packages
     class PackagesController < ApplicationController

ee/app/controllers/projects/path_locks_controller.rb

+# frozen_string_literal: true
+
 class Projects::PathLocksController < Projects::ApplicationController
   include PathLocksHelper
   include ExtractsPath

ee/app/controllers/projects/push_rules_controller.rb

+# frozen_string_literal: true
+
 class Projects::PushRulesController < Projects::ApplicationController
   include RepositorySettingsRedirect
 

ee/app/controllers/projects/security/dashboard_controller.rb

+# frozen_string_literal: true
+
 module Projects
   module Security
     class DashboardController < Projects::ApplicationController

ee/app/controllers/projects/service_desk_controller.rb

+# frozen_string_literal: true
+
 class Projects::ServiceDeskController < Projects::ApplicationController
   before_action :authorize_admin_project!
 

ee/app/controllers/projects/settings/slacks_controller.rb

+# frozen_string_literal: true
+
 module Projects
   module Settings
     class SlacksController < Projects::ApplicationController

ee/app/controllers/projects/vulnerability_feedback_controller.rb

+# frozen_string_literal: true
+
 class Projects::VulnerabilityFeedbackController < Projects::ApplicationController
   before_action :vulnerability_feedback, only: [:destroy]
   before_action :authorize_read_vulnerability_feedback!, only: [:index]

ee/app/controllers/unsubscribes_controller.rb

+# frozen_string_literal: true
+
 class UnsubscribesController < ApplicationController
   skip_before_action :authenticate_user!
 

ee/app/finders/boards/milestones_finder.rb

+# frozen_string_literal: true
+
 module Boards
   class MilestonesFinder
     def initialize(board, current_user = nil)

ee/app/finders/boards/users_finder.rb

+# frozen_string_literal: true
+
 module Boards
   class UsersFinder
     def initialize(board, current_user = nil)

ee/app/finders/ee/issues_finder.rb

+# frozen_string_literal: true
+
 module EE
   module IssuesFinder
     extend ActiveSupport::Concern

ee/app/finders/ee/license_template_finder.rb

+# frozen_string_literal: true
+
 module EE
   module LicenseTemplateFinder
     extend ::Gitlab::Utils::Override

ee/app/finders/ee/notes_finder.rb

+# frozen_string_literal: true
+
 module EE
   module NotesFinder
     extend ActiveSupport::Concern

ee/app/finders/ee/template_finder.rb

+# frozen_string_literal: true
+
 module EE
   module TemplateFinder
     extend ::Gitlab::Utils::Override

ee/app/finders/epics_finder.rb

+# frozen_string_literal: true
+
 class EpicsFinder < IssuableFinder
   def self.scalar_params
     @scalar_params ||= %i[

ee/app/finders/geo/attachment_registry_finder.rb

+# frozen_string_literal: true
+
 module Geo
   class AttachmentRegistryFinder < FileRegistryFinder
     def syncable

ee/app/finders/geo/expire_uploads_finder.rb

+# frozen_string_literal: true
+
 module Geo
   class ExpireUploadsFinder
     def find_project_uploads(project)

ee/app/finders/geo/file_registry_finder.rb

+# frozen_string_literal: true
+
 module Geo
   class FileRegistryFinder < RegistryFinder
     # @abstract Subclass is expected to implement the declared methods

ee/app/finders/geo/job_artifact_registry_finder.rb

+# frozen_string_literal: true
+
 module Geo
   class JobArtifactRegistryFinder < RegistryFinder
     def count_syncable

ee/app/finders/geo/lfs_object_registry_finder.rb

+# frozen_string_literal: true
+
 module Geo
   class LfsObjectRegistryFinder < FileRegistryFinder
     def count_syncable

ee/app/finders/geo/project_registry_finder.rb

+# frozen_string_literal: true
+
 module Geo
   class ProjectRegistryFinder < RegistryFinder
     def count_projects

ee/app/finders/geo/registry_finder.rb

+# frozen_string_literal: true
+
 module Geo
   class RegistryFinder
     attr_reader :current_node

ee/app/finders/geo/repository_verification_finder.rb

+# frozen_string_literal: true
+
 module Geo
   class RepositoryVerificationFinder
     def initialize(shard_name: nil)

ee/app/finders/log_finder.rb

+# frozen_string_literal: true
+
 class LogFinder
   PER_PAGE = 25
   ENTITY_COLUMN_TYPES = {