Commit b327a93e authored by Daniel Paul Searles's avatar Daniel Paul Searles

Fix the default sha for bin/secpick

Why:

* The shell command to read the current sha has an ending newline that
  should be stripped.

This change addresses the need by:

* strip whitespace from sha when reading the current sha
* refactor original_branch to strip whitespace at the point it could be
  introduced
parent 4dc50578
......@@ -25,12 +25,8 @@ module Secpick
@options[:try] == true
end
def original_branch
@options[:branch].strip
end
def source_branch
branch = "#{original_branch}-#{@options[:version]}"
branch = "#{@options[:branch]}-#{@options[:version]}"
branch.prepend("#{BRANCH_PREFIX}-") unless branch.start_with?("#{BRANCH_PREFIX}-")
branch.freeze
end
......@@ -44,7 +40,7 @@ module Secpick
"git checkout -B #{source_branch} #{@options[:remote]}/#{stable_branch} --no-track",
"git cherry-pick #{@options[:sha]}",
"git push #{@options[:remote]} #{source_branch}",
"git checkout #{original_branch}"]
"git checkout #{@options[:branch]}"]
end
def gitlab_params
......@@ -121,8 +117,8 @@ module Secpick
parser.parse!
options[:sha] ||= `git rev-parse HEAD`
options[:branch] ||= `git rev-parse --abbrev-ref HEAD`
options[:sha] ||= `git rev-parse HEAD`.strip
options[:branch] ||= `git rev-parse --abbrev-ref HEAD`.strip
options[:remote] ||= DEFAULT_REMOTE
nil_options = options.select {|_, v| v.nil? }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment