Merge branch 'bvl-transient-failure-health-controller-spec' into 'master'

Don't memoize storage configuration on `FsShardsCheck`

Closes #38140

See merge request gitlab-org/gitlab-ce!14419

lib/gitlab/health_checks/fs_shards_check.rb

@@ -58,11 +58,11 @@ module Gitlab
         end
 
         def repository_storages
-          @repository_storage ||= storages_paths.keys
+          storages_paths.keys
         end
 
         def storages_paths
-          @storage_paths ||= Gitlab.config.repositories.storages
+          Gitlab.config.repositories.storages
         end
 
         def exec_with_timeout(cmd_args, *args, &block)