Commit b446f651 authored by Huzaifa Iftikhar's avatar Huzaifa Iftikhar

Fix EmptyLineAfterFinalLetItBe offenses in spec/services/issues

Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/325836
parent eedcc6be
...@@ -1388,12 +1388,6 @@ RSpec/EmptyLineAfterFinalLetItBe: ...@@ -1388,12 +1388,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
- spec/services/incident_management/pager_duty/process_webhook_service_spec.rb - spec/services/incident_management/pager_duty/process_webhook_service_spec.rb
- spec/services/integrations/test/project_service_spec.rb - spec/services/integrations/test/project_service_spec.rb
- spec/services/issuable/bulk_update_service_spec.rb - spec/services/issuable/bulk_update_service_spec.rb
- spec/services/issues/build_service_spec.rb
- spec/services/issues/clone_service_spec.rb
- spec/services/issues/create_service_spec.rb
- spec/services/issues/export_csv_service_spec.rb
- spec/services/issues/move_service_spec.rb
- spec/services/issues/related_branches_service_spec.rb
- spec/services/jira_connect/sync_service_spec.rb - spec/services/jira_connect/sync_service_spec.rb
- spec/services/jira_import/start_import_service_spec.rb - spec/services/jira_import/start_import_service_spec.rb
- spec/services/jira_import/users_importer_spec.rb - spec/services/jira_import/users_importer_spec.rb
......
...@@ -6,6 +6,7 @@ RSpec.describe Issues::BuildService do ...@@ -6,6 +6,7 @@ RSpec.describe Issues::BuildService do
let_it_be(:project) { create(:project, :repository) } let_it_be(:project) { create(:project, :repository) }
let_it_be(:developer) { create(:user) } let_it_be(:developer) { create(:user) }
let_it_be(:guest) { create(:user) } let_it_be(:guest) { create(:user) }
let(:user) { developer } let(:user) { developer }
before_all do before_all do
......
...@@ -242,6 +242,7 @@ RSpec.describe Issues::CloneService do ...@@ -242,6 +242,7 @@ RSpec.describe Issues::CloneService do
context 'issue with a design', :clean_gitlab_redis_shared_state do context 'issue with a design', :clean_gitlab_redis_shared_state do
let_it_be(:new_project) { create(:project) } let_it_be(:new_project) { create(:project) }
let!(:design) { create(:design, :with_lfs_file, issue: old_issue) } let!(:design) { create(:design, :with_lfs_file, issue: old_issue) }
let!(:note) { create(:diff_note_on_design, noteable: design, issue: old_issue, project: old_issue.project) } let!(:note) { create(:diff_note_on_design, noteable: design, issue: old_issue, project: old_issue.project) }
let(:subject) { clone_service.execute(old_issue, new_project) } let(:subject) { clone_service.execute(old_issue, new_project) }
......
...@@ -9,6 +9,7 @@ RSpec.describe Issues::CreateService do ...@@ -9,6 +9,7 @@ RSpec.describe Issues::CreateService do
describe '#execute' do describe '#execute' do
let_it_be(:assignee) { create(:user) } let_it_be(:assignee) { create(:user) }
let_it_be(:milestone) { create(:milestone, project: project) } let_it_be(:milestone) { create(:milestone, project: project) }
let(:issue) { described_class.new(project, user, opts).execute } let(:issue) { described_class.new(project, user, opts).execute }
context 'when params are valid' do context 'when params are valid' do
......
...@@ -8,6 +8,7 @@ RSpec.describe Issues::ExportCsvService do ...@@ -8,6 +8,7 @@ RSpec.describe Issues::ExportCsvService do
let_it_be(:project) { create(:project, :public, group: group) } let_it_be(:project) { create(:project, :public, group: group) }
let_it_be(:issue) { create(:issue, project: project, author: user) } let_it_be(:issue) { create(:issue, project: project, author: user) }
let_it_be(:bad_issue) { create(:issue, project: project, author: user) } let_it_be(:bad_issue) { create(:issue, project: project, author: user) }
subject { described_class.new(Issue.all, project) } subject { described_class.new(Issue.all, project) }
it 'renders csv to string' do it 'renders csv to string' do
......
...@@ -206,6 +206,7 @@ RSpec.describe Issues::MoveService do ...@@ -206,6 +206,7 @@ RSpec.describe Issues::MoveService do
context 'issue with a design', :clean_gitlab_redis_shared_state do context 'issue with a design', :clean_gitlab_redis_shared_state do
let_it_be(:new_project) { create(:project) } let_it_be(:new_project) { create(:project) }
let!(:design) { create(:design, :with_lfs_file, issue: old_issue) } let!(:design) { create(:design, :with_lfs_file, issue: old_issue) }
let!(:note) { create(:diff_note_on_design, noteable: design, issue: old_issue, project: old_issue.project) } let!(:note) { create(:diff_note_on_design, noteable: design, issue: old_issue, project: old_issue.project) }
let(:subject) { move_service.execute(old_issue, new_project) } let(:subject) { move_service.execute(old_issue, new_project) }
......
...@@ -5,6 +5,7 @@ require 'spec_helper' ...@@ -5,6 +5,7 @@ require 'spec_helper'
RSpec.describe Issues::RelatedBranchesService do RSpec.describe Issues::RelatedBranchesService do
let_it_be(:developer) { create(:user) } let_it_be(:developer) { create(:user) }
let_it_be(:issue) { create(:issue) } let_it_be(:issue) { create(:issue) }
let(:user) { developer } let(:user) { developer }
subject { described_class.new(issue.project, user) } subject { described_class.new(issue.project, user) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment