Merge branch 'fguibert/clean-up-unused-board-actions' into 'master'

Boards - Clean up unused actions [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!61207

app/assets/javascripts/boards/stores/actions.js

@@ -40,11 +40,6 @@ import issueSetMilestoneMutation from '../graphql/issue_set_milestone.mutation.g
 import listsIssuesQuery from '../graphql/lists_issues.query.graphql';
 import * as types from './mutation_types';
 
-const notImplemented = () => {
-  /* eslint-disable-next-line @gitlab/require-i18n-strings */
-  throw new Error('Not implemented!');
-};
-
 export const gqlClient = createGqClient(
   {},
   {
@@ -737,28 +732,4 @@ export default {
   unsetError: ({ commit }) => {
     commit(types.SET_ERROR, undefined);
   },
-
-  fetchBacklog: () => {
-    notImplemented();
-  },
-
-  bulkUpdateIssues: () => {
-    notImplemented();
-  },
-
-  fetchIssue: () => {
-    notImplemented();
-  },
-
-  toggleIssueSubscription: () => {
-    notImplemented();
-  },
-
-  showPage: () => {
-    notImplemented();
-  },
-
-  toggleEmptyState: () => {
-    notImplemented();
-  },
 };

app/assets/javascripts/boards/stores/mutation_types.js

@@ -9,9 +9,7 @@ export const GENERATE_DEFAULT_LISTS_FAILURE = 'GENERATE_DEFAULT_LISTS_FAILURE';
 export const RECEIVE_BOARD_LISTS_SUCCESS = 'RECEIVE_BOARD_LISTS_SUCCESS';
 export const RECEIVE_BOARD_LISTS_FAILURE = 'RECEIVE_BOARD_LISTS_FAILURE';
 export const SHOW_PROMOTION_LIST = 'SHOW_PROMOTION_LIST';
-export const REQUEST_ADD_LIST = 'REQUEST_ADD_LIST';
 export const RECEIVE_ADD_LIST_SUCCESS = 'RECEIVE_ADD_LIST_SUCCESS';
-export const RECEIVE_ADD_LIST_ERROR = 'RECEIVE_ADD_LIST_ERROR';
 export const MOVE_LIST = 'MOVE_LIST';
 export const UPDATE_LIST_FAILURE = 'UPDATE_LIST_FAILURE';
 export const TOGGLE_LIST_COLLAPSED = 'TOGGLE_LIST_COLLAPSED';
@@ -20,19 +18,11 @@ export const REMOVE_LIST_FAILURE = 'REMOVE_LIST_FAILURE';
 export const REQUEST_ITEMS_FOR_LIST = 'REQUEST_ITEMS_FOR_LIST';
 export const RECEIVE_ITEMS_FOR_LIST_FAILURE = 'RECEIVE_ITEMS_FOR_LIST_FAILURE';
 export const RECEIVE_ITEMS_FOR_LIST_SUCCESS = 'RECEIVE_ITEMS_FOR_LIST_SUCCESS';
-export const REQUEST_ADD_ISSUE = 'REQUEST_ADD_ISSUE';
-export const RECEIVE_ADD_ISSUE_SUCCESS = 'RECEIVE_ADD_ISSUE_SUCCESS';
-export const RECEIVE_ADD_ISSUE_ERROR = 'RECEIVE_ADD_ISSUE_ERROR';
 export const UPDATE_BOARD_ITEM = 'UPDATE_BOARD_ITEM';
 export const REMOVE_BOARD_ITEM = 'REMOVE_BOARD_ITEM';
-export const REQUEST_UPDATE_ISSUE = 'REQUEST_UPDATE_ISSUE';
 export const MUTATE_ISSUE_SUCCESS = 'MUTATE_ISSUE_SUCCESS';
-export const RECEIVE_UPDATE_ISSUE_SUCCESS = 'RECEIVE_UPDATE_ISSUE_SUCCESS';
-export const RECEIVE_UPDATE_ISSUE_ERROR = 'RECEIVE_UPDATE_ISSUE_ERROR';
 export const ADD_BOARD_ITEM_TO_LIST = 'ADD_BOARD_ITEM_TO_LIST';
 export const REMOVE_BOARD_ITEM_FROM_LIST = 'REMOVE_BOARD_ITEM_FROM_LIST';
-export const SET_CURRENT_PAGE = 'SET_CURRENT_PAGE';
-export const TOGGLE_EMPTY_STATE = 'TOGGLE_EMPTY_STATE';
 export const SET_ACTIVE_ID = 'SET_ACTIVE_ID';
 export const UPDATE_BOARD_ITEM_BY_ID = 'UPDATE_BOARD_ITEM_BY_ID';
 export const SET_ASSIGNEE_LOADING = 'SET_ASSIGNEE_LOADING';

app/assets/javascripts/boards/stores/mutations.js

@@ -6,11 +6,6 @@ import { formatIssue } from '../boards_util';
 import { issuableTypes } from '../constants';
 import * as mutationTypes from './mutation_types';
 
-const notImplemented = () => {
-  /* eslint-disable-next-line @gitlab/require-i18n-strings */
-  throw new Error('Not implemented!');
-};
-
 const updateListItemsCount = ({ state, listId, value }) => {
   const list = state.boardLists[listId];
   if (state.issuableType === issuableTypes.epic) {
@@ -94,18 +89,10 @@ export default {
     state.error = s__('Boards|An error occurred while generating lists. Please reload the page.');
   },
 
-  [mutationTypes.REQUEST_ADD_LIST]: () => {
-    notImplemented();
-  },
-
   [mutationTypes.RECEIVE_ADD_LIST_SUCCESS]: (state, list) => {
     Vue.set(state.boardLists, list.id, list);
   },
 
-  [mutationTypes.RECEIVE_ADD_LIST_ERROR]: () => {
-    notImplemented();
-  },
-
   [mutationTypes.MOVE_LIST]: (state, { movedList, listAtNewIndex }) => {
     const { boardLists } = state;
     Vue.set(boardLists, movedList.id, movedList);
@@ -172,35 +159,11 @@ export default {
     state.isSettingAssignees = isLoading;
   },
 
-  [mutationTypes.REQUEST_ADD_ISSUE]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_ADD_ISSUE_SUCCESS]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_ADD_ISSUE_ERROR]: () => {
-    notImplemented();
-  },
-
   [mutationTypes.MUTATE_ISSUE_SUCCESS]: (state, { issue }) => {
     const issueId = getIdFromGraphQLId(issue.id);
     Vue.set(state.boardItems, issueId, formatIssue({ ...issue, id: issueId }));
   },
 
-  [mutationTypes.REQUEST_UPDATE_ISSUE]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_UPDATE_ISSUE_SUCCESS]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_UPDATE_ISSUE_ERROR]: () => {
-    notImplemented();
-  },
-
   [mutationTypes.ADD_BOARD_ITEM_TO_LIST]: (
     state,
     { itemId, listId, moveBeforeId, moveAfterId, atIndex },
@@ -220,14 +183,6 @@ export default {
     Vue.delete(state.boardItems, itemId);
   },
 
-  [mutationTypes.SET_CURRENT_PAGE]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.TOGGLE_EMPTY_STATE]: () => {
-    notImplemented();
-  },
-
   [mutationTypes.REQUEST_GROUP_PROJECTS]: (state, fetchNext) => {
     Vue.set(state, 'groupProjectsFlags', {
       [fetchNext ? 'isLoadingMore' : 'isLoading']: true,

ee/app/assets/javascripts/boards/stores/actions.js

@@ -52,11 +52,6 @@ import updateEpicLabelsMutation from '../graphql/update_epic_labels.mutation.gra
 import boardsStoreEE from './boards_store_ee';
 import * as types from './mutation_types';
 
-const notImplemented = () => {
-  /* eslint-disable-next-line @gitlab/require-i18n-strings */
-  throw new Error('Not implemented!');
-};
-
 const fetchAndFormatListIssues = (state, extraVariables) => {
   const { fullPath, boardId, boardType, filterParams } = state;
 
@@ -269,22 +264,6 @@ export default {
     });
   },
 
-  fetchAllBoards: () => {
-    notImplemented();
-  },
-
-  fetchRecentBoards: () => {
-    notImplemented();
-  },
-
-  deleteBoard: () => {
-    notImplemented();
-  },
-
-  updateIssueWeight: () => {
-    notImplemented();
-  },
-
   fetchItemsForList: (
     { state, commit, getters },
     { listId, fetchNext = false, noEpicIssues = false, forSwimlanes = false },

ee/app/assets/javascripts/boards/stores/mutation_types.js

 export * from '~/boards/stores/mutation_types';
 
-export const REQUEST_AVAILABLE_BOARDS = 'REQUEST_AVAILABLE_BOARDS';
-export const RECEIVE_AVAILABLE_BOARDS_SUCCESS = 'RECEIVE_AVAILABLE_BOARDS_SUCCESS';
-export const RECEIVE_AVAILABLE_BOARDS_ERROR = 'RECEIVE_AVAILABLE_BOARDS_ERROR';
-export const REQUEST_RECENT_BOARDS = 'REQUEST_RECENT_BOARDS';
-export const RECEIVE_RECENT_BOARDS_SUCCESS = 'RECEIVE_RECENT_BOARDS_SUCCESS';
-export const RECEIVE_RECENT_BOARDS_ERROR = 'RECEIVE_RECENT_BOARDS_ERROR';
-export const REQUEST_REMOVE_BOARD = 'REQUEST_REMOVE_BOARD';
-export const RECEIVE_REMOVE_BOARD_SUCCESS = 'RECEIVE_REMOVE_BOARD_SUCCESS';
-export const RECEIVE_REMOVE_BOARD_ERROR = 'RECEIVE_REMOVE_BOARD_ERROR';
-export const TOGGLE_PROMOTION_STATE = 'TOGGLE_PROMOTION_STATE';
 export const TOGGLE_EPICS_SWIMLANES = 'TOGGLE_EPICS_SWIMLANES';
 export const SET_EPICS_SWIMLANES = 'SET_EPICS_SWIMLANES';
 export const DONE_LOADING_SWIMLANES_ITEMS = 'DONE_LOADING_SWIMLANES_ITEMS';

ee/app/assets/javascripts/boards/stores/mutations.js

@@ -7,56 +7,12 @@ import { s__, __ } from '~/locale';
 import { ErrorMessages } from '../constants';
 import * as mutationTypes from './mutation_types';
 
-const notImplemented = () => {
-  /* eslint-disable-next-line @gitlab/require-i18n-strings */
-  throw new Error('Not implemented!');
-};
-
 export default {
   ...mutationsCE,
   [mutationTypes.SET_SHOW_LABELS]: (state, val) => {
     state.isShowingLabels = val;
   },
 
-  [mutationTypes.REQUEST_AVAILABLE_BOARDS]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_AVAILABLE_BOARDS_SUCCESS]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_AVAILABLE_BOARDS_ERROR]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.REQUEST_RECENT_BOARDS]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_RECENT_BOARDS_SUCCESS]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_RECENT_BOARDS_ERROR]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.REQUEST_REMOVE_BOARD]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_REMOVE_BOARD_SUCCESS]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.RECEIVE_REMOVE_BOARD_ERROR]: () => {
-    notImplemented();
-  },
-
-  [mutationTypes.TOGGLE_PROMOTION_STATE]: () => {
-    notImplemented();
-  },
   [mutationTypes.UPDATE_LIST_SUCCESS]: (state, { listId, list }) => {
     Vue.set(state.boardLists, listId, list);
   },

ee/spec/frontend/boards/stores/actions_spec.js

@@ -28,12 +28,6 @@ import {
 
 Vue.use(Vuex);
 
-const expectNotImplemented = (action) => {
-  it('is not implemented', () => {
-    expect(action).toThrow(new Error('Not implemented!'));
-  });
-};
-
 let mock;
 
 beforeEach(() => {
@@ -528,22 +522,6 @@ describe('updateListWipLimit', () => {
   });
 });
 
-describe('fetchAllBoards', () => {
-  expectNotImplemented(actions.fetchAllBoards);
-});
-
-describe('fetchRecentBoards', () => {
-  expectNotImplemented(actions.fetchRecentBoards);
-});
-
-describe('deleteBoard', () => {
-  expectNotImplemented(actions.deleteBoard);
-});
-
-describe('updateIssueWeight', () => {
-  expectNotImplemented(actions.updateIssueWeight);
-});
-
 describe('toggleEpicSwimlanes', () => {
   it('should commit mutation TOGGLE_EPICS_SWIMLANES', () => {
     const startURl = `${TEST_HOST}/groups/gitlab-org/-/boards/1?group_by=epic`;

ee/spec/frontend/boards/stores/mutations_spec.js

 import mutations from 'ee/boards/stores/mutations';
 import { mockEpics, mockEpic, mockLists } from '../mock_data';
 
-const expectNotImplemented = (action) => {
-  it('is not implemented', () => {
-    expect(action).toThrow(new Error('Not implemented!'));
-  });
-};
-
 const initialBoardListsState = {
   'gid://gitlab/List/1': mockLists[0],
   'gid://gitlab/List/2': mockLists[1],
@@ -31,46 +25,6 @@ describe('SET_SHOW_LABELS', () => {
   });
 });
 
-describe('REQUEST_AVAILABLE_BOARDS', () => {
-  expectNotImplemented(mutations.REQUEST_AVAILABLE_BOARDS);
-});
-
-describe('RECEIVE_AVAILABLE_BOARDS_SUCCESS', () => {
-  expectNotImplemented(mutations.RECEIVE_AVAILABLE_BOARDS_SUCCESS);
-});
-
-describe('RECEIVE_AVAILABLE_BOARDS_ERROR', () => {
-  expectNotImplemented(mutations.RECEIVE_AVAILABLE_BOARDS_ERROR);
-});
-
-describe('REQUEST_RECENT_BOARDS', () => {
-  expectNotImplemented(mutations.REQUEST_RECENT_BOARDS);
-});
-
-describe('RECEIVE_RECENT_BOARDS_SUCCESS', () => {
-  expectNotImplemented(mutations.RECEIVE_RECENT_BOARDS_SUCCESS);
-});
-
-describe('RECEIVE_RECENT_BOARDS_ERROR', () => {
-  expectNotImplemented(mutations.RECEIVE_RECENT_BOARDS_ERROR);
-});
-
-describe('REQUEST_REMOVE_BOARD', () => {
-  expectNotImplemented(mutations.REQUEST_REMOVE_BOARD);
-});
-
-describe('RECEIVE_REMOVE_BOARD_SUCCESS', () => {
-  expectNotImplemented(mutations.RECEIVE_REMOVE_BOARD_SUCCESS);
-});
-
-describe('RECEIVE_REMOVE_BOARD_ERROR', () => {
-  expectNotImplemented(mutations.RECEIVE_REMOVE_BOARD_ERROR);
-});
-
-describe('TOGGLE_PROMOTION_STATE', () => {
-  expectNotImplemented(mutations.TOGGLE_PROMOTION_STATE);
-});
-
 describe('TOGGLE_EPICS_SWIMLANES', () => {
   it('toggles isShowingEpicsSwimlanes from true to false', () => {
     state = {

spec/frontend/boards/stores/actions_spec.js

@@ -40,12 +40,6 @@ import {
 
 jest.mock('~/flash');
 
-const expectNotImplemented = (action) => {
-  it('is not implemented', () => {
-    expect(action).toThrow(new Error('Not implemented!'));
-  });
-};
-
 // We need this helper to make sure projectPath is including
 // subgroups when the movIssue action is called.
 const getProjectPath = (path) => path.split('#')[0];
@@ -1825,27 +1819,3 @@ describe('unsetError', () => {
     });
   });
 });
-
-describe('fetchBacklog', () => {
-  expectNotImplemented(actions.fetchBacklog);
-});
-
-describe('bulkUpdateIssues', () => {
-  expectNotImplemented(actions.bulkUpdateIssues);
-});
-
-describe('fetchIssue', () => {
-  expectNotImplemented(actions.fetchIssue);
-});
-
-describe('toggleIssueSubscription', () => {
-  expectNotImplemented(actions.toggleIssueSubscription);
-});
-
-describe('showPage', () => {
-  expectNotImplemented(actions.showPage);
-});
-
-describe('toggleEmptyState', () => {
-  expectNotImplemented(actions.toggleEmptyState);
-});

spec/frontend/boards/stores/mutations_spec.js

@@ -13,12 +13,6 @@ import {
   mockList,
 } from '../mock_data';
 
-const expectNotImplemented = (action) => {
-  it('is not implemented', () => {
-    expect(action).toThrow(new Error('Not implemented!'));
-  });
-};
-
 describe('Board Store Mutations', () => {
   let state;
 
@@ -158,10 +152,6 @@ describe('Board Store Mutations', () => {
     });
   });
 
-  describe('REQUEST_ADD_LIST', () => {
-    expectNotImplemented(mutations.REQUEST_ADD_LIST);
-  });
-
   describe('RECEIVE_ADD_LIST_SUCCESS', () => {
     it('adds list to boardLists state', () => {
       mutations.RECEIVE_ADD_LIST_SUCCESS(state, mockLists[0]);
@@ -172,10 +162,6 @@ describe('Board Store Mutations', () => {
     });
   });
 
-  describe('RECEIVE_ADD_LIST_ERROR', () => {
-    expectNotImplemented(mutations.RECEIVE_ADD_LIST_ERROR);
-  });
-
   describe('MOVE_LIST', () => {
     it('updates boardLists state with reordered lists', () => {
       state = {
@@ -341,10 +327,6 @@ describe('Board Store Mutations', () => {
     });
   });
 
-  describe('REQUEST_ADD_ISSUE', () => {
-    expectNotImplemented(mutations.REQUEST_ADD_ISSUE);
-  });
-
   describe('UPDATE_BOARD_ITEM_BY_ID', () => {
     const issueId = '1';
     const prop = 'id';
@@ -386,14 +368,6 @@ describe('Board Store Mutations', () => {
     });
   });
 
-  describe('RECEIVE_ADD_ISSUE_SUCCESS', () => {
-    expectNotImplemented(mutations.RECEIVE_ADD_ISSUE_SUCCESS);
-  });
-
-  describe('RECEIVE_ADD_ISSUE_ERROR', () => {
-    expectNotImplemented(mutations.RECEIVE_ADD_ISSUE_ERROR);
-  });
-
   describe('MUTATE_ISSUE_SUCCESS', () => {
     it('updates issue in issues state', () => {
       const issues = {
@@ -434,18 +408,6 @@ describe('Board Store Mutations', () => {
     });
   });
 
-  describe('REQUEST_UPDATE_ISSUE', () => {
-    expectNotImplemented(mutations.REQUEST_UPDATE_ISSUE);
-  });
-
-  describe('RECEIVE_UPDATE_ISSUE_SUCCESS', () => {
-    expectNotImplemented(mutations.RECEIVE_UPDATE_ISSUE_SUCCESS);
-  });
-
-  describe('RECEIVE_UPDATE_ISSUE_ERROR', () => {
-    expectNotImplemented(mutations.RECEIVE_UPDATE_ISSUE_ERROR);
-  });
-
   describe('ADD_BOARD_ITEM_TO_LIST', () => {
     beforeEach(() => {
       setBoardsListsState();
@@ -540,14 +502,6 @@ describe('Board Store Mutations', () => {
     });
   });
 
-  describe('SET_CURRENT_PAGE', () => {
-    expectNotImplemented(mutations.SET_CURRENT_PAGE);
-  });
-
-  describe('TOGGLE_EMPTY_STATE', () => {
-    expectNotImplemented(mutations.TOGGLE_EMPTY_STATE);
-  });
-
   describe('REQUEST_GROUP_PROJECTS', () => {
     it('Should set isLoading in groupProjectsFlags to true in state when fetchNext is false', () => {
       mutations[types.REQUEST_GROUP_PROJECTS](state, false);