Merge branch 'vs-ee-migrate-deprecated-size-in-loading-icon' into 'master'

[EE] Replace deprecated GlLoadingIcon sizes in EE

See merge request gitlab-org/gitlab!29418

ee/app/assets/javascripts/approvals/components/app.vue

@@ -48,7 +48,7 @@ export default {
 
 <template>
   <div class="js-approval-rules">
-    <gl-loading-icon v-if="!hasLoaded" :size="2" />
+    <gl-loading-icon v-if="!hasLoaded" size="lg" />
     <template v-else>
       <div class="border-bottom">
         <slot name="rules"></slot>

ee/app/assets/javascripts/batch_comments/components/preview_dropdown.vue

@@ -96,7 +96,7 @@ export default {
             <preview-item :draft="draft" :is-last="isLast(index)" />
           </li>
         </ul>
-        <gl-loading-icon v-else :size="2" class="prepend-top-default append-bottom-default" />
+        <gl-loading-icon v-else size="lg" class="prepend-top-default append-bottom-default" />
       </div>
       <div class="dropdown-footer">
         <publish-button

ee/app/assets/javascripts/billings/components/subscription_table.vue

@@ -117,7 +117,7 @@ export default {
     <gl-loading-icon
       v-else-if="isLoading && !hasError"
       :label="s__('SubscriptionTable|Loading subscriptions')"
-      :size="3"
+      size="lg"
       class="prepend-top-10 append-bottom-10"
     />
   </div>

ee/app/assets/javascripts/clusters/components/environments.vue

@@ -168,6 +168,6 @@ export default {
       </template>
     </gl-table>
 
-    <gl-loading-icon v-if="isFetching" :size="2" class="mt-3" />
+    <gl-loading-icon v-if="isFetching" size="lg" class="mt-3" />
   </div>
 </template>

ee/app/assets/javascripts/ide/components/terminal/empty_state.vue

@@ -43,7 +43,7 @@ export default {
   <div class="text-center">
     <div v-if="illustrationPath" class="svg-content svg-130"><img :src="illustrationPath" /></div>
     <h4>{{ __('Web Terminal') }}</h4>
-    <gl-loading-icon v-if="isLoading" :size="2" class="prepend-top-default" />
+    <gl-loading-icon v-if="isLoading" size="lg" class="prepend-top-default" />
     <template v-else>
       <p>{{ __('Run tests against your code live using the Web Terminal') }}</p>
       <p>

ee/app/assets/javascripts/issues_analytics/components/issues_analytics.vue

@@ -142,7 +142,7 @@ export default {
 </script>
 <template>
   <div class="issues-analytics-wrapper" data-qa-selector="issues_analytics_wrapper">
-    <gl-loading-icon v-if="loading" :size="4" class="issues-analytics-loading" />
+    <gl-loading-icon v-if="loading" size="xl" class="issues-analytics-loading" />
 
     <div v-if="showChart" class="issues-analytics-chart">
       <h4 class="chart-title">{{ s__('IssuesAnalytics|Issues created per month') }}</h4>

ee/spec/frontend/billings/components/__snapshots__/subscription_table_spec.js.snap

@@ -50,7 +50,7 @@ exports[`SubscriptionTable component when created matches the snapshot 1`] = `
     class="prepend-top-10 append-bottom-10"
     color="orange"
     label="Loading subscriptions"
-    size="3"
+    size="lg"
   />
 </div>
 `;