Commit b6762723 authored by Marcel van Remmerden's avatar Marcel van Remmerden

Add title and tooltip to diff preferences dropdown

Changelog: added
parent c9a19a21
<script> <script>
import { GlButtonGroup, GlButton, GlDropdown, GlFormCheckbox } from '@gitlab/ui'; import {
GlButtonGroup,
GlButton,
GlDropdown,
GlFormCheckbox,
GlTooltipDirective,
} from '@gitlab/ui';
import { mapActions, mapGetters, mapState } from 'vuex'; import { mapActions, mapGetters, mapState } from 'vuex';
import { SETTINGS_DROPDOWN } from '../i18n'; import { SETTINGS_DROPDOWN } from '../i18n';
export default { export default {
i18n: SETTINGS_DROPDOWN, i18n: SETTINGS_DROPDOWN,
directives: {
GlTooltip: GlTooltipDirective,
},
components: { components: {
GlButtonGroup, GlButtonGroup,
GlButton, GlButton,
...@@ -35,9 +44,13 @@ export default { ...@@ -35,9 +44,13 @@ export default {
<template> <template>
<gl-dropdown <gl-dropdown
v-gl-tooltip
icon="settings" icon="settings"
:text="__('Diff view settings')" :title="$options.i18n.preferences"
:text="$options.i18n.preferences"
:text-sr-only="true" :text-sr-only="true"
:aria-label="$options.i18n.preferences"
:header-text="$options.i18n.preferences"
toggle-class="js-show-diff-settings" toggle-class="js-show-diff-settings"
right right
> >
......
...@@ -23,4 +23,5 @@ export const DIFF_FILE = { ...@@ -23,4 +23,5 @@ export const DIFF_FILE = {
export const SETTINGS_DROPDOWN = { export const SETTINGS_DROPDOWN = {
whitespace: __('Show whitespace changes'), whitespace: __('Show whitespace changes'),
fileByFile: __('Show one file at a time'), fileByFile: __('Show one file at a time'),
preferences: __('Preferences'),
}; };
...@@ -11459,9 +11459,6 @@ msgstr "" ...@@ -11459,9 +11459,6 @@ msgstr ""
msgid "Diff limits" msgid "Diff limits"
msgstr "" msgstr ""
msgid "Diff view settings"
msgstr ""
msgid "Difference between start date and now" msgid "Difference between start date and now"
msgstr "" msgstr ""
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment