Merge branch '323493-feature-flag-enable-caching-issues-count-in-group-sidebar' into 'master'

Enable cached_sidebar_open_issues_count FF by default

See merge request gitlab-org/gitlab!55968

app/helpers/groups_helper.rb

@@ -63,7 +63,7 @@ module GroupsHelper
   end
 
   def group_open_issues_count(group)
-    if Feature.enabled?(:cached_sidebar_open_issues_count, group)
+    if Feature.enabled?(:cached_sidebar_open_issues_count, group, default_enabled: :yaml)
       cached_open_group_issues_count(group)
     else
       number_with_delimiter(group_issues_count(state: 'opened'))

changelogs/unreleased/323493-feature-flag-enable-caching-issues-count-in-group-sidebar.yml

+---
+title: Cache open issues count in group sidebar
+merge_request: 55968
+author:
+type: added

config/feature_flags/development/cached_sidebar_open_issues_count.yml

@@ -5,4 +5,4 @@ rollout_issue_url:
 milestone: '13.8'
 type: development
 group: group::product planning
-default_enabled: false
+default_enabled: true

doc/user/project/issues/index.md

@@ -197,18 +197,18 @@ You can then see issue statuses in the [issue list](#issues-list) and the
 ## Enable or disable cached issue count **(FREE SELF)**
 
 Cached issue count in the left sidebar is under development and not ready for production use. It is
-deployed behind a feature flag that is **disabled by default**.
+deployed behind a feature flag that is **enabled by default**.
 [GitLab administrators with access to the GitLab Rails console](../../../administration/feature_flags.md)
-can enable it.
+can disable it.
 
-To enable it:
+To disable it:
 
 ```ruby
-Feature.enable(:cached_sidebar_open_issues_count)
+Feature.disable(:cached_sidebar_open_issues_count)
 ```
 
-To disable it:
+To enable it:
 
 ```ruby
-Feature.disable(:cached_sidebar_open_issues_count)
+Feature.enable(:cached_sidebar_open_issues_count)
 ```

spec/helpers/groups_helper_spec.rb

@@ -460,18 +460,12 @@ RSpec.describe GroupsHelper do
       allow(helper).to receive(:current_user) { current_user }
     end
 
-    context 'when cached_sidebar_open_issues_count feature flag is enabled' do
-      before do
-        stub_feature_flags(cached_sidebar_open_issues_count: true)
+    it 'returns count value from cache' do
+      allow_next_instance_of(count_service) do |service|
+        allow(service).to receive(:count).and_return(2500)
       end
 
-      it 'returns count value from cache' do
-        allow_next_instance_of(count_service) do |service|
-          allow(service).to receive(:count).and_return(2500)
-        end
-
-        expect(helper.group_open_issues_count(group)).to eq('2.5k')
-      end
+      expect(helper.group_open_issues_count(group)).to eq('2.5k')
     end
 
     context 'when cached_sidebar_open_issues_count feature flag is disabled' do