Merge branch '350734-remove-ci_pipeline_merge_request_presence_check-ff' into 'master'

Remove ci_pipeline_merge_request_presence_check feature flag

See merge request gitlab-org/gitlab!82107

app/models/ci/pipeline.rb

@@ -1164,11 +1164,7 @@ module Ci
     end
 
     def merge_request?
-      if Feature.enabled?(:ci_pipeline_merge_request_presence_check, default_enabled: :yaml)
-        merge_request_id.present? && merge_request.present?
-      else
-        merge_request_id.present?
-      end
+      merge_request_id.present? && merge_request.present?
     end
 
     def external_pull_request?

config/feature_flags/development/ci_pipeline_merge_request_presence_check.yml

----
-name: ci_pipeline_merge_request_presence_check
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/78574
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350734
-milestone: '14.8'
-type: development
-group: group::pipeline execution
-default_enabled: true

spec/models/ci/pipeline_spec.rb

@@ -438,15 +438,6 @@ RSpec.describe Ci::Pipeline, :mailer, factory_default: :keep do
 
       it { expect(pipeline).not_to be_merge_request }
     end
-
-    context 'when the feature flag is disabled' do
-      before do
-        stub_feature_flags(ci_pipeline_merge_request_presence_check: false)
-        pipeline.update!(merge_request_id: non_existing_record_id)
-      end
-
-      it { expect(pipeline).to be_merge_request }
-    end
   end
 
   describe '#detached_merge_request_pipeline?' do