prefer !x.exists? instead of x.none? to prevent unnecessary instantiation of records

b7b49c4a · Mike Greiling · 1c3b3fac · b7b49c4a
Commit b7b49c4a authored Aug 25, 2017 by Mike Greiling
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

app/models/group.rb app/models/group.rb +2 -2

No files found.
--- a/app/models/group.rb
+++ b/app/models/group.rb
@@ -129,11 +129,11 @@ class Group < Namespace
  end

  def visibility_level_allowed_by_projects?(level = self.visibility_level)
-    projects.where('visibility_level > ?', level).none?
+    !projects.where('visibility_level > ?', level).exists?
  end

  def visibility_level_allowed_by_sub_groups?(level = self.visibility_level)
-    children.where('visibility_level > ?', level).none?
+    !children.where('visibility_level > ?', level).exists?
  end

  def visibility_level_allowed?(level = self.visibility_level)