Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b8cbeff9
Commit
b8cbeff9
authored
Jan 12, 2022
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix `api/commits_spec.rb` cross-DB modification
Fixes specs to use FactoryGirl instead.
parent
414f3cc6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
7 deletions
+2
-7
spec/requests/api/commits_spec.rb
spec/requests/api/commits_spec.rb
+2
-6
spec/support/database/cross-database-modification-allowlist.yml
...upport/database/cross-database-modification-allowlist.yml
+0
-1
No files found.
spec/requests/api/commits_spec.rb
View file @
b8cbeff9
...
...
@@ -1056,9 +1056,7 @@ RSpec.describe API::Commits do
shared_examples_for
'ref with pipeline'
do
let!
(
:pipeline
)
do
project
.
ci_pipelines
.
create!
(
source: :push
,
ref:
'master'
,
sha:
commit
.
sha
,
protected:
false
)
create
(
:ci_empty_pipeline
,
project:
project
,
status: :created
,
source: :push
,
ref:
'master'
,
sha:
commit
.
sha
,
protected:
false
)
end
it
'includes status as "created" and a last_pipeline object'
do
...
...
@@ -1090,9 +1088,7 @@ RSpec.describe API::Commits do
shared_examples_for
'ref with unaccessible pipeline'
do
let!
(
:pipeline
)
do
project
.
ci_pipelines
.
create!
(
source: :push
,
ref:
'master'
,
sha:
commit
.
sha
,
protected:
false
)
create
(
:ci_empty_pipeline
,
project:
project
,
status: :created
,
source: :push
,
ref:
'master'
,
sha:
commit
.
sha
,
protected:
false
)
end
it
'does not include last_pipeline'
do
...
...
spec/support/database/cross-database-modification-allowlist.yml
View file @
b8cbeff9
...
...
@@ -2,5 +2,4 @@
-
"
./spec/models/ci/build_trace_chunk_spec.rb"
-
"
./spec/models/ci/job_artifact_spec.rb"
-
"
./spec/models/clusters/applications/runner_spec.rb"
-
"
./spec/requests/api/commits_spec.rb"
-
"
./spec/services/ci/retry_build_service_spec.rb"
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment