Commit b945eefd authored by Andrew Fontaine's avatar Andrew Fontaine

Merge branch 'hide-submit-vuln-button-from-guests' into 'master'

Do not display submit vulnerability to guests

See merge request gitlab-org/gitlab!82577
parents 3e7e6f99 03ec1af6
...@@ -19,10 +19,17 @@ export default { ...@@ -19,10 +19,17 @@ export default {
newVulnerabilityPath: { newVulnerabilityPath: {
default: '', default: '',
}, },
canAdminVulnerability: {
default: false,
},
}, },
computed: { computed: {
shouldShowNewVulnerabilityButton() { shouldShowNewVulnerabilityButton() {
return this.glFeatures.newVulnerabilityForm && Boolean(this.newVulnerabilityPath); return (
this.glFeatures.newVulnerabilityForm &&
Boolean(this.newVulnerabilityPath) &&
this.canAdminVulnerability
);
}, },
}, },
i18n: { i18n: {
......
...@@ -20,6 +20,7 @@ describe('Vulnerability report header component', () => { ...@@ -20,6 +20,7 @@ describe('Vulnerability report header component', () => {
it('shows the submit vulnerability button when new vulnerability path is defined', () => { it('shows the submit vulnerability button when new vulnerability path is defined', () => {
createWrapper({ createWrapper({
provide: { provide: {
canAdminVulnerability: true,
newVulnerabilityPath: '/vulnerabilities/new', newVulnerabilityPath: '/vulnerabilities/new',
glFeatures: { newVulnerabilityForm: true }, glFeatures: { newVulnerabilityForm: true },
}, },
...@@ -33,6 +34,19 @@ describe('Vulnerability report header component', () => { ...@@ -33,6 +34,19 @@ describe('Vulnerability report header component', () => {
it('does not show the submit vulnerability button when new vulnerability path is not defined', () => { it('does not show the submit vulnerability button when new vulnerability path is not defined', () => {
createWrapper({ createWrapper({
provide: { provide: {
canAdminVulnerability: true,
glFeatures: { newVulnerabilityForm: true },
},
});
expect(wrapper.findByText('Submit vulnerability').exists()).toBe(false);
});
it('does not should the submit vulnerability button when user cannot admin vulnerabilities', () => {
createWrapper({
provide: {
canAdminVulnerability: false,
newVulnerabilityPath: '/vulnerabilities/new',
glFeatures: { newVulnerabilityForm: true }, glFeatures: { newVulnerabilityForm: true },
}, },
}); });
...@@ -43,6 +57,7 @@ describe('Vulnerability report header component', () => { ...@@ -43,6 +57,7 @@ describe('Vulnerability report header component', () => {
it('does not show the submit vulnerability button when the feature flag is not enabled', () => { it('does not show the submit vulnerability button when the feature flag is not enabled', () => {
createWrapper({ createWrapper({
provide: { provide: {
canAdminVulnerability: true,
newVulnerabilityPath: '/vulnerabilities/new', newVulnerabilityPath: '/vulnerabilities/new',
}, },
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment