Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ba2b282a
Commit
ba2b282a
authored
Jul 21, 2020
by
Mark Lapierre
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove obsolete flag from code owner E2E tests
parent
bdc878ba
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
36 deletions
+2
-36
qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_root_group_spec.rb
...te/repository/merge_with_code_owner_in_root_group_spec.rb
+1
-18
qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_subgroup_spec.rb
...eate/repository/merge_with_code_owner_in_subgroup_spec.rb
+1
-18
No files found.
qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_root_group_spec.rb
View file @
ba2b282a
# frozen_string_literal: true
module
QA
# These tests will fail unless the feature flag `skip_web_ui_code_owner_validations` is enabled.
# That requirement is temporary. See https://gitlab.com/gitlab-org/gitlab/-/issues/217427
# When the flag is no longer needed:
# - the tests will no longer need to toggle it, and
# - the tests will not require admin access, and
# - the tests can be run in live environments
# Tracked in https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/511
context
'Create'
,
:requires_admin
,
:skip_live_env
do
context
'Create'
do
describe
'Codeowners'
do
before
(
:context
)
do
@feature_flag
=
'skip_web_ui_code_owner_validations'
@feature_flag_enabled
=
Runtime
::
Feature
.
enabled?
(
@feature_flag
)
Runtime
::
Feature
.
enable_and_verify
(
@feature_flag
)
unless
@feature_flag_enabled
end
after
(
:context
)
do
Runtime
::
Feature
.
disable_and_verify
(
@feature_flag
)
unless
@feature_flag_enabled
end
context
'when the project is in the root group'
do
let
(
:approver
)
{
Resource
::
User
.
fabricate_or_use
(
Runtime
::
Env
.
gitlab_qa_username_1
,
Runtime
::
Env
.
gitlab_qa_password_1
)
}
let
(
:root_group
)
{
Resource
::
Sandbox
.
fabricate_via_api!
}
...
...
qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_subgroup_spec.rb
View file @
ba2b282a
# frozen_string_literal: true
module
QA
# These tests will fail unless the feature flag `skip_web_ui_code_owner_validations` is enabled.
# That requirement is temporary. See https://gitlab.com/gitlab-org/gitlab/-/issues/217427
# When the flag is no longer needed:
# - the tests will no longer need to toggle it, and
# - the tests will not require admin access, and
# - the tests can be run in live environments
# Tracked in https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/511
context
'Create'
,
:requires_admin
,
:skip_live_env
do
context
'Create'
do
describe
'Codeowners'
do
before
(
:context
)
do
@feature_flag
=
'skip_web_ui_code_owner_validations'
@feature_flag_enabled
=
Runtime
::
Feature
.
enabled?
(
@feature_flag
)
Runtime
::
Feature
.
enable_and_verify
(
@feature_flag
)
unless
@feature_flag_enabled
end
after
(
:context
)
do
Runtime
::
Feature
.
disable_and_verify
(
@feature_flag
)
unless
@feature_flag_enabled
end
context
'when the project is in a subgroup'
do
let
(
:approver
)
{
Resource
::
User
.
fabricate_or_use
(
Runtime
::
Env
.
gitlab_qa_username_1
,
Runtime
::
Env
.
gitlab_qa_password_1
)
}
let
(
:project
)
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment