Commit ba4f4114 authored by Walmyr Lima's avatar Walmyr Lima

Rename elements and method on page objects

And adjust the affected test accordingly.

The idea is to improve readability by having more descriptive
names.
parent fef06628
...@@ -13,7 +13,7 @@ module QA ...@@ -13,7 +13,7 @@ module QA
end end
view 'app/assets/javascripts/vue_shared/components/issue/related_issuable_item.vue' do view 'app/assets/javascripts/vue_shared/components/issue/related_issuable_item.vue' do
element :remove_issue_button element :remove_related_issue_button
end end
view 'ee/app/assets/javascripts/epic/components/epic_header.vue' do view 'ee/app/assets/javascripts/epic/components/epic_header.vue' do
...@@ -49,7 +49,7 @@ module QA ...@@ -49,7 +49,7 @@ module QA
end end
def remove_issue_from_epic def remove_issue_from_epic
click_element :remove_issue_button click_element :remove_related_issue_button
end end
def click_edit_button def click_edit_button
......
...@@ -36,7 +36,7 @@ module QA ...@@ -36,7 +36,7 @@ module QA
end end
view 'app/assets/javascripts/vue_shared/components/issue/related_issuable_item.vue' do view 'app/assets/javascripts/vue_shared/components/issue/related_issuable_item.vue' do
element :remove_issue_button element :remove_related_issue_button
end end
view 'app/helpers/dropdowns_helper.rb' do view 'app/helpers/dropdowns_helper.rb' do
...@@ -80,8 +80,8 @@ module QA ...@@ -80,8 +80,8 @@ module QA
click_element(:milestone_link) click_element(:milestone_link)
end end
def click_remove_issue_button def click_remove_related_issue_button
click_element(:remove_issue_button) click_element(:remove_related_issue_button)
end end
# Adds a comment to an issue # Adds a comment to an issue
......
...@@ -37,7 +37,7 @@ module QA ...@@ -37,7 +37,7 @@ module QA
expect(show).to have_content("marked this issue as related to ##{issue_2.iid}") expect(show).to have_content("marked this issue as related to ##{issue_2.iid}")
expect(show.related_issuable_item).to have_content(issue_2.title) expect(show.related_issuable_item).to have_content(issue_2.title)
show.click_remove_issue_button show.click_remove_related_issue_button
expect(show).to have_content("removed the relation with ##{issue_2.iid}") expect(show).to have_content("removed the relation with ##{issue_2.iid}")
expect(show).not_to have_content(issue_2.title) expect(show).not_to have_content(issue_2.title)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment