Commit bdf56236 authored by Filipa Lacerda's avatar Filipa Lacerda Committed by Matija Čupić

Renders feature flags link when ci/cd is disabled

Updates specs

try to fix test
parent f9f8ebea
...@@ -195,8 +195,13 @@ ...@@ -195,8 +195,13 @@
= _('Charts') = _('Charts')
- if project_nav_tab? :operations - if project_nav_tab? :operations
- if can?(current_user, :read_environment, @project) || can?(current_user, :read_cluster, @project)
- main_link = metrics_project_environments_path(@project)
- elsif can?(current_user, :read_feature_flag, @project)
- main_link = project_feature_flags_path(@project)
= nav_link(controller: sidebar_operations_paths) do = nav_link(controller: sidebar_operations_paths) do
= link_to metrics_project_environments_path(@project), class: 'shortcuts-operations' do = link_to main_link, class: 'shortcuts-operations' do
.nav-icon-container .nav-icon-container
= sprite_icon('cloud-gear') = sprite_icon('cloud-gear')
%span.nav-item-name %span.nav-item-name
......
---
title: Defaults to feature flags link for Operations entry
merge_request: 8622
author:
type: fixed
...@@ -13,6 +13,33 @@ describe 'layouts/nav/sidebar/_project' do ...@@ -13,6 +13,33 @@ describe 'layouts/nav/sidebar/_project' do
stub_licensed_features(tracing: true) stub_licensed_features(tracing: true)
end end
describe 'Operations main link' do
describe 'when ci/cd is disabled' do
let(:feature) { ProjectFeature::DISABLED }
it 'links to feature flags page' do
allow(view).to receive(:can?).with(:read_environment).and_return(false)
allow(view).to receive(:can?).with(:read_cluster).and_return(false)
allow(view).to receive(:can?).with(:read_feature_flag).and_return(true)
render
expect(rendered).to have_link('Operations', :href=> project_feature_flags_path(project))
end
end
describe 'when ci/cd is enabled' do
let(:feature) { ProjectFeature::ENABLED }
it 'links to metrics page' do
allow(view).to receive(:can?).and_return(true)
render
expect(rendered).to have_link('Operations', :href=> metrics_project_environments_path(project))
end
end
end
describe 'Operations > Tracing' do describe 'Operations > Tracing' do
it 'is not visible when no valid license' do it 'is not visible when no valid license' do
allow(view).to receive(:can?).and_return(true) allow(view).to receive(:can?).and_return(true)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment