Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
bf9b94c1
Commit
bf9b94c1
authored
Sep 26, 2019
by
Winnie Hellmann
Committed by
Mike Greiling
Sep 26, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable promise/param-name ESLint rule
parent
0afddb90
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
7 deletions
+6
-7
.eslintrc.yml
.eslintrc.yml
+0
-1
ee/spec/javascripts/monitoring/alert_widget_spec.js
ee/spec/javascripts/monitoring/alert_widget_spec.js
+2
-2
spec/frontend/ide/components/error_message_spec.js
spec/frontend/ide/components/error_message_spec.js
+4
-4
No files found.
.eslintrc.yml
View file @
bf9b94c1
...
...
@@ -46,7 +46,6 @@ rules:
promise/always-return
:
off
promise/no-callback-in-promise
:
off
promise/no-nesting
:
off
promise/param-names
:
off
promise/valid-params
:
off
overrides
:
files
:
...
...
ee/spec/javascripts/monitoring/alert_widget_spec.js
View file @
bf9b94c1
...
...
@@ -53,8 +53,8 @@ describe('AlertWidget', () => {
let
resolveReadAlert
;
spyOn
(
AlertsService
.
prototype
,
'
readAlert
'
).
and
.
returnValue
(
new
Promise
(
cb
=>
{
resolveReadAlert
=
cb
;
new
Promise
(
resolve
=>
{
resolveReadAlert
=
resolve
;
}),
);
vm
=
mountComponent
(
AlertWidgetComponent
,
propsWithAlert
,
'
#alert-widget
'
);
...
...
spec/frontend/ide/components/error_message_spec.js
View file @
bf9b94c1
...
...
@@ -95,18 +95,18 @@ describe('IDE error message component', () => {
});
it
(
'
shows loading icon when loading
'
,
()
=>
{
let
resolve
;
let
resolve
Action
;
actionMock
.
mockImplementation
(
()
=>
new
Promise
(
ok
=>
{
resolve
=
ok
;
new
Promise
(
resolve
=>
{
resolve
Action
=
resolve
;
}),
);
wrapper
.
find
(
'
button
'
).
trigger
(
'
click
'
);
return
wrapper
.
vm
.
$nextTick
(()
=>
{
expect
(
wrapper
.
find
(
GlLoadingIcon
).
isVisible
()).
toBe
(
true
);
resolve
();
resolve
Action
();
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment