Implement memoization in project correctly this time

bfdd34c5 · Grzegorz Bizon · b4349fd3 · bfdd34c5
Commit bfdd34c5 authored Jul 14, 2017 by Grzegorz Bizon
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

app/models/project.rb app/models/project.rb +3 -1

No files found.
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -486,7 +486,9 @@ class Project < ActiveRecord::Base
  end

  def has_container_registry_tags?
-    @images ||= container_repositories.to_a.any?(&:has_tags?) ||
+    return @images if defined?(@images)
+
+    @images = container_repositories.to_a.any?(&:has_tags?) ||
      has_root_container_repository_tags?
  end