Merge branch '351981-cablett-sort-epics-created-updated-graphql' into 'master'

Add epic filter and sort by last created or updated

See merge request gitlab-org/gitlab!79923

ee/app/graphql/resolvers/epics_resolver.rb

@@ -60,6 +60,19 @@ module Resolvers
              required: false,
              description: 'Filter by reaction emoji applied by the current user.'
 
+    argument :created_after, Types::TimeType,
+             required: false,
+             description: 'Epics created after this date.'
+    argument :created_before, Types::TimeType,
+             required: false,
+             description: 'Epics created before this date.'
+    argument :updated_after, Types::TimeType,
+             required: false,
+             description: 'Epics updated after this date.'
+    argument :updated_before, Types::TimeType,
+             required: false,
+             description: 'Epics updated before this date.'
+
     argument :not, ::Types::Epics::NegatedEpicFilterInputType,
              required: false,
              description: 'Negated epic arguments.'

ee/app/graphql/types/epic_sort_enum.rb

@@ -18,5 +18,9 @@ module Types
     value 'END_DATE_ASC', 'Sort by end date in ascending order.', value: :end_date_asc
     value 'TITLE_DESC', 'Sort by title in descending order.', value: :title_desc
     value 'TITLE_ASC', 'Sort by title in ascending order.', value: :title_asc
+    value 'CREATED_AT_ASC', 'Sort by created_at by ascending order.', value: :created_at_asc
+    value 'CREATED_AT_DESC', 'Sort by created_at by descending order.', value: :created_at_desc
+    value 'UPDATED_AT_ASC', 'Sort by updated_at by ascending order.', value: :updated_at_asc
+    value 'UPDATED_AT_DESC', 'Sort by updated_at by descending order.', value: :updated_at_desc
   end
 end

ee/spec/graphql/types/epic_sort_enum_spec.rb

@@ -6,6 +6,6 @@ RSpec.describe GitlabSchema.types['EpicSort'] do
   it { expect(described_class.graphql_name).to eq('EpicSort') }
 
   it 'exposes all the existing epic sort orders' do
-    expect(described_class.values.keys).to include(*%w[start_date_desc start_date_asc end_date_desc end_date_asc START_DATE_DESC START_DATE_ASC END_DATE_DESC END_DATE_ASC TITLE_DESC TITLE_ASC])
+    expect(described_class.values.keys).to include(*%w[start_date_desc start_date_asc end_date_desc end_date_asc START_DATE_DESC START_DATE_ASC END_DATE_DESC END_DATE_ASC TITLE_DESC TITLE_ASC CREATED_AT_ASC CREATED_AT_DESC UPDATED_AT_ASC UPDATED_AT_DESC])
   end
 end

ee/spec/requests/api/graphql/epics/epic_resolver_spec.rb

@@ -52,6 +52,55 @@ RSpec.describe 'getting epics information' do
     end
   end
 
+  describe 'query for epics by created_at and updated_at' do
+    let_it_be(:epic1) { create(:epic, group: group, created_at: 2.weeks.ago, updated_at: 10.seconds.ago) }
+    let_it_be(:epic2) { create(:epic, group: group, created_at: 8.days.ago, updated_at: 2.minutes.ago) }
+    let_it_be(:epic3) { create(:epic, group: group, created_at: 2.hours.ago, updated_at: 9.minutes.ago) }
+    let_it_be(:epic4) { create(:epic, group: group, created_at: 15.minutes.ago, updated_at: 14.minutes.ago) }
+
+    it 'filters by createdBefore' do
+      post_graphql(epics_query(group, 'createdBefore', 5.days.ago), current_user: user)
+
+      expect_epics_response(epic1, epic2)
+    end
+
+    it 'filters by createdAfter' do
+      post_graphql(epics_query(group, 'createdAfter', 5.days.ago), current_user: user)
+
+      expect_epics_response(epic3, epic4)
+    end
+
+    it 'filters by updatedBefore' do
+      post_graphql(epics_query(group, 'updatedBefore', 7.minutes.ago), current_user: user)
+
+      expect_epics_response(epic3, epic4)
+    end
+
+    it 'filters by updatedAfter' do
+      post_graphql(epics_query(group, 'updatedAfter', 7.minutes.ago), current_user: user)
+
+      expect_epics_response(epic1, epic2)
+    end
+
+    it 'filters by a combination of created parameters provided' do
+      post_graphql(epics_query_by_hash(group, { 'createdBefore' => Time.zone.now, 'createdAfter' => 20.minutes.ago }), current_user: user)
+
+      expect_epics_response(epic4)
+    end
+
+    it 'filters by a combination of created/updated parameters provided' do
+      post_graphql(epics_query_by_hash(group, { 'updatedBefore' => 3.minutes.ago, 'createdAfter' => 20.minutes.ago }), current_user: user)
+
+      expect_epics_response(epic4)
+    end
+
+    it 'returns nothing for impossible parameters' do
+      post_graphql(epics_query_by_hash(group, { 'createdBefore' => 7.minutes.ago, 'createdAfter' => Time.zone.now }), current_user: user)
+
+      expect_epics_response # empty set
+    end
+  end
+
   describe 'query for epics by time frame' do
     let_it_be(:epic1) { create(:epic, group: group, state: :opened, start_date: "2019-08-13", end_date: "2019-08-20") }
     let_it_be(:epic2) { create(:epic, group: group, state: :closed, start_date: "2019-08-13", end_date: "2019-08-21") }
@@ -213,6 +262,7 @@ RSpec.describe 'getting epics information' do
   end
 
   def expect_epics_response(*epics)
+    epics ||= []
     actual_epics = graphql_data['group']['epics']['nodes'].map { |epic| epic['id'] }
     expected_epics = epics.map { |epic| epic.to_global_id.to_s }
 

ee/spec/requests/api/graphql/group/epics_spec.rb

@@ -66,14 +66,14 @@ RSpec.describe 'Epics through GroupQuery' do
 
     context 'with multiple epics' do
       let_it_be(:user2) { create(:user) }
-      let_it_be(:epic2) { create(:epic, author: user2, group: group, title: 'foo', description: 'bar', created_at: 2.days.ago, updated_at: 3.days.ago, start_date: 3.days.ago, end_date: 3.days.ago ) }
+      let_it_be(:epic2) { create(:epic, author: user2, group: group, title: 'foo', description: 'bar', created_at: 5.days.ago, updated_at: 3.days.ago, start_date: 3.days.ago, end_date: 3.days.ago ) }
 
       before do
         stub_licensed_features(epics: true)
       end
 
       context 'with sort and pagination' do
-        let_it_be(:epic3) { create(:epic, group: group, start_date: 4.days.ago, end_date: 7.days.ago ) }
+        let_it_be(:epic3) { create(:epic, group: group, start_date: 4.days.ago, end_date: 7.days.ago, created_at: 4.days.ago, updated_at: 1.day.ago ) }
         let_it_be(:epic4) { create(:epic, group: group, start_date: 5.days.ago, end_date: 6.days.ago ) }
 
         let(:current_user) { user }
@@ -126,6 +126,38 @@ RSpec.describe 'Epics through GroupQuery' do
             let(:all_records) { global_ids(epic2, epic, epic4, epic3) }
           end
         end
+
+        context 'with created_at_asc' do
+          it_behaves_like 'sorted paginated query', is_reversible: true do
+            let(:sort_param) { :CREATED_AT_ASC }
+            let(:first_param) { 2 }
+            let(:all_records) { global_ids(epic2, epic3, epic, epic4) }
+          end
+        end
+
+        context 'with created_at_desc' do
+          it_behaves_like 'sorted paginated query', is_reversible: true do
+            let(:sort_param) { :CREATED_AT_DESC }
+            let(:first_param) { 2 }
+            let(:all_records) { global_ids(epic4, epic, epic3, epic2) }
+          end
+        end
+
+        context 'with updated_at_asc' do
+          it_behaves_like 'sorted paginated query', is_reversible: true do
+            let(:sort_param) { :UPDATED_AT_ASC }
+            let(:first_param) { 2 }
+            let(:all_records) { global_ids(epic2, epic, epic3, epic4) }
+          end
+        end
+
+        context 'with updated_at_desc' do
+          it_behaves_like 'sorted paginated query', is_reversible: true do
+            let(:sort_param) { :UPDATED_AT_DESC }
+            let(:first_param) { 2 }
+            let(:all_records) { global_ids(epic4, epic3, epic, epic2) }
+          end
+        end
       end
 
       it 'sorts by created_at descending by default' do
@@ -212,14 +244,16 @@ RSpec.describe 'Epics through GroupQuery' do
         end
       end
 
-      context 'with search params' do
-        it 'returns only matching epics' do
-          filter_params = { search: 'bar', in: [:DESCRIPTION] }
-          graphql_query = query(filter_params)
+      context 'filter' do
+        context 'with search params' do
+          it 'returns only matching epics' do
+            filter_params = { search: 'bar', in: [:DESCRIPTION] }
+            graphql_query = query(filter_params)
 
-          post_graphql(graphql_query, current_user: user)
+            post_graphql(graphql_query, current_user: user)
 
-          expect_array_response([epic2.to_global_id.to_s])
+            expect_array_response([epic2.to_global_id.to_s])
+          end
         end
       end
     end