Merge branch 'ee-remove-sidebar-bundle' into 'master'

Remove sidebar bundle webpack entry point (EE)

See merge request gitlab-org/gitlab-ee!4713

app/views/shared/issuable/_sidebar.html.haml

 - todo = issuable_todo(issuable)
 - content_for :page_specific_javascripts do
   = webpack_bundle_tag('common_vue')
-  = webpack_bundle_tag('ee_sidebar')
 
 %aside.right-sidebar.js-right-sidebar.js-issuable-sidebar{ data: { signed: { in: current_user.present? } }, class: sidebar_gutter_collapsed_class, 'aria-live' => 'polite' }
   .issuable-sidebar{ data: { endpoint: "#{issuable_json_path(issuable)}" } }

config/webpack.config.js

@@ -65,7 +65,6 @@ function generateEntries() {
     protected_branches:   './protected_branches',
     protected_tags:       './protected_tags',
     registry_list:        './registry/index.js',
-    sidebar:              './sidebar/sidebar_bundle.js',
     snippet:              './snippet/snippet_bundle.js',
     sketch_viewer:        './blob/sketch_viewer.js',
     stl_viewer:           './blob/stl_viewer.js',
@@ -99,7 +98,6 @@ function generateEntries() {
     service_desk:         'ee/projects/settings_service_desk/service_desk_bundle.js',
     service_desk_issues:  'ee/service_desk_issues/index.js',
     roadmap:              'ee/roadmap',
-    ee_sidebar:           'ee/sidebar/sidebar_bundle.js',
   };
 
   return Object.assign(manualEntries, autoEntries);

ee/app/assets/javascripts/pages/projects/issues/show/index.js

+import '~/pages/projects/issues/show/index';
+import initSidebarBundle from 'ee/sidebar/sidebar_bundle';
+
+document.addEventListener('DOMContentLoaded', initSidebarBundle);

ee/app/assets/javascripts/pages/projects/merge_requests/conflicts/index.js

+import initSidebarBundle from 'ee/sidebar/sidebar_bundle';
+
+document.addEventListener('DOMContentLoaded', initSidebarBundle);

ee/app/assets/javascripts/pages/projects/merge_requests/conflicts/show/index.js

+import initSidebarBundle from 'ee/sidebar/sidebar_bundle';
+
+document.addEventListener('DOMContentLoaded', initSidebarBundle);

ee/app/assets/javascripts/pages/projects/merge_requests/show/index.js

+import '~/pages/projects/merge_requests/show/index';
+import initSidebarBundle from 'ee/sidebar/sidebar_bundle';
+
+document.addEventListener('DOMContentLoaded', initSidebarBundle);

ee/app/assets/javascripts/sidebar/sidebar_bundle.js

@@ -2,13 +2,9 @@ import { getSidebarOptions } from '~/sidebar/mount_sidebar';
 import Mediator from './sidebar_mediator';
 import mountSidebar from './mount_sidebar';
 
-function domContentLoaded() {
+export default () => {
   const mediator = new Mediator(getSidebarOptions());
   mediator.fetch();
 
   mountSidebar(mediator);
-}
-
-document.addEventListener('DOMContentLoaded', domContentLoaded);
-
-export default domContentLoaded;
+};