Improvements for Issue Detail loading

Using delayed request for polling

Removing Sidebar startup call again
Restructured makeDelayedRequest

Delayed Polling Spec fixes

app/assets/javascripts/issue_show/components/app.vue

@@ -247,7 +247,7 @@ export default {
     });
 
     if (!Visibility.hidden()) {
-      this.poll.makeRequest();
+      this.poll.makeDelayedRequest(2000);
     }
 
     Visibility.change(() => {

app/assets/javascripts/lib/utils/poll.js

@@ -88,7 +88,11 @@ export default class Poll {
   }
 
   makeDelayedRequest(delay = 0) {
-    this.timeoutID = setTimeout(() => this.makeRequest(), delay);
+    // So we don't make our specs artificially slower
+    this.timeoutID = setTimeout(
+      () => this.makeRequest(),
+      process.env.NODE_ENV !== 'test' ? delay : 1,
+    );
   }
 
   makeRequest() {

app/assets/javascripts/notes/stores/actions.js

@@ -475,7 +475,7 @@ export const poll = ({ commit, state, getters, dispatch }) => {
   });
 
   if (!Visibility.hidden()) {
-    eTagPoll.makeRequest();
+    eTagPoll.makeDelayedRequest(2500);
   } else {
     dispatch('fetchData');
   }

ee/spec/frontend/epic/components/epic_app_spec.js

@@ -29,6 +29,8 @@ describe('EpicAppComponent', () => {
     vm = mountComponentWithStore(Component, {
       store,
     });
+
+    jest.advanceTimersByTime(2);
   });
 
   afterEach(() => {

ee/spec/frontend/epic/components/epic_body_spec.js

@@ -29,6 +29,8 @@ describe('EpicBodyComponent', () => {
     vm = mountComponentWithStore(Component, {
       store,
     });
+
+    jest.advanceTimersByTime(5);
   });
 
   afterEach(() => {

spec/frontend/issue_show/components/app_spec.js

@@ -78,6 +78,8 @@ describe('Issuable output', () => {
       });
 
     mountComponent();
+
+    jest.advanceTimersByTime(2);
   });
 
   afterEach(() => {

spec/frontend/notes/components/notes_app_spec.js

@@ -330,6 +330,8 @@ describe('note_app', () => {
 
       wrapper.vm.$parent.$el.dispatchEvent(toggleAwardEvent);
 
+      jest.advanceTimersByTime(2);
+
       expect(toggleAwardAction).toHaveBeenCalledTimes(1);
       const [, payload] = toggleAwardAction.mock.calls[0];
 

spec/frontend/notes/stores/actions_spec.js

@@ -335,6 +335,9 @@ describe('Actions Notes Store', () => {
     it('calls service with last fetched state', done => {
       store
         .dispatch('poll')
+        .then(() => {
+          jest.advanceTimersByTime(2);
+        })
         .then(() => new Promise(resolve => requestAnimationFrame(resolve)))
         .then(() => {
           expect(store.state.lastFetchedAt).toBe('123456');