Merge branch 'mw-cleanup-fa-classes' into 'master'

Remove deprecated fa- classes See merge request gitlab-org/gitlab!49802

Merge branch 'mw-cleanup-fa-classes' into 'master'
Remove deprecated fa- classes See merge request gitlab-org/gitlab!49802
c2e635cb · Jose Ivan Vargas · d7ed14ee · fd90f5f6 · c2e635cb · c2e635cb
Commit c2e635cb authored Dec 11, 2020 by Jose Ivan Vargas
7 changed files
--- a/app/assets/stylesheets/framework/secondary_navigation_elements.scss
+++ b/app/assets/stylesheets/framework/secondary_navigation_elements.scss
@@ -276,7 +276,7 @@
    @include fade(left, $gray-light);
    right: -5px;

-    .fa {
+    svg {
      right: -7px;
    }
  }
@@ -286,7 +286,7 @@
    left: -5px;
    text-align: center;

-    .fa {
+    svg {
      left: -7px;
    }
  }
@@ -337,7 +337,7 @@
      @include fade(left, $white);
      right: -5px;

-      .fa {
+      svg {
        right: -7px;
      }
    }
@@ -346,7 +346,7 @@
      @include fade(right, $white);
      left: -5px;

-      .fa {
+      svg {
        left: -7px;
      }
    }

--- a/app/assets/stylesheets/page_bundles/pipelines.scss
+++ b/app/assets/stylesheets/page_bundles/pipelines.scss
@@ -43,11 +43,6 @@
    .dropdown-toggle,
    .dropdown-menu {
      color: $gl-text-color-secondary;
-
-      .fa {
-        color: $gl-text-color-secondary;
-        font-size: 14px;
-      }
    }

    .btn-group.open .btn-default {

--- a/app/assets/stylesheets/pages/members.scss
+++ b/app/assets/stylesheets/pages/members.scss
@@ -30,12 +30,6 @@
    margin-bottom: 0;
  }

-  .member-controls {
-    .fa {
-      line-height: inherit;
-    }
-  }
-
  &.existing-title {
    @include media-breakpoint-up(sm) {
      float: left;

--- a/app/assets/stylesheets/pages/merge_requests.scss
+++ b/app/assets/stylesheets/pages/merge_requests.scss
@@ -163,12 +163,6 @@ $mr-widget-min-height: 69px;

  .btn {
    font-size: $gl-font-size;
-
-    &.dropdown-toggle {
-      .fa {
-        color: inherit;
-      }
-    }
  }

  .accept-merge-holder {
@@ -341,13 +335,6 @@ $mr-widget-min-height: 69px;
      }
    }

-    .dropdown-toggle {
-      .fa {
-        margin-left: 0;
-        color: inherit;
-      }
-    }
-
    .has-custom-error {
      display: inline-block;
    }
@@ -552,10 +539,6 @@ $mr-widget-min-height: 69px;
    align-items: center;
  }

-  .dropdown-toggle .fa {
-    color: $gl-text-color;
-  }
-
  .git-merge-container {
    justify-content: space-between;
    flex: 1;

--- a/app/assets/stylesheets/pages/notes.scss
+++ b/app/assets/stylesheets/pages/notes.scss
@@ -778,13 +778,6 @@ $note-form-margin-left: 72px;
    outline: none;
    color: $blue-600;
  }
-
-  .fa {
-    margin-right: 3px;
-    font-size: 10px;
-    line-height: 18px;
-    vertical-align: top;
-  }
 }

 .note-role {

--- a/app/assets/stylesheets/pages/notifications.scss
+++ b/app/assets/stylesheets/pages/notifications.scss
@@ -35,8 +35,4 @@
 .notification {
  position: relative;
  top: 1px;
-
-  .fa {
-    font-size: 18px;
-  }
 }
--- a/app/assets/stylesheets/pages/projects.scss
+++ b/app/assets/stylesheets/pages/projects.scss
@@ -140,10 +140,6 @@
      margin-left: 0;
    }

-    .fa {
-      color: $layout-link-gray;
-    }
-
    svg {
      fill: $layout-link-gray;
    }
@@ -163,13 +159,6 @@
    height: 24px;
  }

-  .dropdown-toggle,
-  .clone-dropdown-btn {
-    .fa {
-      color: unset;
-    }
-  }
-
  .home-panel-action-button,
  .project-action-button {
    margin: $gl-padding $gl-padding-8 0 0;
@@ -492,7 +481,7 @@
      top: 0;
      height: calc(100% - #{$browser-scrollbar-size});

-      .fa {
+      svg {
        top: 50%;
        margin-top: -$gl-padding-8;
      }