Align some title icons and fix linting

- Use single quotes on strings / paths in HAML
- Some icons are used in titles which have a bigger font
size thus need different vertical-alignment compared to
body text.

app/views/admin/application_settings/ci/_header.html.haml

@@ -2,7 +2,7 @@
 
 %h4
   = _('Variables')
-  = link_to sprite_icon('question-o'), help_page_path('ci/variables/README', anchor: 'custom-environment-variables'), target: '_blank', rel: 'noopener noreferrer'
+  = link_to sprite_icon('question-o', css_class: 'gl-vertical-align-baseline!'), help_page_path('ci/variables/README', anchor: 'custom-environment-variables'), target: '_blank', rel: 'noopener noreferrer'
 
 %button.btn.btn-default.js-settings-toggle{ type: 'button' }
   = expanded ? _('Collapse') : _('Expand')

app/views/ci/variables/_header.html.haml

@@ -2,7 +2,7 @@
 
 %h4
   = _('Variables')
-  = link_to sprite_icon('question-o'), help_page_path('ci/variables/README', anchor: 'custom-environment-variables'), target: '_blank', rel: 'noopener noreferrer'
+  = link_to sprite_icon('question-o', css_class: 'gl-vertical-align-baseline!'), help_page_path('ci/variables/README', anchor: 'custom-environment-variables'), target: '_blank', rel: 'noopener noreferrer'
 
 %button.btn.btn-default.js-settings-toggle{ type: 'button' }
   = expanded ? _('Collapse') : _('Expand')

app/views/projects/_new_project_fields.html.haml

@@ -47,7 +47,7 @@
 
 = f.label :visibility_level, class: 'label-bold' do
   = s_('ProjectsNew|Visibility Level')
-  = link_to sprite_icon('question-o'), help_page_path("public_access/public_access"), aria: { label: 'Documentation for Visibility Level' }, target: '_blank', rel: 'noopener noreferrer'
+  = link_to sprite_icon('question-o'), help_page_path('public_access/public_access'), aria: { label: 'Documentation for Visibility Level' }, target: '_blank', rel: 'noopener noreferrer'
 = render 'shared/visibility_level', f: f, visibility_level: visibility_level.to_i, can_change_visibility_level: true, form_model: @project, with_label: false
 
 - if !hide_init_with_readme

app/views/shared/_old_visibility_level.html.haml

 .form-group.row
   .col-sm-2.col-form-label
     = _('Visibility level')
-    = link_to sprite_icon('question-o'), help_page_path("public_access/public_access"), target: '_blank'
+    = link_to sprite_icon('question-o'), help_page_path('public_access/public_access'), target: '_blank'
   .col-sm-10
     = render 'shared/visibility_level', f: f, visibility_level: visibility_level, can_change_visibility_level: can_change_visibility_level, form_model: form_model, with_label: with_label

app/views/shared/snippets/_form.html.haml

@@ -37,7 +37,7 @@
       .form-group
         .font-weight-bold
           = _('Visibility level')
-          = link_to sprite_icon('question-o'), help_page_path("public_access/public_access"), target: '_blank'
+          = link_to sprite_icon('question-o'), help_page_path('public_access/public_access'), target: '_blank'
         = render 'shared/visibility_level', f: f, visibility_level: @snippet.visibility_level, can_change_visibility_level: true, form_model: @snippet, with_label: false
 
       - if params[:files]

ee/app/views/admin/application_settings/_repository_size_limit_setting.html.haml

@@ -8,4 +8,4 @@
   = form.number_field :repository_size_limit, value: form.object.repository_size_limit.try(:to_mb), class: 'form-control', min: 0, title: _('Maximum size limit for each repository.'), data: { toggle: 'tooltip', container: 'body' }
   %span.form-text.text-muted#repository_size_limit_help_block
     = _('Includes LFS objects. It can be overridden per group, or per project. 0 for unlimited.')
-    = link_to sprite_icon('question-o'), help_page_path("user/admin_area/settings/account_and_limit_settings")
+    = link_to sprite_icon('question-o'), help_page_path('user/admin_area/settings/account_and_limit_settings')

ee/app/views/admin/application_settings/_shared_runners_minutes_setting.html.haml

@@ -3,4 +3,4 @@
   = form.number_field :shared_runners_minutes, class: 'form-control'
   .form-text.text-muted
     = _('Set the maximum number of pipeline minutes that a group can use on shared Runners per month. 0 for unlimited.')
-    = link_to sprite_icon('question-o'), help_page_path("user/admin_area/settings/continuous_integration", anchor: "shared-runners-pipeline-minutes-quota"), target: '_blank'
+    = link_to sprite_icon('question-o'), help_page_path('user/admin_area/settings/continuous_integration', anchor: 'shared-runners-pipeline-minutes-quota'), target: '_blank'

ee/app/views/namespaces/_shared_runner_status.html.haml

@@ -6,4 +6,4 @@
     %span.light Pipeline minutes quota:
     %strong
       = ci_minutes_report(minutes_quota.monthly_minutes_report)
-      = link_to sprite_icon('question-o'), help_page_path("user/admin_area/settings/continuous_integration", anchor: "shared-runners-pipeline-minutes-quota"), target: '_blank'
+      = link_to sprite_icon('question-o'), help_page_path('user/admin_area/settings/continuous_integration', anchor: 'shared-runners-pipeline-minutes-quota'), target: '_blank'

ee/app/views/namespaces/_shared_runners_minutes_setting.html.haml

@@ -11,4 +11,4 @@
       Set the maximum number of pipeline minutes that a group can use on shared Runners per month.
       Set 0 for unlimited.
       Set empty to inherit the global setting of #{Gitlab::CurrentSettings.shared_runners_minutes}.
-      = link_to sprite_icon('question-o'), help_page_path("user/admin_area/settings/continuous_integration", anchor: "shared-runners-pipeline-minutes-quota"), target: '_blank'
+      = link_to sprite_icon('question-o'), help_page_path('user/admin_area/settings/continuous_integration', anchor: 'shared-runners-pipeline-minutes-quota'), target: '_blank'