Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c4f02fac
Commit
c4f02fac
authored
Nov 18, 2020
by
Coung Ngo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove non-existent feature flags in specs
Remove feature flags from specs that no longer exist as they are debt
parent
9546e89c
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
0 additions
and
24 deletions
+0
-24
ee/spec/finders/epics_finder_spec.rb
ee/spec/finders/epics_finder_spec.rb
+0
-4
ee/spec/models/gitlab_subscription_spec.rb
ee/spec/models/gitlab_subscription_spec.rb
+0
-4
spec/features/merge_request/user_resolves_conflicts_spec.rb
spec/features/merge_request/user_resolves_conflicts_spec.rb
+0
-5
spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb
...s/merge_request/user_sees_merge_request_pipelines_spec.rb
+0
-1
spec/features/projects/diffs/diff_show_spec.rb
spec/features/projects/diffs/diff_show_spec.rb
+0
-4
spec/finders/fork_projects_finder_spec.rb
spec/finders/fork_projects_finder_spec.rb
+0
-2
spec/services/projects/fork_service_spec.rb
spec/services/projects/fork_service_spec.rb
+0
-4
No files found.
ee/spec/finders/epics_finder_spec.rb
View file @
c4f02fac
...
@@ -675,10 +675,6 @@ RSpec.describe EpicsFinder do
...
@@ -675,10 +675,6 @@ RSpec.describe EpicsFinder do
end
end
context
'when using group cte for search'
do
context
'when using group cte for search'
do
before
do
stub_feature_flags
(
use_subquery_for_group_issues_search:
false
)
end
it
'returns correct counts when search string is used'
do
it
'returns correct counts when search string is used'
do
results
=
described_class
.
new
(
results
=
described_class
.
new
(
search_user
,
search_user
,
...
...
ee/spec/models/gitlab_subscription_spec.rb
View file @
c4f02fac
...
@@ -5,10 +5,6 @@ require 'spec_helper'
...
@@ -5,10 +5,6 @@ require 'spec_helper'
RSpec
.
describe
GitlabSubscription
do
RSpec
.
describe
GitlabSubscription
do
using
RSpec
::
Parameterized
::
TableSyntax
using
RSpec
::
Parameterized
::
TableSyntax
before
do
stub_feature_flags
(
elasticsearch_index_only_paid_groups:
false
)
end
%i[free_plan bronze_plan silver_plan gold_plan]
.
each
do
|
plan
|
%i[free_plan bronze_plan silver_plan gold_plan]
.
each
do
|
plan
|
let_it_be
(
plan
)
{
create
(
plan
)
}
let_it_be
(
plan
)
{
create
(
plan
)
}
end
end
...
...
spec/features/merge_request/user_resolves_conflicts_spec.rb
View file @
c4f02fac
...
@@ -8,11 +8,6 @@ RSpec.describe 'Merge request > User resolves conflicts', :js do
...
@@ -8,11 +8,6 @@ RSpec.describe 'Merge request > User resolves conflicts', :js do
let
(
:project
)
{
create
(
:project
,
:repository
)
}
let
(
:project
)
{
create
(
:project
,
:repository
)
}
let
(
:user
)
{
project
.
creator
}
let
(
:user
)
{
project
.
creator
}
before
do
# In order to have the diffs collapsed, we need to disable the increase feature
stub_feature_flags
(
gitlab_git_diff_size_limit_increase:
false
)
end
def
create_merge_request
(
source_branch
)
def
create_merge_request
(
source_branch
)
create
(
:merge_request
,
source_branch:
source_branch
,
target_branch:
'conflict-start'
,
source_project:
project
,
merge_status: :unchecked
)
do
|
mr
|
create
(
:merge_request
,
source_branch:
source_branch
,
target_branch:
'conflict-start'
,
source_project:
project
,
merge_status: :unchecked
)
do
|
mr
|
mr
.
mark_as_unmergeable
mr
.
mark_as_unmergeable
...
...
spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb
View file @
c4f02fac
...
@@ -27,7 +27,6 @@ RSpec.describe 'Merge request > User sees pipelines triggered by merge request',
...
@@ -27,7 +27,6 @@ RSpec.describe 'Merge request > User sees pipelines triggered by merge request',
before
do
before
do
stub_application_setting
(
auto_devops_enabled:
false
)
stub_application_setting
(
auto_devops_enabled:
false
)
stub_feature_flags
(
ci_merge_request_pipeline:
true
)
stub_ci_pipeline_yaml_file
(
YAML
.
dump
(
config
))
stub_ci_pipeline_yaml_file
(
YAML
.
dump
(
config
))
project
.
add_maintainer
(
user
)
project
.
add_maintainer
(
user
)
sign_in
(
user
)
sign_in
(
user
)
...
...
spec/features/projects/diffs/diff_show_spec.rb
View file @
c4f02fac
...
@@ -155,10 +155,6 @@ RSpec.describe 'Diff file viewer', :js do
...
@@ -155,10 +155,6 @@ RSpec.describe 'Diff file viewer', :js do
context
'binary file that appears to be text in the first 1024 bytes'
do
context
'binary file that appears to be text in the first 1024 bytes'
do
before
do
before
do
# The file we're visiting is smaller than 10 KB and we want it collapsed
# so we need to disable the size increase feature.
stub_feature_flags
(
gitlab_git_diff_size_limit_increase:
false
)
visit_commit
(
'7b1cf4336b528e0f3d1d140ee50cafdbc703597c'
)
visit_commit
(
'7b1cf4336b528e0f3d1d140ee50cafdbc703597c'
)
end
end
...
...
spec/finders/fork_projects_finder_spec.rb
View file @
c4f02fac
...
@@ -14,8 +14,6 @@ RSpec.describe ForkProjectsFinder do
...
@@ -14,8 +14,6 @@ RSpec.describe ForkProjectsFinder do
let
(
:private_fork_member
)
{
create
(
:user
)
}
let
(
:private_fork_member
)
{
create
(
:user
)
}
before
do
before
do
stub_feature_flags
(
object_pools:
source_project
)
private_fork
.
update!
(
visibility_level:
Gitlab
::
VisibilityLevel
::
PRIVATE
)
private_fork
.
update!
(
visibility_level:
Gitlab
::
VisibilityLevel
::
PRIVATE
)
private_fork
.
add_developer
(
private_fork_member
)
private_fork
.
add_developer
(
private_fork_member
)
...
...
spec/services/projects/fork_service_spec.rb
View file @
c4f02fac
...
@@ -344,10 +344,6 @@ RSpec.describe Projects::ForkService do
...
@@ -344,10 +344,6 @@ RSpec.describe Projects::ForkService do
let
(
:fork_from_project
)
{
create
(
:project
,
:public
)
}
let
(
:fork_from_project
)
{
create
(
:project
,
:public
)
}
let
(
:forker
)
{
create
(
:user
)
}
let
(
:forker
)
{
create
(
:user
)
}
before
do
stub_feature_flags
(
object_pools:
true
)
end
context
'when no pool exists'
do
context
'when no pool exists'
do
it
'creates a new object pool'
do
it
'creates a new object pool'
do
forked_project
=
fork_project
(
fork_from_project
,
forker
,
using_service:
true
)
forked_project
=
fork_project
(
fork_from_project
,
forker
,
using_service:
true
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment