Use guard clause in Helm::InstallCommand

c6e459d2 · Dylan Griffith · b169ec7f · c6e459d2
Commit c6e459d2 authored Jul 27, 2018 by Dylan Griffith
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

lib/gitlab/kubernetes/helm/install_command.rb lib/gitlab/kubernetes/helm/install_command.rb +6 -6

No files found.
--- a/lib/gitlab/kubernetes/helm/install_command.rb
+++ b/lib/gitlab/kubernetes/helm/install_command.rb
@@ -43,12 +43,12 @@ module Gitlab
        end

        def optional_tls_flags
-          if files.key?(:'ca.pem')
-            " --tls" \
-              " --tls-ca-cert #{files_dir}/ca.pem" \
-              " --tls-cert #{files_dir}/cert.pem" \
-              " --tls-key #{files_dir}/key.pem"
-          end
+          return unless files.key?(:'ca.pem')
+
+          " --tls" \
+            " --tls-ca-cert #{files_dir}/ca.pem" \
+            " --tls-cert #{files_dir}/cert.pem" \
+            " --tls-key #{files_dir}/key.pem"
        end
      end
    end