Commit c6fdb76c authored by Filipa Lacerda's avatar Filipa Lacerda

Merge branch 'noteable-discussion-ee-differences-ce' into 'master'

CE port of noteable-discussion-ee-differences

See merge request gitlab-org/gitlab-ce!25638
parents 7d121601 573dd592
<script> <script>
import { mapState, mapGetters, mapActions } from 'vuex'; import { mapState, mapGetters, mapActions } from 'vuex';
import { s__ } from '~/locale'; import { s__ } from '~/locale';
import diffLineNoteFormMixin from 'ee_else_ce/notes/mixins/diff_line_note_form';
import noteForm from '../../notes/components/note_form.vue'; import noteForm from '../../notes/components/note_form.vue';
import autosave from '../../notes/mixins/autosave'; import autosave from '../../notes/mixins/autosave';
import { DIFF_NOTE_TYPE } from '../constants'; import { DIFF_NOTE_TYPE } from '../constants';
...@@ -9,7 +10,7 @@ export default { ...@@ -9,7 +10,7 @@ export default {
components: { components: {
noteForm, noteForm,
}, },
mixins: [autosave], mixins: [autosave, diffLineNoteFormMixin],
props: { props: {
diffFileHash: { diffFileHash: {
type: String, type: String,
...@@ -103,6 +104,7 @@ export default { ...@@ -103,6 +104,7 @@ export default {
:help-page-path="helpPagePath" :help-page-path="helpPagePath"
save-button-title="Comment" save-button-title="Comment"
class="diff-comment-form" class="diff-comment-form"
@handleFormUpdateAddToReview="addToReview"
@cancelForm="handleCancelCommentForm" @cancelForm="handleCancelCommentForm"
@handleFormUpdate="handleSaveNote" @handleFormUpdate="handleSaveNote"
/> />
......
...@@ -6,6 +6,7 @@ import { truncateSha } from '~/lib/utils/text_utility'; ...@@ -6,6 +6,7 @@ import { truncateSha } from '~/lib/utils/text_utility';
import { s__, __, sprintf } from '~/locale'; import { s__, __, sprintf } from '~/locale';
import systemNote from '~/vue_shared/components/notes/system_note.vue'; import systemNote from '~/vue_shared/components/notes/system_note.vue';
import icon from '~/vue_shared/components/icon.vue'; import icon from '~/vue_shared/components/icon.vue';
import diffLineNoteFormMixin from 'ee_else_ce/notes/mixins/diff_line_note_form';
import TimelineEntryItem from '~/vue_shared/components/notes/timeline_entry_item.vue'; import TimelineEntryItem from '~/vue_shared/components/notes/timeline_entry_item.vue';
import Flash from '../../flash'; import Flash from '../../flash';
import { SYSTEM_NOTE } from '../constants'; import { SYSTEM_NOTE } from '../constants';
...@@ -47,12 +48,13 @@ export default { ...@@ -47,12 +48,13 @@ export default {
placeholderSystemNote, placeholderSystemNote,
ResolveWithIssueButton, ResolveWithIssueButton,
systemNote, systemNote,
DraftNote: () => import('ee_component/batch_comments/components/draft_note.vue'),
TimelineEntryItem, TimelineEntryItem,
}, },
directives: { directives: {
GlTooltip: GlTooltipDirective, GlTooltip: GlTooltipDirective,
}, },
mixins: [autosave, noteable, resolvable, discussionNavigation], mixins: [autosave, noteable, resolvable, discussionNavigation, diffLineNoteFormMixin],
props: { props: {
discussion: { discussion: {
type: Object, type: Object,
...@@ -510,6 +512,7 @@ Please check your network connection and try again.`; ...@@ -510,6 +512,7 @@ Please check your network connection and try again.`;
:is-editing="false" :is-editing="false"
:line="diffLine" :line="diffLine"
save-button-title="Comment" save-button-title="Comment"
@handleFormUpdateAddToReview="addReplyToReview"
@handleFormUpdate="saveReply" @handleFormUpdate="saveReply"
@cancelForm="cancelReplyForm" @cancelForm="cancelReplyForm"
/> />
......
export default {
computed: {
draftForDiscussion: () => () => ({}),
},
methods: {
showDraft: () => false,
addReplyToReview: () => {},
addToReview: () => {},
},
};
...@@ -245,6 +245,17 @@ module.exports = { ...@@ -245,6 +245,17 @@ module.exports = {
jQuery: 'jquery', jQuery: 'jquery',
}), }),
new webpack.NormalModuleReplacementPlugin(/^ee_component\/(.*)\.vue/, function(resource) {
if (Object.keys(module.exports.resolve.alias).indexOf('ee') >= 0) {
resource.request = resource.request.replace(/^ee_component/, 'ee');
} else {
resource.request = path.join(
ROOT_PATH,
'app/assets/javascripts/vue_shared/components/empty_component.js'
);
}
}),
// compression can require a lot of compute time and is disabled in CI // compression can require a lot of compute time and is disabled in CI
IS_PRODUCTION && !NO_COMPRESSION && new CompressionPlugin(), IS_PRODUCTION && !NO_COMPRESSION && new CompressionPlugin(),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment