Merge branch 'frozen-string-ee-lib-gitlab' into 'master'

Enable some frozen string in ee/lib

See merge request gitlab-org/gitlab-ee!8989

ee/changelogs/unreleased/frozen-string-ee-lib-gitlab.yml

+---
+title: Enable some frozen string in ee/lib
+merge_request:
+author:
+type: performance

ee/lib/gitlab/auth/group_saml/config.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module GroupSaml

ee/lib/gitlab/auth/group_saml/dynamic_settings.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module GroupSaml

ee/lib/gitlab/auth/group_saml/failure_handler.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module GroupSaml

ee/lib/gitlab/auth/group_saml/group_lookup.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module GroupSaml

ee/lib/gitlab/auth/group_saml/identity_linker.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module GroupSaml

ee/lib/gitlab/auth/group_saml/membership_updater.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module GroupSaml

ee/lib/gitlab/auth/group_saml/user.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module GroupSaml

ee/lib/gitlab/authority_analyzer.rb

+# frozen_string_literal: true
+
 module Gitlab
   class AuthorityAnalyzer
     COMMITS_TO_CONSIDER = 25

ee/lib/gitlab/chat/responder/base.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Chat
     module Responder

ee/lib/gitlab/custom_file_templates.rb

+# frozen_string_literal: true
+
 module Gitlab
   class CustomFileTemplates
     include ::Gitlab::Utils::StrongMemoize

ee/lib/gitlab/database/load_balancing.rb

+# frozen_string_literal: true
+
 # rubocop:disable GitlabSecurity/PublicSend
 
 module Gitlab

ee/lib/gitlab/database/load_balancing/active_record_proxy.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Database
     module LoadBalancing

ee/lib/gitlab/database/load_balancing/connection_proxy.rb

+# frozen_string_literal: true
+
 # rubocop:disable GitlabSecurity/PublicSend
 
 module Gitlab

ee/lib/gitlab/database/load_balancing/host.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Database
     module LoadBalancing

ee/lib/gitlab/database/load_balancing/host_list.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Database
     module LoadBalancing

ee/lib/gitlab/database/load_balancing/load_balancer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Database
     module LoadBalancing

ee/lib/gitlab/database/load_balancing/rack_middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Database
     module LoadBalancing

ee/lib/gitlab/database/load_balancing/session.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Database
     module LoadBalancing

ee/lib/gitlab/database/load_balancing/sticking.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Database
     module LoadBalancing

ee/lib/gitlab/elastic/client.rb

+# frozen_string_literal: true
+
 # This file is required by `bin/elastic_repo_indexer` as well as from within
 # Rails, so needs to explicitly require its dependencies
 require 'elasticsearch'

ee/lib/gitlab/elastic/helper.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Elastic
     class Helper

ee/lib/gitlab/elastic/indexer.rb

+# frozen_string_literal: true
+
 # Create a separate process, which does not load the Rails environment, to index
 # each repository. This prevents memory leaks in the indexer from affecting the
 # rest of the application.

ee/lib/gitlab/elastic/project_search_results.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Elastic
     # Always prefer to use the full class namespace when specifying a

ee/lib/gitlab/elastic/search_results.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Elastic
     class SearchResults

ee/lib/gitlab/elastic/snippet_search_results.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Elastic
     class SnippetSearchResults < ::Gitlab::SnippetSearchResults

ee/lib/gitlab/geo/base_request.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class BaseRequest

ee/lib/gitlab/geo/cron_manager.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class CronManager

ee/lib/gitlab/geo/database_tasks.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module DatabaseTasks

ee/lib/gitlab/geo/event_gap_tracking.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class EventGapTracking

ee/lib/gitlab/geo/fdw.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module Fdw

ee/lib/gitlab/geo/file_downloader.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/file_transfer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/file_uploader.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/geo_tasks.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module GeoTasks

ee/lib/gitlab/geo/health_check.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class HealthCheck
@@ -20,9 +22,13 @@ module Gitlab
         return 'The Geo database is not configured to use Foreign Data Wrapper.' unless Gitlab::Geo::Fdw.enabled?
 
         unless Gitlab::Geo::Fdw.fdw_up_to_date?
-          return "The Geo database has an outdated FDW remote schema.".tap do |output|
-            output << " It contains #{Gitlab::Geo::Fdw.count_tables} of #{Gitlab::Geo::Fdw.gitlab_tables.count} expected tables." unless Gitlab::Geo::Fdw.count_tables_match?
+          output = "The Geo database has an outdated FDW remote schema."
+
+          unless Gitlab::Geo::Fdw.count_tables_match?
+            output = "#{output} It contains #{Gitlab::Geo::Fdw.count_tables} of #{Gitlab::Geo::Fdw.gitlab_tables.count} expected tables."
           end
+
+          return output
         end
 
         ''

ee/lib/gitlab/geo/job_artifact_downloader.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/job_artifact_transfer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/job_artifact_uploader.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/jwt_request_decoder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class JwtRequestDecoder

ee/lib/gitlab/geo/lfs_downloader.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/lfs_transfer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/lfs_uploader.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     # This class is responsible for:

ee/lib/gitlab/geo/log_cursor/daemon.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/event_logs.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/base_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/job_artifact_deleted_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/lfs_object_deleted_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/repositories_changed_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/repository_created_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/repository_deleted_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/repository_renamed_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/repository_updated_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/events/upload_deleted_event.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/lease.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_cursor/logger.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogCursor

ee/lib/gitlab/geo/log_helpers.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module LogHelpers

ee/lib/gitlab/geo/logger.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class Logger < ::Gitlab::JsonLogger

ee/lib/gitlab/geo/project_log_helpers.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     module ProjectLogHelpers

ee/lib/gitlab/geo/repo_sync_request.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class RepoSyncRequest < BaseRequest

ee/lib/gitlab/geo/transfer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class Transfer

ee/lib/gitlab/geo/transfer_request.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Geo
     class TransferRequest < BaseRequest

ee/lib/gitlab/geo_logger.rb

+# frozen_string_literal: true
+
 module Gitlab
   class GeoLogger < Gitlab::Logger
     def self.file_name_noext

ee/lib/gitlab/jira/dvcs.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Jira
     module Dvcs

ee/lib/gitlab/jira/middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Jira
     class Middleware

ee/lib/gitlab/kerberos/authentication.rb

+# frozen_string_literal: true
+
 # This calls helps to authenticate to Kerberos by providing username and password
 module Gitlab
   module Kerberos

ee/lib/gitlab/kubernetes/deployment.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     class Deployment

ee/lib/gitlab/kubernetes/rollout_status.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     # Calculates the rollout status for a set of kubernetes deployments.

ee/lib/gitlab/mirror.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Mirror
     # Runs scheduler every minute

ee/lib/gitlab/pagination_delegate.rb

+# frozen_string_literal: true
+
 module Gitlab
   class PaginationDelegate
     DEFAULT_PER_PAGE = Kaminari.config.default_per_page

ee/lib/gitlab/path_locks_finder.rb

+# frozen_string_literal: true
+
 # The database stores locked paths as following:
 # 'app/models/user.rb' or 'app/models'
 # To determine that 'app/models/user.rb' is locked we need to generate

ee/lib/gitlab/prometheus/queries/cluster_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

ee/lib/gitlab/prometheus/queries/validate_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

ee/lib/gitlab/proxy.rb

+# frozen_string_literal: true
+
 module Gitlab
   class Proxy
     class << self

ee/lib/gitlab/repository_size_error.rb

+# frozen_string_literal: true
+
 module Gitlab
   class RepositorySizeError
     include ActiveSupport::NumberHelper

ee/lib/gitlab/sidekiq_cluster.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SidekiqCluster
     # The signals that should terminate both the master and workers.

ee/lib/gitlab/sidekiq_cluster/cli.rb

+# frozen_string_literal: true
+
 require 'optparse'
 require 'logger'
 require 'time'

ee/lib/gitlab/slash_commands/application_help.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class ApplicationHelp < BaseCommand

ee/lib/gitlab/slash_commands/presenters/error.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

ee/lib/gitlab/template/custom_dockerfile_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class CustomDockerfileTemplate < CustomTemplate

ee/lib/gitlab/template/custom_gitignore_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class CustomGitignoreTemplate < CustomTemplate

ee/lib/gitlab/template/custom_gitlab_ci_yml_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class CustomGitlabCiYmlTemplate < CustomTemplate

ee/lib/gitlab/template/custom_license_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class CustomLicenseTemplate < CustomTemplate

ee/lib/gitlab/template/custom_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class CustomTemplate < BaseTemplate

ee/lib/gitlab/vulnerabilities/base_vulnerability.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Vulnerabilities
     class BaseVulnerability

ee/lib/gitlab/vulnerabilities/container_scanning_vulnerability.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Vulnerabilities
     class ContainerScanningVulnerability < BaseVulnerability

ee/lib/omni_auth/strategies/group_saml.rb

+# frozen_string_literal: true
+
 module OmniAuth
   module Strategies
     class GroupSaml < SAML

ee/lib/omni_auth/strategies/kerberos_spnego.rb

+# frozen_string_literal: true
+
 require 'omniauth'
 
 module OmniAuth

ee/lib/pseudonymizer/dumper.rb

+# frozen_string_literal: true
+
 module Pseudonymizer
   class Dumper
     attr_accessor :config, :output_dir

ee/lib/pseudonymizer/filter.rb

+# frozen_string_literal: true
+
 require 'openssl'
 require 'digest'
 

ee/lib/pseudonymizer/options.rb

+# frozen_string_literal: true
+
 module Pseudonymizer
   class Options
     attr_reader :config

ee/lib/pseudonymizer/pager.rb

+# frozen_string_literal: true
+
 module Pseudonymizer
   class Pager
     PAGE_SIZE = ENV.fetch('PSEUDONYMIZER_BATCH', 100_000)

ee/lib/pseudonymizer/uploader.rb

+# frozen_string_literal: true
+
 module Pseudonymizer
   ObjectStorageUnavailableError = Class.new(StandardError)
 

ee/lib/system_check/geo/authorized_keys_check.rb

+# frozen_string_literal: true
+
 module SystemCheck
   module Geo
     class AuthorizedKeysCheck < ::SystemCheck::BaseCheck

ee/lib/system_check/geo/authorized_keys_flag_check.rb

+# frozen_string_literal: true
+
 module SystemCheck
   module Geo
     class AuthorizedKeysFlagCheck < ::SystemCheck::BaseCheck

ee/lib/system_check/geo/clocks_synchronization_check.rb

+# frozen_string_literal: true
+
 module SystemCheck
   module Geo
     class ClocksSynchronizationCheck < SystemCheck::BaseCheck

ee/lib/system_check/geo/database_replication_check.rb

+# frozen_string_literal: true
+
 module SystemCheck
   module Geo
     class DatabaseReplicationCheck < SystemCheck::BaseCheck