Commit c8e20d6f authored by Matija Čupić's avatar Matija Čupić

Check for correct builds collection

parent 7e5bbc0d
...@@ -102,6 +102,8 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do ...@@ -102,6 +102,8 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do
describe 'GET show' do describe 'GET show' do
let!(:job) { create(:ci_build, :failed, pipeline: pipeline) } let!(:job) { create(:ci_build, :failed, pipeline: pipeline) }
let!(:second_job) { create(:ci_build, :failed, pipeline: pipeline) }
let!(:third_job) { create(:ci_build, :failed) }
context 'when requesting HTML' do context 'when requesting HTML' do
context 'when job exists' do context 'when job exists' do
...@@ -113,6 +115,13 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do ...@@ -113,6 +115,13 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do
expect(response).to have_gitlab_http_status(:ok) expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:build).id).to eq(job.id) expect(assigns(:build).id).to eq(job.id)
end end
it 'has the correct build collection' do
builds = assigns(:builds).map(&:id)
expect(builds).to include(job.id, second_job.id)
expect(builds).not_to include(third_job.id)
end
end end
context 'when job does not exist' do context 'when job does not exist' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment