Merge branch '348677-enable-by-default' into 'master'

Enable `packages_installable_package_files` by default

See merge request gitlab-org/gitlab!78254

app/controllers/projects/packages/infrastructure_registry_controller.rb

@@ -9,7 +9,7 @@ module Projects
 
       def show
         @package = project.packages.find(params[:id])
-        @package_files = if Feature.enabled?(:packages_installable_package_files)
+        @package_files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                            @package.installable_package_files.recent
                          else
                            @package.package_files.recent

app/finders/packages/package_file_finder.rb

@@ -19,7 +19,7 @@ class Packages::PackageFileFinder
   private
 
   def package_files
-    files = if Feature.enabled?(:packages_installable_package_files)
+    files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
               package.installable_package_files
             else
               package.package_files

app/graphql/types/packages/package_details_type.rb

@@ -37,7 +37,7 @@ module Types
       end
 
       def package_files
-        if Feature.enabled?(:packages_installable_package_files)
+        if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
           object.installable_package_files
         else
           object.package_files

app/models/concerns/packages/debian/distribution.rb

@@ -97,7 +97,7 @@ module Packages
         end
 
         def package_files
-          if Feature.enabled?(:packages_installable_package_files)
+          if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
             ::Packages::PackageFile.installable
                                    .for_package_ids(packages.select(:id))
           else

app/models/packages/package.rb

@@ -133,7 +133,7 @@ class Packages::Package < ApplicationRecord
   scope :without_nuget_temporary_name, -> { where.not(name: Packages::Nuget::TEMPORARY_PACKAGE_NAME) }
 
   scope :has_version, -> { where.not(version: nil) }
-  scope :preload_files, -> { Feature.enabled?(:packages_installable_package_files) ? preload(:installable_package_files) : preload(:package_files) }
+  scope :preload_files, -> { Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml) ? preload(:installable_package_files) : preload(:package_files) }
   scope :preload_pipelines, -> { preload(pipelines: :user) }
   scope :last_of_each_version, -> { where(id: all.select('MAX(id) AS id').group(:version)) }
   scope :limit_recent, ->(limit) { order_created_desc.limit(limit) }

app/models/packages/package_file.rb

@@ -58,7 +58,7 @@ class Packages::PackageFile < ApplicationRecord
                .merge(project.packages.helm.installable)
                .joins(:helm_file_metadatum)
                .where(packages_helm_file_metadata: { channel: channel })
-    result = result.installable if Feature.enabled?(:packages_installable_package_files)
+    result = result.installable if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
     result
   end
 
@@ -109,7 +109,7 @@ class Packages::PackageFile < ApplicationRecord
     cte_name = :packages_cte
     cte = Gitlab::SQL::CTE.new(cte_name, packages.select(:id))
 
-    package_files = if Feature.enabled?(:packages_installable_package_files)
+    package_files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                       ::Packages::PackageFile.installable.limit_recent(1)
                         .where(arel_table[:package_id].eq(Arel.sql("#{cte_name}.id")))
                     else

app/presenters/packages/conan/package_presenter.rb

@@ -81,7 +81,7 @@ module Packages
         return unless @package
 
         strong_memoize(:package_files) do
-          if Feature.enabled?(:packages_installable_package_files)
+          if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
             @package.installable_package_files.preload_conan_file_metadata
           else
             @package.package_files.preload_conan_file_metadata

app/presenters/packages/detail/package_presenter.rb

@@ -39,7 +39,7 @@ module Packages
       private
 
       def package_file_views
-        package_files = if Feature.enabled?(:packages_installable_package_files)
+        package_files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                           @package.installable_package_files
                         else
                           @package.package_files

app/presenters/packages/npm/package_presenter.rb

@@ -26,7 +26,7 @@ module Packages
                                      .preload_npm_metadatum
 
           batched_packages.each do |package|
-            package_file = if Feature.enabled?(:packages_installable_package_files)
+            package_file = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                              package.installable_package_files.last
                            else
                              package.package_files.last

app/presenters/packages/nuget/presenter_helpers.rb

@@ -27,7 +27,7 @@ module Packages
       end
 
       def archive_url_for(package)
-        package_files = if Feature.enabled?(:packages_installable_package_files)
+        package_files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                           package.installable_package_files
                         else
                           package.package_files

app/presenters/packages/pypi/package_presenter.rb

@@ -36,7 +36,7 @@ module Packages
         refs = []
 
         @packages.map do |package|
-          package_files = if Feature.enabled?(:packages_installable_package_files)
+          package_files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                             package.installable_package_files
                           else
                             package.package_files

app/services/packages/maven/metadata/sync_service.rb

@@ -93,7 +93,7 @@ module Packages
         def metadata_package_file_for(package)
           return unless package
 
-          package_files = if Feature.enabled?(:packages_installable_package_files)
+          package_files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                             package.installable_package_files
                           else
                             package.package_files

config/feature_flags/development/packages_installable_package_files.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/348677
 milestone: '14.6'
 type: development
 group: group::package
-default_enabled: false
+default_enabled: true

lib/api/package_files.rb

@@ -28,7 +28,7 @@ module API
         package = ::Packages::PackageFinder
           .new(user_project, params[:package_id]).execute
 
-        package_files = if Feature.enabled?(:packages_installable_package_files)
+        package_files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                           package.installable_package_files
                         else
                           package.package_files
@@ -55,7 +55,7 @@ module API
 
         not_found! unless package
 
-        package_files = if Feature.enabled?(:packages_installable_package_files)
+        package_files = if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                           package.installable_package_files
                         else
                           package.package_files

lib/api/rubygem_packages.rb

@@ -69,7 +69,7 @@ module API
           package_files = ::Packages::PackageFile
                             .for_rubygem_with_file_name(user_project, params[:file_name])
 
-          package_files = package_files.installable if Feature.enabled?(:packages_installable_package_files)
+          package_files = package_files.installable if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
 
           package_file = package_files.last!
 

lib/api/terraform/modules/v1/packages.rb

@@ -71,7 +71,7 @@ module API
 
             def package_file
               strong_memoize(:package_file) do
-                if Feature.enabled?(:packages_installable_package_files)
+                if Feature.enabled?(:packages_installable_package_files, default_enabled: :yaml)
                   package.installable_package_files.first
                 else
                   package.package_files.first