Merge branch...

Merge branch '338575-set-assumeimmutableresults-to-true-by-default-and-remove-it-from-createdefaultclient' into 'master' Set `assumeImmutableResults` to `true` by default See merge request gitlab-org/gitlab!73455

Merge branch...
Merge branch '338575-set-assumeimmutableresults-to-true-by-default-and-remove-it-from-createdefaultclient' into 'master' Set `assumeImmutableResults` to `true` by default See merge request gitlab-org/gitlab!73455
c9ab16a2 · Illya Klymov · 69597558 · c6f9101f · c9ab16a2 · c9ab16a2
Commit c9ab16a2 authored Nov 01, 2021 by Illya Klymov
99 changed files
--- a/app/assets/javascripts/access_tokens/index.js
+++ b/app/assets/javascripts/access_tokens/index.js
@@ -49,7 +49,7 @@ export const initProjectsField = () => {
            { default: createDefaultClient },
          ]) => {
            const apolloProvider = new VueApollo({
-              defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+              defaultClient: createDefaultClient(),
            });

            Vue.use(VueApollo);

--- a/app/assets/javascripts/admin/users/index.js
+++ b/app/assets/javascripts/admin/users/index.js
@@ -15,7 +15,7 @@ import {
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 const initApp = (el, component, userPropKey, props = {}) => {

--- a/app/assets/javascripts/alert_management/list.js
+++ b/app/assets/javascripts/alert_management/list.js
@@ -38,7 +38,6 @@ export default () => {
            return defaultDataIdFromObject(object);
          },
        },
-        assumeImmutableResults: true,
      },
    ),
  });

--- a/app/assets/javascripts/alerts_settings/graphql.js
+++ b/app/assets/javascripts/alerts_settings/graphql.js
@@ -59,6 +59,5 @@ export default new VueApollo({
    cacheConfig: {
      fragmentMatcher,
    },
-    assumeImmutableResults: true,
  }),
 });
--- a/app/assets/javascripts/analytics/usage_trends/index.js
+++ b/app/assets/javascripts/analytics/usage_trends/index.js
@@ -6,7 +6,7 @@ import UsageTrendsApp from './components/app.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/app/assets/javascripts/artifacts_settings/index.js
+++ b/app/assets/javascripts/artifacts_settings/index.js
@@ -6,7 +6,7 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default (containerId = 'js-artifacts-settings-app') => {

--- a/app/assets/javascripts/boards/graphql.js
+++ b/app/assets/javascripts/boards/graphql.js
@@ -17,6 +17,5 @@ export const gqlClient = createDefaultClient(

      fragmentMatcher,
    },
-    assumeImmutableResults: true,
  },
 );
--- a/app/assets/javascripts/boards/mount_multiple_boards_switcher.js
+++ b/app/assets/javascripts/boards/mount_multiple_boards_switcher.js
@@ -8,12 +8,7 @@ import { parseBoolean } from '~/lib/utils/common_utils';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });

 export default (params = {}) => {

--- a/app/assets/javascripts/ci_lint/index.js
+++ b/app/assets/javascripts/ci_lint/index.js
@@ -8,9 +8,7 @@ import CiLint from './components/ci_lint.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(resolvers, {
-    assumeImmutableResults: true,
-  }),
+  defaultClient: createDefaultClient(resolvers),
 });

 export default (containerId = '#js-ci-lint') => {

--- a/app/assets/javascripts/clusters/agents/index.js
+++ b/app/assets/javascripts/clusters/agents/index.js
@@ -12,12 +12,7 @@ export default () => {
    return null;
  }

-  const defaultClient = createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  );
+  const defaultClient = createDefaultClient();
  const { agentName, projectPath } = el.dataset;

  return new Vue({

--- a/app/assets/javascripts/clusters_list/load_agents.js
+++ b/app/assets/javascripts/clusters_list/load_agents.js
@@ -8,7 +8,7 @@ export default (Vue, VueApollo) => {
    return null;
  }

-  const defaultClient = createDefaultClient({}, { assumeImmutableResults: true });
+  const defaultClient = createDefaultClient();

  const {
    emptyStateImage,

--- a/app/assets/javascripts/design_management/graphql.js
+++ b/app/assets/javascripts/design_management/graphql.js
@@ -88,7 +88,6 @@ const defaultClient = createDefaultClient(
      fragmentMatcher,
    },
    typeDefs,
-    assumeImmutableResults: true,
  },
 );


--- a/app/assets/javascripts/environments/folder/environments_folder_bundle.js
+++ b/app/assets/javascripts/environments/folder/environments_folder_bundle.js
@@ -8,7 +8,7 @@ Vue.use(Translate);
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/app/assets/javascripts/environments/graphql/client.js
+++ b/app/assets/javascripts/environments/graphql/client.js
@@ -2,16 +2,12 @@ import VueApollo from 'vue-apollo';
 import createDefaultClient from '~/lib/graphql';
 import environmentApp from './queries/environmentApp.query.graphql';
 import { resolvers } from './resolvers';
-import typedefs from './typedefs.graphql';
+import typeDefs from './typedefs.graphql';

 export const apolloProvider = (endpoint) => {
-  const defaultClient = createDefaultClient(
-    resolvers(endpoint),
-    {
-      assumeImmutableResults: true,
-    },
-    typedefs,
-  );
+  const defaultClient = createDefaultClient(resolvers(endpoint), {
+    typeDefs,
+  });
  const { cache } = defaultClient;

  cache.writeQuery({

--- a/app/assets/javascripts/environments/index.js
+++ b/app/assets/javascripts/environments/index.js
@@ -9,7 +9,7 @@ Vue.use(Translate);
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default (el) => {

--- a/app/assets/javascripts/error_tracking/details.js
+++ b/app/assets/javascripts/error_tracking/details.js
@@ -20,12 +20,7 @@ export default () => {
  } = domEl.dataset;

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient(
-      {},
-      {
-        assumeImmutableResults: true,
-      },
-    ),
+    defaultClient: createDefaultClient(),
  });

  // eslint-disable-next-line no-new

--- a/app/assets/javascripts/import_entities/import_groups/graphql/client_factory.js
+++ b/app/assets/javascripts/import_entities/import_groups/graphql/client_factory.js
@@ -376,8 +376,4 @@ export function createResolvers({ endpoints, sourceUrl, GroupsManager = SourceGr
 }

 export const createApolloClient = ({ sourceUrl, endpoints }) =>
-  createDefaultClient(
-    createResolvers({ sourceUrl, endpoints }),
-    { assumeImmutableResults: true },
-    typeDefs,
-  );
+  createDefaultClient(createResolvers({ sourceUrl, endpoints }), { typeDefs });
--- a/app/assets/javascripts/incidents/list.js
+++ b/app/assets/javascripts/incidents/list.js
@@ -24,7 +24,7 @@ export default () => {
  } = domEl.dataset;

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/app/assets/javascripts/issuable_suggestions/index.js
+++ b/app/assets/javascripts/issuable_suggestions/index.js
@@ -10,12 +10,7 @@ export default function initIssuableSuggestions() {
  const issueTitle = document.getElementById('issue_title');
  const { projectPath } = el.dataset;
  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient(
-      {},
-      {
-        assumeImmutableResults: true,
-      },
-    ),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/app/assets/javascripts/issues_list/index.js
+++ b/app/assets/javascripts/issues_list/index.js
@@ -24,7 +24,7 @@ export function mountJiraIssuesListApp() {
  }

  Vue.use(VueApollo);
-  const defaultClient = createDefaultClient({}, { assumeImmutableResults: true });
+  const defaultClient = createDefaultClient();
  const apolloProvider = new VueApollo({
    defaultClient,
  });
@@ -103,7 +103,7 @@ export function mountIssuesListApp() {
    },
  };

-  const defaultClient = createDefaultClient(resolvers, { assumeImmutableResults: true });
+  const defaultClient = createDefaultClient(resolvers);
  const apolloProvider = new VueApollo({
    defaultClient,
  });

--- a/app/assets/javascripts/jira_connect/branches/index.js
+++ b/app/assets/javascripts/jira_connect/branches/index.js
@@ -14,12 +14,7 @@ export default async function initJiraConnectBranches() {
  const { initialBranchName, successStateSvgPath } = el.dataset;

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient(
-      {},
-      {
-        assumeImmutableResults: true,
-      },
-    ),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/app/assets/javascripts/jira_import/index.js
+++ b/app/assets/javascripts/jira_import/index.js
@@ -6,7 +6,7 @@ import App from './components/jira_import_app.vue';

 Vue.use(VueApollo);

-const defaultClient = createDefaultClient({}, { assumeImmutableResults: true });
+const defaultClient = createDefaultClient();

 const apolloProvider = new VueApollo({
  defaultClient,

--- a/app/assets/javascripts/jobs/components/table/index.js
+++ b/app/assets/javascripts/jobs/components/table/index.js
@@ -9,12 +9,7 @@ Vue.use(VueApollo);
 Vue.use(GlToast);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });

 export default (containerId = 'js-jobs-table') => {

--- a/app/assets/javascripts/lib/graphql.js
+++ b/app/assets/javascripts/lib/graphql.js
@@ -48,7 +48,6 @@ export const stripWhitespaceFromQuery = (url, path) => {

 export default (resolvers = {}, config = {}) => {
  const {
-    assumeImmutableResults,
    baseUrl,
    batchMax = 10,
    cacheConfig,
@@ -161,10 +160,10 @@ export default (resolvers = {}, config = {}) => {
    link: appLink,
    cache: new InMemoryCache({
      ...cacheConfig,
-      freezeResults: assumeImmutableResults,
+      freezeResults: true,
    }),
    resolvers,
-    assumeImmutableResults,
+    assumeImmutableResults: true,
    defaultOptions: {
      query: {
        fetchPolicy,

--- a/app/assets/javascripts/mr_popover/index.js
+++ b/app/assets/javascripts/mr_popover/index.js
@@ -48,12 +48,7 @@ export default (elements) => {
    Vue.use(VueApollo);

    const apolloProvider = new VueApollo({
-      defaultClient: createDefaultClient(
-        {},
-        {
-          assumeImmutableResults: true,
-        },
-      ),
+      defaultClient: createDefaultClient(),
    });
    const listenerAddedAttr = 'data-mr-listener-added';


--- a/app/assets/javascripts/packages_and_registries/dependency_proxy/graphql/index.js
+++ b/app/assets/javascripts/packages_and_registries/dependency_proxy/graphql/index.js
@@ -5,10 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });
--- a/app/assets/javascripts/packages_and_registries/package_registry/graphql/index.js
+++ b/app/assets/javascripts/packages_and_registries/package_registry/graphql/index.js
@@ -17,7 +17,6 @@ export const apolloProvider = new VueApollo({
      cacheConfig: {
        fragmentMatcher,
      },
-      assumeImmutableResults: true,
    },
  ),
 });
--- a/app/assets/javascripts/packages_and_registries/settings/group/graphql/index.js
+++ b/app/assets/javascripts/packages_and_registries/settings/group/graphql/index.js
@@ -5,10 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });
--- a/app/assets/javascripts/packages_and_registries/settings/project/graphql/index.js
+++ b/app/assets/javascripts/packages_and_registries/settings/project/graphql/index.js
@@ -5,10 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });
--- a/app/assets/javascripts/pages/projects/blob/show/index.js
+++ b/app/assets/javascripts/pages/projects/blob/show/index.js
@@ -14,7 +14,7 @@ import '~/sourcegraph/load';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 const viewBlobEl = document.querySelector('#js-view-blob-app');

--- a/app/assets/javascripts/pages/projects/merge_requests/init_merge_request_show.js
+++ b/app/assets/javascripts/pages/projects/merge_requests/init_merge_request_show.js
@@ -28,7 +28,7 @@ export default function initMergeRequestShow() {

  const el = document.querySelector('.js-mr-status-box');
  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });
  // eslint-disable-next-line no-new
  new Vue({

--- a/app/assets/javascripts/pages/shared/mount_runner_instructions.js
+++ b/app/assets/javascripts/pages/shared/mount_runner_instructions.js
@@ -9,12 +9,7 @@ export function initInstallRunner(componentId = 'js-install-runner') {
  const installRunnerEl = document.getElementById(componentId);

  if (installRunnerEl) {
-    const defaultClient = createDefaultClient(
-      {},
-      {
-        assumeImmutableResults: true,
-      },
-    );
+    const defaultClient = createDefaultClient();

    const apolloProvider = new VueApollo({
      defaultClient,

--- a/app/assets/javascripts/pipeline_editor/index.js
+++ b/app/assets/javascripts/pipeline_editor/index.js
@@ -61,7 +61,6 @@ export const initPipelineEditor = (selector = '#js-pipeline-editor') => {
    defaultClient: createDefaultClient(resolvers, {
      typeDefs,
      useGet: true,
-      assumeImmutableResults: true,
    }),
  });
  const { cache } = apolloProvider.clients.defaultClient;

--- a/app/assets/javascripts/pipelines/pipeline_shared_client.js
+++ b/app/assets/javascripts/pipelines/pipeline_shared_client.js
@@ -5,7 +5,6 @@ export const apolloProvider = new VueApollo({
  defaultClient: createDefaultClient(
    {},
    {
-      assumeImmutableResults: true,
      useGet: true,
    },
  ),

--- a/app/assets/javascripts/projects/commit_box/info/init_commit_pipeline_mini_graph.js
+++ b/app/assets/javascripts/projects/commit_box/info/init_commit_pipeline_mini_graph.js
@@ -5,12 +5,7 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });

 export const initCommitPipelineMiniGraph = async (selector = '.js-commit-pipeline-mini-graph') => {

--- a/app/assets/javascripts/projects/new/index.js
+++ b/app/assets/javascripts/projects/new/index.js
@@ -50,7 +50,7 @@ export function initNewProjectUrlSelect() {
      new Vue({
        el,
        apolloProvider: new VueApollo({
-          defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+          defaultClient: createDefaultClient(),
        }),
        provide: {
          namespaceFullPath: el.dataset.namespaceFullPath,

--- a/app/assets/javascripts/projects/pipelines/charts/index.js
+++ b/app/assets/javascripts/projects/pipelines/charts/index.js
@@ -7,7 +7,7 @@ import ProjectPipelinesCharts from './components/app.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 const mountPipelineChartsApp = (el) => {

--- a/app/assets/javascripts/projects/storage_counter/index.js
+++ b/app/assets/javascripts/projects/storage_counter/index.js
@@ -25,7 +25,7 @@ export default (containerId = 'js-project-storage-count-app') => {
  } = el.dataset;

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/app/assets/javascripts/projects/terraform_notification/index.js
+++ b/app/assets/javascripts/projects/terraform_notification/index.js
@@ -6,7 +6,7 @@ import TerraformNotification from './components/terraform_notification.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmtableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/app/assets/javascripts/registry/explorer/graphql/index.js
+++ b/app/assets/javascripts/registry/explorer/graphql/index.js
@@ -9,7 +9,6 @@ export const apolloProvider = new VueApollo({
    {},
    {
      batchMax: 1,
-      assumeImmutableResults: true,
    },
  ),
 });
--- a/app/assets/javascripts/releases/mount_index.js
+++ b/app/assets/javascripts/releases/mount_index.js
@@ -24,7 +24,6 @@ export default () => {
          // the purpose of making separate requests. So we explicitly
          // disable batching on this page.
          batchMax: 1,
-          assumeImmutableResults: true,
        },
      ),
    });

--- a/app/assets/javascripts/releases/mount_show.js
+++ b/app/assets/javascripts/releases/mount_show.js
@@ -6,12 +6,7 @@ import ReleaseShowApp from './components/app_show.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/app/assets/javascripts/repository/graphql.js
+++ b/app/assets/javascripts/repository/graphql.js
@@ -64,7 +64,6 @@ const defaultClient = createDefaultClient(
        /* eslint-enable @gitlab/require-i18n-strings */
      },
    },
-    assumeImmutableResults: true,
  },
 );


--- a/app/assets/javascripts/runner/admin_runners/index.js
+++ b/app/assets/javascripts/runner/admin_runners/index.js
@@ -19,12 +19,7 @@ export const initAdminRunners = (selector = '#js-admin-runners') => {
  const { activeRunnersCount, registrationToken, runnerInstallHelpPage } = el.dataset;

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient(
-      {},
-      {
-        assumeImmutableResults: true,
-      },
-    ),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/app/assets/javascripts/runner/group_runners/index.js
+++ b/app/assets/javascripts/runner/group_runners/index.js
@@ -23,12 +23,7 @@ export const initGroupRunners = (selector = '#js-group-runners') => {
  } = el.dataset;

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient(
-      {},
-      {
-        assumeImmutableResults: true,
-      },
-    ),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/app/assets/javascripts/runner/runner_details/index.js
+++ b/app/assets/javascripts/runner/runner_details/index.js
@@ -15,12 +15,7 @@ export const initRunnerDetail = (selector = '#js-runner-details') => {
  const { runnerId } = el.dataset;

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient(
-      {},
-      {
-        assumeImmutableResults: true,
-      },
-    ),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/app/assets/javascripts/security_configuration/index.js
+++ b/app/assets/javascripts/security_configuration/index.js
@@ -14,7 +14,7 @@ export const initSecurityConfiguration = (el) => {
  Vue.use(VueApollo);

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  const {

--- a/app/assets/javascripts/sidebar/graphql.js
+++ b/app/assets/javascripts/sidebar/graphql.js
@@ -25,7 +25,6 @@ export const defaultClient = createDefaultClient(resolvers, {
  cacheConfig: {
    fragmentMatcher,
  },
-  assumeImmutableResults: true,
 });

 export const apolloProvider = new VueApollo({

--- a/app/assets/javascripts/snippets/index.js
+++ b/app/assets/javascripts/snippets/index.js
@@ -18,7 +18,6 @@ export default function appFactory(el, Component) {
      {},
      {
        batchMax: 1,
-        assumeImmutableResults: true,
      },
    ),
  });

--- a/app/assets/javascripts/static_site_editor/graphql/index.js
+++ b/app/assets/javascripts/static_site_editor/graphql/index.js
@@ -22,7 +22,6 @@ const createApolloProvider = (appData) => {
    },
    {
      typeDefs,
-      assumeImmutableResults: true,
    },
  );


--- a/app/assets/javascripts/terraform/index.js
+++ b/app/assets/javascripts/terraform/index.js
@@ -22,7 +22,6 @@ export default () => {
        return object.id || defaultDataIdFromObject(object);
      },
    },
-    assumeImmutableResults: true,
  });

  const { emptyStateImage, projectPath, accessTokensPath, terraformApiUrl, username } = el.dataset;

--- a/app/assets/javascripts/token_access/index.js
+++ b/app/assets/javascripts/token_access/index.js
@@ -6,7 +6,7 @@ import TokenAccess from './components/token_access.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export const initTokenAccess = (containerId = 'js-ci-token-access-app') => {

--- a/app/assets/javascripts/vue_merge_request_widget/index.js
+++ b/app/assets/javascripts/vue_merge_request_widget/index.js
@@ -13,12 +13,7 @@ Vue.use(Translate);
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/app/assets/javascripts/vue_shared/alert_details/index.js
+++ b/app/assets/javascripts/vue_shared/alert_details/index.js
@@ -38,7 +38,6 @@ export default (selector) => {
          return defaultDataIdFromObject(object);
        },
      },
-      assumeImmutableResults: true,
    }),
  });


--- a/app/assets/javascripts/vue_shared/security_configuration/provider.js
+++ b/app/assets/javascripts/vue_shared/security_configuration/provider.js
@@ -5,5 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export default new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });
--- a/app/assets/javascripts/work_items/graphql/provider.js
+++ b/app/assets/javascripts/work_items/graphql/provider.js
@@ -4,6 +4,7 @@ import { IntrospectionFragmentMatcher } from 'apollo-cache-inmemory';
 import createDefaultClient from '~/lib/graphql';
 import workItemQuery from './work_item.query.graphql';
 import introspectionQueryResultData from './fragmentTypes.json';
+import typeDefs from './typedefs.graphql';

 const fragmentMatcher = new IntrospectionFragmentMatcher({
  introspectionQueryResultData,
@@ -18,7 +19,7 @@ export function createApolloProvider() {
      cacheConfig: {
        fragmentMatcher,
      },
-      assumeImmutableResults: true,
+      typeDefs,
    },
  );


--- a/doc/development/fe_guide/graphql.md
+++ b/doc/development/fe_guide/graphql.md
@@ -103,7 +103,6 @@ Default client accepts two parameters: `resolvers` and `config`.
 - `config` parameter takes an object of configuration settings:
  - `cacheConfig` field accepts an optional object of settings to [customize Apollo cache](https://www.apollographql.com/docs/react/caching/cache-configuration/#configuring-the-cache)
  - `baseUrl` allows us to pass a URL for GraphQL endpoint different from our main endpoint (for example, `${gon.relative_url_root}/api/graphql`)
-  - `assumeImmutableResults` (set to `false` by default) - this setting, when set to `true`, assumes that every single operation on updating Apollo Cache is immutable. It also sets `freezeResults` to `true`, so any attempt on mutating Apollo Cache throws a console warning in development environment. Please ensure you're following the immutability pattern on cache update operations before setting this option to `true`.
  - `fetchPolicy` determines how you want your component to interact with the Apollo cache. Defaults to "cache-first".

 ### Multiple client queries for the same object
@@ -179,7 +178,7 @@ with a **new and updated** object.

 To facilitate the process of updating the cache and returning the new object we
 use the library [Immer](https://immerjs.github.io/immer/).
-When possible, follow these conventions:
+Please, follow these conventions:

 - The updated cache is named `data`.
 - The original cache data is named `sourceData`.
@@ -204,11 +203,6 @@ client.writeQuery({
 As shown in the code example by using `produce`, we can perform any kind of direct manipulation of the
 `draftState`. Besides, `immer` guarantees that a new state which includes the changes to `draftState` is generated.

-Finally, to verify whether the immutable cache update is working properly, we need to change
-`assumeImmutableResults` to `true` in the default client configuration. See [Apollo Client](#apollo-client) for more information.
-
-If everything is working properly `assumeImmutableResults` should remain set to `true`.
-
 ## Usage in Vue

 To use Vue Apollo, import the [Vue Apollo](https://github.com/vuejs/vue-apollo) plugin as well

--- a/ee/app/assets/javascripts/admin/subscriptions/show/mount_cloud_licenses.js
+++ b/ee/app/assets/javascripts/admin/subscriptions/show/mount_cloud_licenses.js
@@ -8,12 +8,7 @@ import CloudLicenseShowApp from './components/app.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/ee/app/assets/javascripts/analytics/cycle_analytics/index.js
+++ b/ee/app/assets/javascripts/analytics/cycle_analytics/index.js
@@ -14,12 +14,7 @@ Vue.use(GlToast);
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/ee/app/assets/javascripts/analytics/devops_report/devops_adoption/graphql.js
+++ b/ee/app/assets/javascripts/analytics/devops_report/devops_adoption/graphql.js
@@ -34,5 +34,5 @@ export const createResolvers = (groupId) => ({

 export const createApolloProvider = (groupId) =>
  new VueApollo({
-    defaultClient: createDefaultClient(createResolvers(groupId), { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(createResolvers(groupId)),
  });
--- a/ee/app/assets/javascripts/analytics/group_ci_cd_analytics/index.js
+++ b/ee/app/assets/javascripts/analytics/group_ci_cd_analytics/index.js
@@ -7,7 +7,7 @@ import CiCdAnalyticsApp from './components/app.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/ee/app/assets/javascripts/analytics/merge_request_analytics/index.js
+++ b/ee/app/assets/javascripts/analytics/merge_request_analytics/index.js
@@ -11,7 +11,7 @@ import { parseAndValidateDates } from './utils';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/ee/app/assets/javascripts/analytics/productivity_analytics/index.js
+++ b/ee/app/assets/javascripts/analytics/productivity_analytics/index.js
@@ -15,7 +15,7 @@ import { getLabelsEndpoint, getMilestonesEndpoint } from './utils';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/ee/app/assets/javascripts/analytics/repository_analytics/index.js
+++ b/ee/app/assets/javascripts/analytics/repository_analytics/index.js
@@ -6,7 +6,7 @@ import GroupRepositoryAnalytics from './components/group_repository_analytics.vu
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/ee/app/assets/javascripts/burndown_chart/index.js
+++ b/ee/app/assets/javascripts/burndown_chart/index.js
@@ -9,7 +9,7 @@ import BurnCharts from './components/burn_charts.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/ee/app/assets/javascripts/ci_minutes_usage/index.js
+++ b/ee/app/assets/javascripts/ci_minutes_usage/index.js
@@ -7,7 +7,7 @@ import CiMinutesUsageApp from './components/app.vue';
 const mountCiMinutesUsageApp = (el) => {
  Vue.use(VueApollo);

-  const defaultClient = createDefaultClient({}, { assumeImmutableResults: true });
+  const defaultClient = createDefaultClient();
  const apolloProvider = new VueApollo({
    defaultClient,
  });

--- a/ee/app/assets/javascripts/epic/new_epic_bundle.js
+++ b/ee/app/assets/javascripts/epic/new_epic_bundle.js
@@ -6,12 +6,7 @@ import EpicForm from './components/epic_form.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });

 export function initEpicForm() {

--- a/ee/app/assets/javascripts/epic_boards/index.js
+++ b/ee/app/assets/javascripts/epic_boards/index.js
@@ -32,7 +32,6 @@ const apolloProvider = new VueApollo({
      cacheConfig: {
        fragmentMatcher,
      },
-      assumeImmutableResults: true,
    },
  ),
 });

--- a/ee/app/assets/javascripts/epics_list/epics_list_bundle.js
+++ b/ee/app/assets/javascripts/epics_list/epics_list_bundle.js
@@ -18,12 +18,7 @@ export default function initEpicsList({ mountPointSelector }) {
  }

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient(
-      {},
-      {
-        assumeImmutableResults: true,
-      },
-    ),
+    defaultClient: createDefaultClient(),
  });

  const {

--- a/ee/app/assets/javascripts/escalation_policies/index.js
+++ b/ee/app/assets/javascripts/escalation_policies/index.js
@@ -19,7 +19,6 @@ const apolloProvider = new VueApollo({
          return defaultDataIdFromObject(object);
        },
      },
-      assumeImmutableResults: true,
    },
  ),
 });

--- a/ee/app/assets/javascripts/external_issues_list/graphql/index.js
+++ b/ee/app/assets/javascripts/external_issues_list/graphql/index.js
@@ -11,7 +11,7 @@ export default (externalIssuesQueryResolver) => {
    },
  };

-  const defaultClient = createDefaultClient(resolvers, { assumeImmutableResults: true });
+  const defaultClient = createDefaultClient(resolvers);

  return new VueApollo({
    defaultClient,

--- a/ee/app/assets/javascripts/groups/settings/compliance_frameworks/init_form.js
+++ b/ee/app/assets/javascripts/groups/settings/compliance_frameworks/init_form.js
@@ -9,7 +9,7 @@ import EditForm from './components/edit_form.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 const createComplianceFrameworksFormApp = (el) => {

--- a/ee/app/assets/javascripts/groups/settings/compliance_frameworks/init_list.js
+++ b/ee/app/assets/javascripts/groups/settings/compliance_frameworks/init_list.js
@@ -7,7 +7,7 @@ import Form from './components/list.vue';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 const createComplianceFrameworksListApp = (el) => {

--- a/ee/app/assets/javascripts/iterations/index.js
+++ b/ee/app/assets/javascripts/iterations/index.js
@@ -19,7 +19,6 @@ const apolloProvider = new VueApollo({
    {},
    {
      batchMax: 1,
-      assumeImmutableResults: true,
    },
  ),
 });

--- a/ee/app/assets/javascripts/on_demand_scans/graphql/provider.js
+++ b/ee/app/assets/javascripts/on_demand_scans/graphql/provider.js
@@ -4,12 +4,7 @@ import createDefaultClient from '~/lib/graphql';

 Vue.use(VueApollo);

-const defaultClient = createDefaultClient(
-  {},
-  {
-    assumeImmutableResults: true,
-  },
-);
+const defaultClient = createDefaultClient();

 export default new VueApollo({
  defaultClient,

--- a/ee/app/assets/javascripts/on_demand_scans_form/graphql/provider.js
+++ b/ee/app/assets/javascripts/on_demand_scans_form/graphql/provider.js
@@ -5,5 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export default new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });
--- a/ee/app/assets/javascripts/oncall_schedules/graphql.js
+++ b/ee/app/assets/javascripts/oncall_schedules/graphql.js
@@ -19,8 +19,5 @@ const resolvers = {
 };

 export default new VueApollo({
-  defaultClient: createDefaultClient(resolvers, {
-    cacheConfig: {},
-    assumeImmutableResults: true,
-  }),
+  defaultClient: createDefaultClient(resolvers),
 });
--- a/ee/app/assets/javascripts/pages/projects/edit/merge_options.js
+++ b/ee/app/assets/javascripts/pages/projects/edit/merge_options.js
@@ -47,7 +47,7 @@ const fetchMergeOptions = () => {
  const containerEl = document.querySelector('#project-merge-options');
  const { projectFullPath } = containerEl.dataset;

-  const defaultClient = createDefaultClient({}, { assumeImmutableResults: true });
+  const defaultClient = createDefaultClient();

  return defaultClient
    .query({

--- a/ee/app/assets/javascripts/requirements/requirements_bundle.js
+++ b/ee/app/assets/javascripts/requirements/requirements_bundle.js
@@ -34,7 +34,6 @@ export default () => {
            object.__typename === 'Requirement' ? object.iid : defaultDataIdFromObject(object),
          fragmentMatcher,
        },
-        assumeImmutableResults: true,
      },
    ),
  });

--- a/ee/app/assets/javascripts/roadmap/roadmap_bundle.js
+++ b/ee/app/assets/javascripts/roadmap/roadmap_bundle.js
@@ -30,7 +30,7 @@ export default () => {
  }

  Vue.use(VueApollo);
-  const defaultClient = createDefaultClient({}, { assumeImmutableResults: true });
+  const defaultClient = createDefaultClient();
  const apolloProvider = new VueApollo({
    defaultClient,
  });

--- a/ee/app/assets/javascripts/security_configuration/api_fuzzing/graphql/provider.js
+++ b/ee/app/assets/javascripts/security_configuration/api_fuzzing/graphql/provider.js
@@ -5,10 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(
-    {},
-    {
-      assumeImmutableResults: true,
-    },
-  ),
+  defaultClient: createDefaultClient(),
 });
--- a/ee/app/assets/javascripts/security_configuration/corpus_management/corpus_management_bundle.js
+++ b/ee/app/assets/javascripts/security_configuration/corpus_management/corpus_management_bundle.js
@@ -15,7 +15,6 @@ export default () => {
  }

  const defaultClient = createDefaultClient(resolvers, {
-    assumeImmutableResults: true,
    cacheConfig: {
      dataIdFromObject: (object) => {
        return object.id || defaultDataIdFromObject(object);

--- a/ee/app/assets/javascripts/security_configuration/dast/index.js
+++ b/ee/app/assets/javascripts/security_configuration/dast/index.js
@@ -13,7 +13,7 @@ export default function init() {
  Vue.use(VueApollo);

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  const {

--- a/ee/app/assets/javascripts/security_configuration/dast_profiles/dast_scanner_profiles/graphql/provider.js
+++ b/ee/app/assets/javascripts/security_configuration/dast_profiles/dast_scanner_profiles/graphql/provider.js
@@ -5,5 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export default new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });
--- a/ee/app/assets/javascripts/security_configuration/dast_profiles/dast_site_profiles/graphql/provider.js
+++ b/ee/app/assets/javascripts/security_configuration/dast_profiles/dast_site_profiles/graphql/provider.js
@@ -5,5 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export default new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });
--- a/ee/app/assets/javascripts/security_configuration/dast_profiles/graphql/provider.js
+++ b/ee/app/assets/javascripts/security_configuration/dast_profiles/graphql/provider.js
@@ -5,5 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export default new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });
--- a/ee/app/assets/javascripts/security_configuration/dast_site_validation/graphql/provider.js
+++ b/ee/app/assets/javascripts/security_configuration/dast_site_validation/graphql/provider.js
@@ -5,5 +5,5 @@ import createDefaultClient from '~/lib/graphql';
 Vue.use(VueApollo);

 export default new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });
--- a/ee/app/assets/javascripts/security_configuration/sast/index.js
+++ b/ee/app/assets/javascripts/security_configuration/sast/index.js
@@ -13,7 +13,7 @@ export default function init() {
  Vue.use(VueApollo);

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  const {

--- a/ee/app/assets/javascripts/security_dashboard/graphql/provider.js
+++ b/ee/app/assets/javascripts/security_dashboard/graphql/provider.js
@@ -18,7 +18,6 @@ const defaultClient = createDefaultClient(
    cacheConfig: {
      fragmentMatcher,
    },
-    assumeImmutableResults: true,
  },
 );


--- a/ee/app/assets/javascripts/storage_counter/index.js
+++ b/ee/app/assets/javascripts/storage_counter/index.js
@@ -15,7 +15,7 @@ export default () => {
  } = el.dataset;

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/ee/app/assets/javascripts/subscriptions/buy_addons_shared/graphql.js
+++ b/ee/app/assets/javascripts/subscriptions/buy_addons_shared/graphql.js
@@ -11,14 +11,13 @@ Vue.use(VueApollo);

 const gitlabClient = createClient(merge({}, resolvers, purchaseFlowResolvers), {
  typeDefs,
-  assumeImmutableResults: true,
 });
+
 const customersDotClient = createClient(
  {},
  {
    path: '/-/customers_dot/proxy/graphql',
    useGet: true,
-    assumeImmutableResults: true,
  },
 );


--- a/ee/app/assets/javascripts/subscriptions/new/graphql.js
+++ b/ee/app/assets/javascripts/subscriptions/new/graphql.js
@@ -8,7 +8,6 @@ import { STEPS } from '../constants';
 function createClient(stepList) {
  const client = createDefaultClient(resolvers, {
    typeDefs,
-    assumeImmutableResults: true,
  });

  client.cache.writeQuery({

--- a/ee/app/assets/javascripts/test_case_create/test_case_create_bundle.js
+++ b/ee/app/assets/javascripts/test_case_create/test_case_create_bundle.js
@@ -15,7 +15,7 @@ export function initTestCaseCreate({ mountPointSelector }) {
  }

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  return new Vue({

--- a/ee/app/assets/javascripts/test_case_list/test_case_list_bundle.js
+++ b/ee/app/assets/javascripts/test_case_list/test_case_list_bundle.js
@@ -19,7 +19,7 @@ const initTestCaseList = ({ mountPointSelector }) => {
  }

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  const {

--- a/ee/app/assets/javascripts/test_case_show/test_case_show_bundle.js
+++ b/ee/app/assets/javascripts/test_case_show/test_case_show_bundle.js
@@ -16,7 +16,7 @@ export default function initTestCaseShow({ mountPointSelector }) {
  }

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  const sidebarOptions = JSON.parse(el.dataset.sidebarOptions);

--- a/ee/app/assets/javascripts/threat_monitoring/index.js
+++ b/ee/app/assets/javascripts/threat_monitoring/index.js
@@ -12,7 +12,6 @@ const apolloProvider = new VueApollo({
  defaultClient: createDefaultClient(
    {},
    {
-      assumeImmutableResults: true,
      cacheConfig: {
        dataIdFromObject: (object) => {
          // eslint-disable-next-line no-underscore-dangle

--- a/ee/app/assets/javascripts/threat_monitoring/security_policies_list.js
+++ b/ee/app/assets/javascripts/threat_monitoring/security_policies_list.js
@@ -9,7 +9,7 @@ import createStore from './store';
 Vue.use(VueApollo);

 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+  defaultClient: createDefaultClient(),
 });

 export default () => {

--- a/ee/app/assets/javascripts/threat_monitoring/utils.js
+++ b/ee/app/assets/javascripts/threat_monitoring/utils.js
@@ -50,9 +50,4 @@ export const removeUnnecessaryDashes = (manifest) => {
 /**
 * Create GraphQL Client for threat monitoring
 */
-export const gqClient = createGqClient(
-  {},
-  {
-    assumeImmutableResults: true,
-  },
-);
+export const gqClient = createGqClient();
--- a/ee/app/assets/javascripts/vue_shared/components/sidebar/iterations_dropdown_bundle.js
+++ b/ee/app/assets/javascripts/vue_shared/components/sidebar/iterations_dropdown_bundle.js
@@ -15,7 +15,7 @@ export default function initIterationsDropdownBundle() {
  }

  const apolloProvider = new VueApollo({
-    defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),
+    defaultClient: createDefaultClient(),
  });

  const { fullPath } = el.dataset;