Merge branch '204742-migrating-fa-spinner-to-default-shared-notifications' into 'master'

[UPDATE] Migrating `fa-spinner` from `app/views/shared/notifications`

Closes #204742

See merge request gitlab-org/gitlab!24940

app/assets/javascripts/notifications_form.js

@@ -26,7 +26,7 @@ export default class NotificationsForm {
       .addClass('is-loading')
       .find('.custom-notification-event-loading')
       .removeClass('fa-check')
-      .addClass('fa-spin fa-spinner')
+      .addClass('spinner align-middle')
       .removeClass('is-done');
   }
 
@@ -41,12 +41,12 @@ export default class NotificationsForm {
         if (data.saved) {
           $parent
             .find('.custom-notification-event-loading')
-            .toggleClass('fa-spin fa-spinner fa-check is-done');
+            .toggleClass('spinner fa-check is-done align-middle');
           setTimeout(() => {
             $parent
               .removeClass('is-loading')
               .find('.custom-notification-event-loading')
-              .toggleClass('fa-spin fa-spinner fa-check is-done');
+              .toggleClass('spinner fa-check is-done align-middle');
           }, 2000);
         }
       })

app/views/shared/notifications/_custom_notifications.html.haml

@@ -30,4 +30,4 @@
                       %label.form-check-label{ for: field_id }
                         %strong
                           = notification_event_name(event)
-                          = icon("spinner spin", class: "custom-notification-event-loading")
+                          .fa.custom-notification-event-loading.spinner