Merge branch 'issue#220040-fix-rails-savebang-wiki-model' into 'master'

Fix Rails/SaveBang Rubocop offenses for wiki_page models

See merge request gitlab-org/gitlab!57899

.rubocop.yml

@@ -575,6 +575,9 @@ Rails/SaveBang:
     - 'ee/spec/**/*.rb'
     - 'qa/spec/**/*.rb'
     - 'qa/qa/specs/**/*.rb'
+  Exclude:
+  - spec/models/wiki_page/**/*
+  - spec/models/wiki_page_spec.rb
 
 Cop/PutProjectRoutesUnderScope:
   Include:

.rubocop_manual_todo.yml

@@ -245,8 +245,6 @@ Rails/SaveBang:
     - 'spec/models/user_preference_spec.rb'
     - 'spec/models/user_spec.rb'
     - 'spec/models/user_status_spec.rb'
-    - 'spec/models/wiki_page/meta_spec.rb'
-    - 'spec/models/wiki_page_spec.rb'
 
 Rails/TimeZone:
   Enabled: true

changelogs/unreleased/issue-220040-fix-rails-savebang-wiki-model.yml

+---
+title: Fix Rails/SaveBang Rubocop offenses for wiki_page models
+merge_request: 57899
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/models/wiki_page/meta_spec.rb

@@ -42,7 +42,7 @@ RSpec.describe WikiPage::Meta do
     subject { described_class.find(meta.id) }
 
     let_it_be(:meta) do
-      described_class.create(title: generate(:wiki_page_title), project: project)
+      described_class.create!(title: generate(:wiki_page_title), project: project)
     end
 
     context 'there are no slugs' do
@@ -183,7 +183,7 @@ RSpec.describe WikiPage::Meta do
       #    an old slug that = canonical_slug
       different_slug = generate(:sluggified_title)
       create(:wiki_page_meta, project: project, canonical_slug: different_slug)
-        .slugs.create(slug: wiki_page.slug)
+        .slugs.create!(slug: wiki_page.slug)
     end
 
     shared_examples 'metadata examples' do