Merge branch 'tag-workers-that-need-their-own-queue' into 'master'

Tag workers that need their own queue

See merge request gitlab-org/gitlab!66553

app/workers/all_queues.yml

@@ -1020,6 +1020,7 @@
   :idempotent:
   :tags:
   - :exclude_from_gitlab_com
+  - :needs_own_queue
 - :name: hashed_storage:hashed_storage_project_migrate
   :worker_name: HashedStorage::ProjectMigrateWorker
   :feature_category: :source_code_management
@@ -1030,6 +1031,7 @@
   :idempotent:
   :tags:
   - :exclude_from_gitlab_com
+  - :needs_own_queue
 - :name: hashed_storage:hashed_storage_project_rollback
   :worker_name: HashedStorage::ProjectRollbackWorker
   :feature_category: :source_code_management
@@ -1040,6 +1042,7 @@
   :idempotent:
   :tags:
   - :exclude_from_gitlab_com
+  - :needs_own_queue
 - :name: hashed_storage:hashed_storage_rollbacker
   :worker_name: HashedStorage::RollbackerWorker
   :feature_category: :source_code_management
@@ -1050,6 +1053,7 @@
   :idempotent:
   :tags:
   - :exclude_from_gitlab_com
+  - :needs_own_queue
 - :name: incident_management:clusters_applications_check_prometheus_health
   :worker_name: Clusters::Applications::CheckPrometheusHealthWorker
   :feature_category: :incident_management
@@ -2028,7 +2032,8 @@
   :resource_boundary: :unknown
   :weight: 2
   :idempotent:
-  :tags: []
+  :tags:
+  - :needs_own_queue
 - :name: emails_on_push
   :worker_name: EmailsOnPushWorker
   :feature_category: :source_code_management
@@ -2771,7 +2776,8 @@
   :resource_boundary: :unknown
   :weight: 1
   :idempotent:
-  :tags: []
+  :tags:
+  - :needs_own_queue
 - :name: snippets_schedule_bulk_repository_shard_moves
   :worker_name: Snippets::ScheduleBulkRepositoryShardMovesWorker
   :feature_category: :gitaly

app/workers/email_receiver_worker.rb

@@ -11,6 +11,9 @@ class EmailReceiverWorker # rubocop:disable Scalability/IdempotentWorker
   urgency :high
   weight 2
 
+  # https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1087#jobs-written-to-redis-without-passing-through-the-application
+  tags :needs_own_queue
+
   attr_accessor :raw
 
   def perform(raw)

app/workers/hashed_storage/migrator_worker.rb

@@ -10,7 +10,10 @@ module HashedStorage
 
     queue_namespace :hashed_storage
     feature_category :source_code_management
-    tags :exclude_from_gitlab_com
+
+    # Gitlab::HashedStorage::Migrator#migration_pending? depends on the
+    # queue size of this worker.
+    tags :exclude_from_gitlab_com, :needs_own_queue
 
     # @param [Integer] start initial ID of the batch
     # @param [Integer] finish last ID of the batch

app/workers/hashed_storage/project_migrate_worker.rb

@@ -10,7 +10,10 @@ module HashedStorage
 
     queue_namespace :hashed_storage
     loggable_arguments 1
-    tags :exclude_from_gitlab_com
+
+    # Gitlab::HashedStorage::Migrator#migration_pending? depends on the
+    # queue size of this worker.
+    tags :exclude_from_gitlab_com, :needs_own_queue
 
     attr_reader :project_id
 

app/workers/hashed_storage/project_rollback_worker.rb

@@ -10,7 +10,10 @@ module HashedStorage
 
     queue_namespace :hashed_storage
     loggable_arguments 1
-    tags :exclude_from_gitlab_com
+
+    # Gitlab::HashedStorage::Migrator#rollback_pending? depends on the
+    # queue size of this worker.
+    tags :exclude_from_gitlab_com, :needs_own_queue
 
     attr_reader :project_id
 

app/workers/hashed_storage/rollbacker_worker.rb

@@ -10,7 +10,10 @@ module HashedStorage
 
     queue_namespace :hashed_storage
     feature_category :source_code_management
-    tags :exclude_from_gitlab_com
+
+    # Gitlab::HashedStorage::Migrator#rollback_pending? depends on the
+    # queue size of this worker.
+    tags :exclude_from_gitlab_com, :needs_own_queue
 
     # @param [Integer] start initial ID of the batch
     # @param [Integer] finish last ID of the batch

app/workers/service_desk_email_receiver_worker.rb

@@ -8,6 +8,9 @@ class ServiceDeskEmailReceiverWorker < EmailReceiverWorker # rubocop:disable Sca
   feature_category :service_desk
   sidekiq_options retry: 3
 
+  # https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1087#jobs-written-to-redis-without-passing-through-the-application
+  tags :needs_own_queue
+
   def should_perform?
     ::Gitlab::ServiceDeskEmail.enabled?
   end

ee/app/workers/all_queues.yml

@@ -1162,7 +1162,8 @@
   :resource_boundary: :unknown
   :weight: 1
   :idempotent: true
-  :tags: []
+  :tags:
+  - :needs_own_queue
 - :name: project_template_export
   :worker_name: ProjectTemplateExportWorker
   :feature_category: :templates

ee/app/workers/project_import_schedule_worker.rb

@@ -13,6 +13,10 @@ class ProjectImportScheduleWorker
   sidekiq_options retry: false
   loggable_arguments 1 # For the job waiter key
 
+  # UpdateAllMirrorsWorker depends on the queue size of this worker:
+  # https://gitlab.com/gitlab-org/gitlab/-/issues/325496#note_550866012
+  tags :needs_own_queue
+
   def perform(project_id)
     return if Gitlab::Database.read_only?