Merge branch 'frozen-string-enable-spec-rubocop' into 'master'

Enable frozen string for spec/rubocop

See merge request gitlab-org/gitlab!19277

.rubocop.yml

@@ -56,7 +56,7 @@ Style/FrozenStringLiteralComment:
     - 'qa/**/*'
     - 'rubocop/**/*'
     - 'scripts/**/*'
-    - 'spec/**/*'
+    - 'spec/lib/**/*'
 
 RSpec/FilePath:
   Exclude:

spec/rubocop/cop/avoid_break_from_strong_memoize_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubocop'
 require 'rubocop/rspec/support'

spec/rubocop/cop/avoid_return_from_blocks_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubocop'
 require 'rubocop/rspec/support'

spec/rubocop/cop/destroy_all_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubocop'
 require 'rubocop/rspec/support'

spec/rubocop/cop/gitlab/finder_with_find_by_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/gitlab/httparty_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubocop'
 require 'rubocop/rspec/support'

spec/rubocop/cop/gitlab/module_with_instance_variables_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubocop'
 require 'rubocop/rspec/support'

spec/rubocop/cop/gitlab/predicate_memoization_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubocop'
 require 'rubocop/rspec/support'

spec/rubocop/cop/group_public_or_visible_to_user_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubocop'
 require 'rubocop/rspec/support'

spec/rubocop/cop/include_sidekiq_worker_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/line_break_around_conditional_block_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubocop'
 require 'rubocop/rspec/support'

spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/add_concurrent_index_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/add_reference_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/add_timestamps_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/datetime_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/hash_index_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/remove_column_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/remove_concurrent_index_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/remove_index_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/reversible_add_column_with_default_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/safer_boolean_column_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/timestamps_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/update_column_in_batches_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/migration/update_large_table_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/project_path_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/rspec/env_assignment_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/rspec/factories_in_migration_specs_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/rubocop/cop/sidekiq_options_queue_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rubocop'

spec/support/generate-seed-repo-rb

 #!/usr/bin/env ruby
+# frozen_string_literal: true
 #
 # # generate-seed-repo-rb
 #
@@ -15,9 +16,9 @@
 require 'erb'
 require 'tempfile'
 
-SOURCE = File.expand_path('gitlab-git-test.git', __dir__).freeze
-SCRIPT_NAME = 'generate-seed-repo-rb'.freeze
-REPO_NAME = 'gitlab-git-test.git'.freeze
+SOURCE = File.expand_path('gitlab-git-test.git', __dir__)
+SCRIPT_NAME = 'generate-seed-repo-rb'
+REPO_NAME = 'gitlab-git-test.git'
 
 def main
   Dir.mktmpdir do |dir|

spec/support/prepare-gitlab-git-test-for-commit

 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 abort unless [
   system('spec/support/generate-seed-repo-rb', out: 'spec/support/helpers/seed_repo.rb'),

spec/support/unpack-gitlab-git-test

 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'fileutils'
 
-REPO = 'spec/support/gitlab-git-test.git'.freeze
+REPO = 'spec/support/gitlab-git-test.git'
 PACK_DIR = REPO + '/objects/pack'
 GIT = %W[git --git-dir=#{REPO}].freeze
-BASE_PACK = 'pack-691247af2a6acb0b63b73ac0cb90540e93614043'.freeze
+BASE_PACK = 'pack-691247af2a6acb0b63b73ac0cb90540e93614043'
 
 def main
   unpack