Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cdabe631
Commit
cdabe631
authored
Jan 15, 2020
by
Dennis Tang
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Change GitHub service integration token input to password
parent
5a1e492b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
1 deletion
+10
-1
changelogs/unreleased/security-mask-gh-service-password.yml
changelogs/unreleased/security-mask-gh-service-password.yml
+5
-0
ee/app/models/project_services/github_service.rb
ee/app/models/project_services/github_service.rb
+1
-1
ee/spec/features/projects/services/user_activates_github_spec.rb
.../features/projects/services/user_activates_github_spec.rb
+4
-0
No files found.
changelogs/unreleased/security-mask-gh-service-password.yml
0 → 100644
View file @
cdabe631
---
title
:
Change GitHub service integration token input to password
merge_request
:
author
:
type
:
security
ee/app/models/project_services/github_service.rb
View file @
cdabe631
...
@@ -38,7 +38,7 @@ class GithubService < Service
...
@@ -38,7 +38,7 @@ class GithubService < Service
def
fields
def
fields
[
[
{
type:
'
text
'
,
{
type:
'
password
'
,
name:
"token"
,
name:
"token"
,
required:
true
,
required:
true
,
placeholder:
"e.g. 8d3f016698e..."
,
placeholder:
"e.g. 8d3f016698e..."
,
...
...
ee/spec/features/projects/services/user_activates_github_spec.rb
View file @
cdabe631
...
@@ -39,6 +39,10 @@ describe 'User activates GitHub Service' do
...
@@ -39,6 +39,10 @@ describe 'User activates GitHub Service' do
expect
(
page
).
to
have_content
(
'GitHub activated.'
)
expect
(
page
).
to
have_content
(
'GitHub activated.'
)
end
end
it
'renders a token field of type `password` for masking input'
do
expect
(
find
(
'#service_token'
)[
'type'
]).
to
eq
(
'password'
)
end
context
'with pipelines'
,
:js
do
context
'with pipelines'
,
:js
do
let
(
:pipeline
)
{
create
(
:ci_pipeline
)
}
let
(
:pipeline
)
{
create
(
:ci_pipeline
)
}
let
(
:project
)
{
create
(
:project
,
ci_pipelines:
[
pipeline
])}
let
(
:project
)
{
create
(
:project
,
ci_pipelines:
[
pipeline
])}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment