Commit cdacba9a authored by Miguel Rincon's avatar Miguel Rincon

Remove unused js class

This change removes the class `js-title-container` from the breadcrumbs.

This js-* class is not used except for a single quarantined test. This
change also updates the test when it is taken out of quarantine it
still passes.
parent b6a7cdaa
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
= button_tag class: 'toggle-mobile-nav', type: 'button' do = button_tag class: 'toggle-mobile-nav', type: 'button' do
%span.sr-only= _("Open sidebar") %span.sr-only= _("Open sidebar")
= sprite_icon('hamburger', size: 18) = sprite_icon('hamburger', size: 18)
.breadcrumbs-links.js-title-container{ data: { qa_selector: 'breadcrumb_links_content' } } .breadcrumbs-links{ data: { testid: 'breadcrumb-links', qa_selector: 'breadcrumb_links_content' } }
%ul.list-unstyled.breadcrumbs-list.js-breadcrumbs-list %ul.list-unstyled.breadcrumbs-list.js-breadcrumbs-list
- unless hide_top_links - unless hide_top_links
= header_title = header_title
......
...@@ -16,18 +16,18 @@ RSpec.describe 'Subgroup Issuables', :js do ...@@ -16,18 +16,18 @@ RSpec.describe 'Subgroup Issuables', :js do
it 'shows the full subgroup title when issues index page is empty' do it 'shows the full subgroup title when issues index page is empty' do
visit project_issues_path(project) visit project_issues_path(project)
expect_to_have_full_subgroup_title expect_to_have_breadcrumb_links
end end
it 'shows the full subgroup title when merge requests index page is empty' do it 'shows the full subgroup title when merge requests index page is empty' do
visit project_merge_requests_path(project) visit project_merge_requests_path(project)
expect_to_have_full_subgroup_title expect_to_have_breadcrumb_links
end end
def expect_to_have_full_subgroup_title def expect_to_have_breadcrumb_links
title = find('.breadcrumbs-links') links = find('[data-testid="breadcrumb-links"]')
expect(title).to have_content 'group subgroup project' expect(links).to have_content 'group subgroup project'
end end
end end
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
RSpec.shared_examples 'error tracking index page' do RSpec.shared_examples 'error tracking index page' do
it 'renders the error index page', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/217810' } do it 'renders the error index page', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/217810' } do
within('div.js-title-container') do within('[data-testid="breadcrumb-links"]') do
expect(page).to have_content(project.namespace.name) expect(page).to have_content(project.namespace.name)
expect(page).to have_content(project.name) expect(page).to have_content(project.name)
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment