Changes counter name, improves testing

lib/gitlab/diff/custom_diff.rb

@@ -65,7 +65,7 @@ module Gitlab
 
         def rendered_timeout
           @rendered_timeout ||= Gitlab::Metrics.counter(
-            :rendered_timeout,
+            :ipynb_semantic_diff_timeouts_total,
             'Counts the times notebook rendering timed out'
           )
         end
@@ -80,7 +80,7 @@ module Gitlab
 
         def log_event(message, error = nil)
           Gitlab::AppLogger.info({ message: message })
-          Gitlab::ErrorTracking.log_exception(error) if error
+          Gitlab::ErrorTracking.track_exception(error) if error
           nil
         end
       end

spec/lib/gitlab/diff/custom_diff_spec.rb

@@ -53,8 +53,9 @@ RSpec.describe Gitlab::Diff::CustomDiff do
         end
 
         it 'increments metrics' do
+          counter = Gitlab::Metrics.counter(:ipynb_semantic_diff_timeouts_total, 'desc')
+
           expect(Timeout).to receive(:timeout).and_raise(Timeout::Error)
-          counter = Gitlab::Metrics.counter(:rendered_timeout, 'desc')
           expect { subject }.to change { counter.get(source: described_class::FOREGROUND_EXECUTION) }.by(1)
         end
       end
@@ -71,8 +72,9 @@ RSpec.describe Gitlab::Diff::CustomDiff do
         end
 
         it 'increments metrics' do
+          counter = Gitlab::Metrics.counter(:ipynb_semantic_diff_timeouts_total, 'desc')
+
           expect(Timeout).to receive(:timeout).and_raise(Timeout::Error)
-          counter = Gitlab::Metrics.counter(:rendered_timeout, 'desc')
           expect { subject }.to change { counter.get(source: described_class::BACKGROUND_EXECUTION) }.by(1)
         end
       end